Fix stale auth test blocking CI pipeline #66

New issue

Closed

opened 2026-03-13 19:12:45 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-13 19:12:45 +00:00

Owner

Lineage

plan-2026-03-08-tryout-prep → Phase 4 → Phase 4m (CI fix)

Repo

forgejo_admin/basketball-api

User Story

As a developer
I want CI to pass on main branch pushes
So that the Image Updater can detect new images and ArgoCD deploys automatically

Context

When the admin dashboard was made public for tryout day (commit 7b3e455), the auth test TestAdminDashboard::test_requires_auth was not updated. It still expects 401/403 but gets 200 since the endpoint is now public (intentionally).

This has broken every pipeline since pipeline #42 (~40 pipelines). Because the test step fails, the build-and-push step never runs, so no new images reach Harbor, so ArgoCD Image Updater has nothing to update, so the cluster stays on the old image.

Combined with the Woodpecker log streaming bug (empty logs), this was invisible.

136 tests pass. 1 stale test blocks everything.

File Targets

Files the agent should modify:

tests/test_tryouts.py — update TestAdminDashboard::test_requires_auth to expect 200 (endpoint is now intentionally public/unlisted, no auth required)

Files the agent should NOT touch:

src/basketball_api/routes/tryouts.py — the endpoint behavior is correct, the test is wrong

Acceptance Criteria

test_requires_auth updated to match current behavior (admin dashboard is public)
All 137 tests pass (pytest exits 0)
ruff check . passes
ruff format --check . passes

Test Expectations

Run: pytest tests/test_tryouts.py -k test_requires_auth -v
Run: pytest (full suite, all 137 must pass)

Constraints

The admin dashboard being public is intentional (tryout day requirement). Do NOT re-add auth.
The test should verify the endpoint IS accessible without auth (200), not that it requires auth.
Rename the test to something accurate like test_admin_dashboard_is_public or test_no_auth_required.

Checklist

PR opened
Tests pass
No unrelated changes

project-westside-basketball

### Lineage `plan-2026-03-08-tryout-prep` → Phase 4 → Phase 4m (CI fix) ### Repo `forgejo_admin/basketball-api` ### User Story As a developer I want CI to pass on main branch pushes So that the Image Updater can detect new images and ArgoCD deploys automatically ### Context When the admin dashboard was made public for tryout day (commit 7b3e455), the auth test `TestAdminDashboard::test_requires_auth` was not updated. It still expects 401/403 but gets 200 since the endpoint is now public (intentionally). This has broken **every pipeline since pipeline #42** (~40 pipelines). Because the `test` step fails, the `build-and-push` step never runs, so no new images reach Harbor, so ArgoCD Image Updater has nothing to update, so the cluster stays on the old image. Combined with the Woodpecker log streaming bug (empty logs), this was invisible. 136 tests pass. 1 stale test blocks everything. ### File Targets Files the agent should modify: - `tests/test_tryouts.py` — update `TestAdminDashboard::test_requires_auth` to expect 200 (endpoint is now intentionally public/unlisted, no auth required) Files the agent should NOT touch: - `src/basketball_api/routes/tryouts.py` — the endpoint behavior is correct, the test is wrong ### Acceptance Criteria - [ ] `test_requires_auth` updated to match current behavior (admin dashboard is public) - [ ] All 137 tests pass (`pytest` exits 0) - [ ] `ruff check .` passes - [ ] `ruff format --check .` passes ### Test Expectations - [ ] Run: `pytest tests/test_tryouts.py -k test_requires_auth -v` - [ ] Run: `pytest` (full suite, all 137 must pass) ### Constraints - The admin dashboard being public is intentional (tryout day requirement). Do NOT re-add auth. - The test should verify the endpoint IS accessible without auth (200), not that it requires auth. - Rename the test to something accurate like `test_admin_dashboard_is_public` or `test_no_auth_required`. ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `project-westside-basketball`