Fix stale auth test blocking CI pipeline #67

Merged

forgejo_admin merged 1 commit from 66-fix-stale-auth-test-blocking-ci-pipeline into main

2026-03-13 19:30:35 +00:00

forgejo_admin commented

2026-03-13 19:14:56 +00:00

Owner

Summary

The admin dashboard was made intentionally public for tryout day (commit 7b3e455), but TestAdminDashboard::test_requires_auth was never updated. It still expected 401/403 but got 200, blocking every CI pipeline since #42 (~40 pipelines). This single stale test prevented image builds from reaching Harbor, so ArgoCD Image Updater had nothing to deploy.

Changes

tests/test_tryouts.py -- Renamed test_requires_auth to test_admin_dashboard_is_public, updated assertion from status_code in (401, 403) to status_code == 200, added docstring clarifying the intentional behavior.

Test Plan

pytest tests/test_tryouts.py -k test_admin_dashboard_is_public -v -- passes
pytest -- all 137 tests pass
ruff check . -- passes
ruff format --check . -- passes

Review Checklist

Only tests/test_tryouts.py modified (no route changes)
No auth re-added to the admin dashboard endpoint
Test name accurately reflects current behavior
Other test_requires_auth tests (assign-numbers, checkin, uncheckin) left unchanged -- those endpoints still require auth

Plan: plan-2026-03-08-tryout-prep (traceability)
Forgejo issue: #66

Closes #66

## Summary The admin dashboard was made intentionally public for tryout day (commit 7b3e455), but `TestAdminDashboard::test_requires_auth` was never updated. It still expected 401/403 but got 200, blocking every CI pipeline since #42 (~40 pipelines). This single stale test prevented image builds from reaching Harbor, so ArgoCD Image Updater had nothing to deploy. ## Changes - `tests/test_tryouts.py` -- Renamed `test_requires_auth` to `test_admin_dashboard_is_public`, updated assertion from `status_code in (401, 403)` to `status_code == 200`, added docstring clarifying the intentional behavior. ## Test Plan - [x] `pytest tests/test_tryouts.py -k test_admin_dashboard_is_public -v` -- passes - [x] `pytest` -- all 137 tests pass - [x] `ruff check .` -- passes - [x] `ruff format --check .` -- passes ## Review Checklist - [x] Only `tests/test_tryouts.py` modified (no route changes) - [x] No auth re-added to the admin dashboard endpoint - [x] Test name accurately reflects current behavior - [x] Other `test_requires_auth` tests (assign-numbers, checkin, uncheckin) left unchanged -- those endpoints still require auth ## Related - Plan: `plan-2026-03-08-tryout-prep` (traceability) - Forgejo issue: #66 Closes #66

forgejo_admin added 1 commit

2026-03-13 19:14:56 +00:00

Fix stale auth test that blocked CI since pipeline #42

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

ef9fb699a6

The admin dashboard was made public for tryout day (7b3e455) but
test_requires_auth still expected 401/403. Renamed to
test_admin_dashboard_is_public and updated assertion to expect 200.

Closes #66

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>