fix: use YAML block scalar for wget command to fix colon parsing #206

Merged

forgejo_admin merged 1 commit from 226-fix-yaml-syntax into main

2026-03-28 16:59:11 +00:00

forgejo_admin commented

2026-03-28 16:57:30 +00:00

Owner

Summary

PR #204 introduced an update-kustomize-tag step with a multi-line wget command containing --header="Authorization: token ...". The unquoted colon was interpreted by YAML as a mapping separator, breaking pipeline parsing entirely.

Changes

.woodpecker.yaml: Wrapped the wget command in a >- folded block scalar so the colon inside the Authorization header stays within a proper string context.

Test Plan

Validated with python3 -c "import yaml; yaml.safe_load(open('.woodpecker.yaml')); print('OK')" -- passes
Woodpecker parses the pipeline config on next push to main
update-kustomize-tag step executes successfully

Review Checklist

Passed automated review-fix loop
No secrets committed
No unnecessary file changes
Commit messages are descriptive

Closes #226
basketball-api -- the project this work belongs to

## Summary PR #204 introduced an `update-kustomize-tag` step with a multi-line wget command containing `--header="Authorization: token ..."`. The unquoted colon was interpreted by YAML as a mapping separator, breaking pipeline parsing entirely. ## Changes - `.woodpecker.yaml`: Wrapped the wget command in a `>-` folded block scalar so the colon inside the Authorization header stays within a proper string context. ## Test Plan - [x] Validated with `python3 -c "import yaml; yaml.safe_load(open('.woodpecker.yaml')); print('OK')"` -- passes - [ ] Woodpecker parses the pipeline config on next push to main - [ ] update-kustomize-tag step executes successfully ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related Notes - Closes #226 - `basketball-api` -- the project this work belongs to

forgejo_admin added 1 commit

2026-03-28 16:57:30 +00:00

fix: use YAML block scalar for wget command to fix colon parsing

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

dca60d2a24

The unquoted colon in --header="Authorization: token ..." was being
interpreted as a YAML mapping separator, breaking pipeline parsing.
Wrapping the command in a >- folded block scalar keeps it as a single
string.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-28 16:58:26 +00:00

Author

Owner

QA Review -- PR #206

Diff Summary

1 file changed: .woodpecker.yaml
4 additions, 3 deletions
Wraps multi-line wget command in >- folded block scalar

Findings

Correctness: Verified the >- block scalar produces the correct single-line command:

wget -O /tmp/update-kustomize-tag.sh --header="Authorization: token ${FORGEJO_TOKEN}" "http://forgejo-http.forgejo.svc.cluster.local:80/forgejo_admin/pal-e-platform/raw/branch/main/scripts/update-kustomize-tag.sh"

All arguments are joined with spaces as expected. No trailing newline (due to - strip indicator).

YAML validity: Confirmed with python3 -c "import yaml; yaml.safe_load(open('.woodpecker.yaml')); print('OK')" -- passes.

Root cause: The previous format had bare indented continuation lines with an unquoted colon in Authorization: token, which YAML parsed as a mapping key rather than a string continuation.

No regressions: Second command (sh /tmp/update-kustomize-tag.sh) unchanged. All other steps untouched.

SOP compliance: PR body has all required sections (Summary, Changes, Test Plan, Review Checklist, Related Notes). Closes #226 present for auto-close.

Nits

None.

VERDICT: APPROVE

## QA Review -- PR #206 ### Diff Summary - 1 file changed: `.woodpecker.yaml` - 4 additions, 3 deletions - Wraps multi-line wget command in `>-` folded block scalar ### Findings **Correctness**: Verified the `>-` block scalar produces the correct single-line command: ``` wget -O /tmp/update-kustomize-tag.sh --header="Authorization: token ${FORGEJO_TOKEN}" "http://forgejo-http.forgejo.svc.cluster.local:80/forgejo_admin/pal-e-platform/raw/branch/main/scripts/update-kustomize-tag.sh" ``` All arguments are joined with spaces as expected. No trailing newline (due to `-` strip indicator). **YAML validity**: Confirmed with `python3 -c "import yaml; yaml.safe_load(open('.woodpecker.yaml')); print('OK')"` -- passes. **Root cause**: The previous format had bare indented continuation lines with an unquoted colon in `Authorization: token`, which YAML parsed as a mapping key rather than a string continuation. **No regressions**: Second command (`sh /tmp/update-kustomize-tag.sh`) unchanged. All other steps untouched. **SOP compliance**: PR body has all required sections (Summary, Changes, Test Plan, Review Checklist, Related Notes). `Closes #226` present for auto-close. ### Nits None. --- **VERDICT: APPROVE**