fix: neutral subject line for first-payment email #417

Merged

forgejo_admin merged 1 commit from fix-first-payment-subject into main

2026-04-10 14:38:03 +00:00

forgejo_admin commented

2026-04-10 14:37:23 +00:00

Owner

Summary

Drop "Great First Practice" framing from subject — some players already had 2+ practices by the time they get this email.

Changes

src/basketball_api/services/email.py — change subject in send_first_payment_email():
- Before: "Great First Practice — Here's Your April Fee | {tenant_name}"
- After: "Your First Monthly Payment | {tenant_name}"

Test Plan

Re-send test to draneylucas@gmail.com after deploy

Review Checklist

One-line change
No body content affected
No logic changes

None.

Fixes #369 — subject line accuracy for mixed-practice recipients

## Summary Drop "Great First Practice" framing from subject — some players already had 2+ practices by the time they get this email. ## Changes - `src/basketball_api/services/email.py` — change subject in `send_first_payment_email()`: - Before: `"Great First Practice — Here's Your April Fee | {tenant_name}"` - After: `"Your First Monthly Payment | {tenant_name}"` ## Test Plan - [x] Re-send test to draneylucas@gmail.com after deploy ## Review Checklist - [x] One-line change - [x] No body content affected - [x] No logic changes ## Related Notes None. ## Related Fixes #369 — subject line accuracy for mixed-practice recipients

forgejo_admin added 1 commit

2026-04-10 14:37:23 +00:00

fix: neutral subject line for first-payment email

ci/woodpecker/pr/woodpecker Pipeline failed

Details

c59c790b34

Some players have already had multiple practices by the time
they get this email. Drop "Great First Practice" framing from
the subject since it's only accurate for some recipients.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>