forgejo_admin/pal-e-api
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

fix: use YAML folded scalar for wget command to fix parse error #236

Merged
forgejo_admin merged 1 commit from 226-fix-yaml-syntax into main 2026-03-28 17:01:41 +00:00
Conversation 1 Commits 1 Files changed 1 +4 -3
forgejo_admin commented 2026-03-28 16:58:16 +00:00
Owner
Copy link

Summary

  • PR #235 broke YAML parsing by splitting the wget command across multiple lines
  • The --header="Authorization: token ..." continuation line contains a colon that YAML interprets as a mapping separator, causing a ScannerError at line 94
  • Wrapped the command in a >- folded block scalar so YAML joins continuation lines into a single string

Changes

  • .woodpecker.yaml: Replaced bare multi-line wget command with >- folded block scalar to avoid colon-as-mapping ambiguity

Test Plan

  • python3 -c "import yaml; yaml.safe_load(open('.woodpecker.yaml')); print('OK')" passes
  • Verified folded scalar produces correct single-line wget command with auth header
  • All 682 tests pass
  • ruff check and ruff format clean

Review Checklist

  • Passed automated review-fix loop
  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive

Related Notes

  • Closes #226
  • pal-e-api -- the project this work belongs to
  • Caused by: PR #235
## Summary - PR #235 broke YAML parsing by splitting the `wget` command across multiple lines - The `--header="Authorization: token ..."` continuation line contains a colon that YAML interprets as a mapping separator, causing a `ScannerError` at line 94 - Wrapped the command in a `>-` folded block scalar so YAML joins continuation lines into a single string ## Changes - `.woodpecker.yaml`: Replaced bare multi-line wget command with `>-` folded block scalar to avoid colon-as-mapping ambiguity ## Test Plan - [x] `python3 -c "import yaml; yaml.safe_load(open('.woodpecker.yaml')); print('OK')"` passes - [x] Verified folded scalar produces correct single-line wget command with auth header - [x] All 682 tests pass - [x] ruff check and ruff format clean ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related Notes - Closes #226 - `pal-e-api` -- the project this work belongs to - Caused by: PR #235
fix: use YAML folded scalar for wget command to fix parse error
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
3b2aca29de 
The previous PR (#235) split the wget command across multiple YAML list
lines, causing the colon in --header="Authorization: token ..." to be
interpreted as a YAML mapping separator. Using >- folded block scalar
joins the continuation lines into a single command string.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-03-28 16:58:57 +00:00
Author
Owner
Copy link

QA Review

Diff Analysis

  • 1 file changed, 4 additions, 3 deletions -- minimal, surgical fix
  • The >- folded block scalar correctly joins continuation lines into a single command string with space separators
  • No trailing newline (the - in >-), which is correct for a shell command

Domain Quality

  • The folded scalar is the idiomatic YAML solution for multi-line shell commands containing colons
  • The resulting command string was verified programmatically: wget -O /tmp/update-kustomize-tag.sh --header="Authorization: token ${FORGEJO_TOKEN}" "http://..."
  • No functional change to the wget behavior -- same flags, same URL, same auth header

SOP Compliance

  • PR body has all required sections (Summary, Changes, Test Plan, Review Checklist, Related Notes)
  • Closes #226 present for auto-close
  • 682 tests pass
  • ruff check and format clean
  • No secrets committed
  • Single-purpose commit with descriptive message

Nits

None.

VERDICT: APPROVE

## QA Review ### Diff Analysis - **1 file changed**, 4 additions, 3 deletions -- minimal, surgical fix - The `>-` folded block scalar correctly joins continuation lines into a single command string with space separators - No trailing newline (the `-` in `>-`), which is correct for a shell command ### Domain Quality - The folded scalar is the idiomatic YAML solution for multi-line shell commands containing colons - The resulting command string was verified programmatically: `wget -O /tmp/update-kustomize-tag.sh --header="Authorization: token ${FORGEJO_TOKEN}" "http://..."` - No functional change to the wget behavior -- same flags, same URL, same auth header ### SOP Compliance - [x] PR body has all required sections (Summary, Changes, Test Plan, Review Checklist, Related Notes) - [x] `Closes #226` present for auto-close - [x] 682 tests pass - [x] ruff check and format clean - [x] No secrets committed - [x] Single-purpose commit with descriptive message ### Nits None. **VERDICT: APPROVE**
forgejo_admin deleted branch 226-fix-yaml-syntax 2026-03-28 17:01:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/pal-e-api!236
No description provided.