Fix Telegram chat_id type and dora-exporter OOM #54
No reviewers
Labels
No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo_admin/pal-e-platform!54
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "53-fix-telegram-chat-id-type-and-dora-expor"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Fixes two production issues: Telegram alerting broken by chat_id being passed as a string instead of integer, and dora-exporter pods getting OOMKilled at 128Mi.
Changes
terraform/main.tf(line 317): Changedtelegram_chat_idset_sensitivetype from"string"to"auto"so Helm passes it as an integer (Telegram API requires numeric chat_id)terraform/main.tf(line 1030): Bumped dora-exporter memory limit from128Mito256Mito prevent OOMKillTest Plan
tofu fmt-- no changes neededtofu validate-- passestofu planshows only the two expected changes, thentofu applyReview Checklist
tofu fmtproduces no difftofu validatepassesCloses #53Related
plan-pal-e-platformCloses #53
Review: LGTM
Diff is exactly 2 lines changed in 1 file, scoped precisely to the issue:
telegram_chat_idtype"string"->"auto"-- Helm will now pass it as an integer, which is what the Telegram API expects.dora-exportermemory limit128Mi->256Mi-- doubles the ceiling to prevent OOMKill.No unrelated changes.
tofu fmtclean,tofu validatepasses. Ready to merge.Tofu Plan Output
PR #54 Review
BLOCKERS
None.
NITS
None.
SOP COMPLIANCE
53-fix-telegram-chat-id-type-and-dora-exporreferences #53)plan-pal-e-platform)Closes #53present in PR bodytofu fmtandtofu validatereported as passingCODE REVIEW
telegram_chat_idtype change (line 317):type = "string"totype = "auto"-- correct. The Telegram API requireschat_idas an integer. Helm providerset_sensitivewithtype = "auto"passes the value as its native type instead of string-coercing it.dora-exportermemory limit (line 1030):128Mito256Mi-- reasonable doubling for OOMKill. Request stays at32Mi, so no over-reservation. The pod gets burst room without claiming excess guaranteed memory.Both changes are minimal, targeted, and match the issue description exactly.
VERDICT: APPROVED