fix: wire all Woodpecker secrets through terraform helm values #85
No reviewers
Labels
No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo_admin/pal-e-platform!85
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "84-fix-wire-all-woodpecker-secrets-through"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Wire all Woodpecker secrets through Terraform helm values so
tofu applynever breaks Woodpecker again. Adds the missingWOODPECKER_ENCRYPTION_KEYserver env var and adds all three Woodpecker secrets (woodpecker_db_password,woodpecker_agent_secret,woodpecker_encryption_key) to the MakefileTF_SECRET_VARSlist somake tofu-secretsrenders them from Salt pillar.Changes
terraform/main.tf— AddWOODPECKER_ENCRYPTION_KEYas aset_sensitiveblock on the Woodpecker server. This prevents JWT/token invalidation on DB migration by providing a persistent encryption key.terraform/variables.tf— Declarewoodpecker_encryption_keyvariable (sensitive string).Makefile— Addwoodpecker_db_password,woodpecker_agent_secret,woodpecker_encryption_keytoTF_SECRET_VARSsomake tofu-secretsrenders them from encrypted Salt pillar intosecrets.auto.tfvars.Note:
WOODPECKER_DATABASE_DATASOURCEalready interpolates${var.woodpecker_db_password}andWOODPECKER_AGENT_SECRETis already wired viaset_sensitiveon both server and agent — those were fixed in a prior commit on this branch.tofu plan Output
Not included — worktree lacks state file and
k3s.tfvars.tofu validatepasses.tofu fmtproduces no changes. Operator should runtofu plan -lock=falseagainst real state before applying.Test Plan
tofu validate— passestofu fmt -recursive— no changesWOODPECKER_ENCRYPTION_KEYappears in helm values withset_sensitiveTF_SECRET_VARSin Makefiletofu plan -lock=falseon the server to confirm only Woodpecker helm release changesReview Checklist
tofu fmtproduces no changestofu validatepassestofu plan -lock=falsereviewed on server (operator step)woodpecker_encryption_keyvalue added tok3s.tfvars(operator step)woodpecker_encryption_key(operator step)Related
plan-pal-e-platform→ Phase 17a (Woodpecker Secrets Hardening)Closes #84
Self-review: LGTM. 3 files changed, 14 additions, 1 deletion. All acceptance criteria verified:
WOODPECKER_ENCRYPTION_KEYadded asset_sensitiveon serverwoodpecker_encryption_keyvariable declared (sensitive string)TF_SECRET_VARStofu validatepasses,tofu fmtcleanOperator steps before apply: add
woodpecker_encryption_keyvalue tok3s.tfvars, update Salt pillar, runtofu plan -lock=falseto verify.Tofu Plan Output