fix: revert base path after dedicated funnel (#7) #9

Merged

forgejo_admin merged 1 commit from 7-revert-base-path into main

2026-03-26 06:55:44 +00:00

forgejo_admin commented

2026-03-26 06:21:44 +00:00

Owner

Summary

Remove base: '/svelte/' from vite.config.js and replace all /svelte/ path prefixes with / across 8 source files. The dedicated Tailscale funnel (pal-e-deployments PR #49) serves content from root, eliminating the need for subpath hacks.

Changes

vite.config.js -- removed base: '/svelte/' (reverts to default /)
index.html -- replaced 3 /svelte/ prefixed links with /
westside/staff.html -- replaced 16 /svelte/ references in nav, links, asset paths
westside/sponsors.html -- replaced 13 /svelte/ references
westside/success.html -- replaced 12 /svelte/ references
westside/index.html -- replaced 5 /svelte/ references in OG/Twitter/favicon meta tags
westside/Nav.svelte -- replaced 7 /svelte/ references in nav links
westside/App.svelte -- replaced 1 /svelte/ reference in FAQ staff link

Test Plan

npm run build succeeds with no errors
grep -r '/svelte/' dist/ returns zero matches
No /svelte/ path references remain in source files
After deploy: https://svelte-playground.tail5b443a.ts.net/ serves hub page
After deploy: https://svelte-playground.tail5b443a.ts.net/westside/ serves westside prototype
All internal links in westside HTML pages resolve correctly

Review Checklist

Passed automated review-fix loop
No secrets committed
No unnecessary file changes
Commit messages are descriptive

Dependency

DO NOT MERGE until pal-e-deployments PR #49 is merged and applied. That PR creates the dedicated Tailscale funnel. Without it, reverting the base path will break all links since the content would still be served under /svelte/ on the shared playground.

Merge order:

Merge and apply pal-e-deployments PR #49 (creates new namespace + removes from shared)
Merge this PR
Rebuild: cd ~/svelte-playground && npm run build
Verify: curl https://svelte-playground.tail5b443a.ts.net/

Closes #7
Depends on: forgejo_admin/pal-e-deployments#49

## Summary Remove `base: '/svelte/'` from vite.config.js and replace all `/svelte/` path prefixes with `/` across 8 source files. The dedicated Tailscale funnel (pal-e-deployments PR #49) serves content from root, eliminating the need for subpath hacks. ## Changes - `vite.config.js` -- removed `base: '/svelte/'` (reverts to default `/`) - `index.html` -- replaced 3 `/svelte/` prefixed links with `/` - `westside/staff.html` -- replaced 16 `/svelte/` references in nav, links, asset paths - `westside/sponsors.html` -- replaced 13 `/svelte/` references - `westside/success.html` -- replaced 12 `/svelte/` references - `westside/index.html` -- replaced 5 `/svelte/` references in OG/Twitter/favicon meta tags - `westside/Nav.svelte` -- replaced 7 `/svelte/` references in nav links - `westside/App.svelte` -- replaced 1 `/svelte/` reference in FAQ staff link ## Test Plan - [x] `npm run build` succeeds with no errors - [x] `grep -r '/svelte/' dist/` returns zero matches - [x] No `/svelte/` path references remain in source files - [ ] After deploy: `https://svelte-playground.tail5b443a.ts.net/` serves hub page - [ ] After deploy: `https://svelte-playground.tail5b443a.ts.net/westside/` serves westside prototype - [ ] All internal links in westside HTML pages resolve correctly ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Dependency **DO NOT MERGE until pal-e-deployments PR #49 is merged and applied.** That PR creates the dedicated Tailscale funnel. Without it, reverting the base path will break all links since the content would still be served under `/svelte/` on the shared playground. Merge order: 1. Merge and apply pal-e-deployments PR #49 (creates new namespace + removes from shared) 2. Merge this PR 3. Rebuild: `cd ~/svelte-playground && npm run build` 4. Verify: `curl https://svelte-playground.tail5b443a.ts.net/` ## Related - Closes #7 - Depends on: forgejo_admin/pal-e-deployments#49

forgejo_admin added 1 commit

2026-03-26 06:21:44 +00:00

fix: revert base path after dedicated funnel (#7 ) 1b504dcef3

Remove base: '/svelte/' from vite.config.js and replace all /svelte/
path prefixes with / across 8 source files. The dedicated Tailscale
funnel serves content from root, eliminating the need for subpath hacks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-26 06:22:38 +00:00

Author

Owner

Review: LGTM

Files reviewed: 8 (8 modified)

Findings: None.

base: '/svelte/' removed from vite.config.js -- Vite defaults to /
All 57 /svelte/ path references replaced with / across 8 files
Replacement is mechanical and correct -- no partial matches or over-replacements
npm run build succeeds cleanly
grep -r '/svelte/' dist/ returns zero matches in build output
No source files contain /svelte/ path references (only package-lock.json npm registry URL, which is correct)
Dependency on pal-e-deployments PR #49 clearly documented in PR body

## Review: LGTM **Files reviewed:** 8 (8 modified) **Findings:** None. - `base: '/svelte/'` removed from vite.config.js -- Vite defaults to `/` - All 57 `/svelte/` path references replaced with `/` across 8 files - Replacement is mechanical and correct -- no partial matches or over-replacements - `npm run build` succeeds cleanly - `grep -r '/svelte/' dist/` returns zero matches in build output - No source files contain `/svelte/` path references (only `package-lock.json` npm registry URL, which is correct) - Dependency on pal-e-deployments PR #49 clearly documented in PR body

forgejo_admin commented

2026-03-26 06:25:00 +00:00

Author

Owner

PR #9 Review

DOMAIN REVIEW

Tech stack: Vite + Svelte 5, static HTML pages, vanilla CSS. This is a playground/prototype repo -- no backend, no auth, no database.

Change summary: Pure find-and-replace of /svelte/ path prefix to / across 8 files (1 config + 7 source files). This reverts the base: '/svelte/' workaround in vite.config.js now that svelte-playground has its own dedicated Tailscale funnel (pal-e-deployments PR #49).

Diff analysis (57 additions, 58 deletions across 8 files):

vite.config.js -- removed base: '/svelte/' line (net -1 line, correct)
index.html -- 3 path replacements in nav brand + project card links
westside/index.html -- 5 replacements in OG/Twitter/favicon meta tags
westside/staff.html -- 16 replacements in meta tags, nav, coach photo src attributes
westside/sponsors.html -- 13 replacements in meta tags, nav, sponsor images
westside/success.html -- 12 replacements in meta tags, nav, back-to-home link
westside/Nav.svelte -- 7 replacements in nav brand logo + nav links
westside/App.svelte -- 1 replacement in FAQ staff link

Completeness check: Verified via grep that zero /svelte/ path references remain in any .html, .svelte, .js, or .css source files after this change. The only match in the entire repo is the npm registry URL in package-lock.json, which is correct and unrelated.

Files NOT touched that could contain references: westside/Footer.svelte and pal-e-app/board.svelte were verified -- neither contains /svelte/ path references. Clean.

Correctness: Every replacement is a mechanical /svelte/foo to /foo substitution. No logic changes, no structural changes, no new code. The transformation is consistent and complete.

BLOCKERS

None.

No new functionality introduced (path prefix removal only) -- test coverage N/A for this change type
No user input handling
No secrets or credentials
No auth/security paths

NITS

DRY observation (pre-existing, not introduced by this PR): The navigation markup is duplicated across staff.html, sponsors.html, and success.html -- identical nav bars copied verbatim. The Svelte Nav.svelte component already exists and handles this for the SPA entry point, but the static HTML pages duplicate it. This is a known trade-off of multi-page playground architecture and not in scope for this fix PR. Noting for future consideration only.
Dependency gate is well-documented: The PR body clearly states "DO NOT MERGE until pal-e-deployments PR #49 is merged and applied" with a numbered merge order. Good practice.

SOP COMPLIANCE

Branch named after issue: 7-revert-base-path references issue #7
PR body follows template: Summary, Changes, Test Plan, Related sections all present
Related references: Closes #7, cross-repo dependency forgejo_admin/pal-e-deployments#49 documented
Related references plan slug: No plan slug referenced. Acceptable -- this is a standalone fix issue, not plan-driven work
No secrets committed
No unnecessary file changes -- all 8 files are directly related to the base path removal
Commit messages are descriptive

PROCESS OBSERVATIONS

Change failure risk: Low. This is a mechanical find-and-replace with a clear verification method (grep -r '/svelte/' dist/). The test plan includes both pre-deploy verification (build + grep) and post-deploy smoke tests.
Deployment frequency: This PR has an explicit deployment dependency (pal-e-deployments PR #49 must land first). The merge order is clearly documented, reducing coordination risk.
Documentation: PR body is thorough -- includes dependency callout, merge order, and verification steps. Well done.

VERDICT: APPROVED

## PR #9 Review ### DOMAIN REVIEW **Tech stack**: Vite + Svelte 5, static HTML pages, vanilla CSS. This is a playground/prototype repo -- no backend, no auth, no database. **Change summary**: Pure find-and-replace of `/svelte/` path prefix to `/` across 8 files (1 config + 7 source files). This reverts the `base: '/svelte/'` workaround in vite.config.js now that svelte-playground has its own dedicated Tailscale funnel (pal-e-deployments PR #49). **Diff analysis (57 additions, 58 deletions across 8 files)**: - `vite.config.js` -- removed `base: '/svelte/'` line (net -1 line, correct) - `index.html` -- 3 path replacements in nav brand + project card links - `westside/index.html` -- 5 replacements in OG/Twitter/favicon meta tags - `westside/staff.html` -- 16 replacements in meta tags, nav, coach photo `src` attributes - `westside/sponsors.html` -- 13 replacements in meta tags, nav, sponsor images - `westside/success.html` -- 12 replacements in meta tags, nav, back-to-home link - `westside/Nav.svelte` -- 7 replacements in nav brand logo + nav links - `westside/App.svelte` -- 1 replacement in FAQ staff link **Completeness check**: Verified via grep that zero `/svelte/` path references remain in any `.html`, `.svelte`, `.js`, or `.css` source files after this change. The only match in the entire repo is the npm registry URL in `package-lock.json`, which is correct and unrelated. **Files NOT touched that could contain references**: `westside/Footer.svelte` and `pal-e-app/board.svelte` were verified -- neither contains `/svelte/` path references. Clean. **Correctness**: Every replacement is a mechanical `/svelte/foo` to `/foo` substitution. No logic changes, no structural changes, no new code. The transformation is consistent and complete. ### BLOCKERS None. - No new functionality introduced (path prefix removal only) -- test coverage N/A for this change type - No user input handling - No secrets or credentials - No auth/security paths ### NITS 1. **DRY observation (pre-existing, not introduced by this PR)**: The navigation markup is duplicated across `staff.html`, `sponsors.html`, and `success.html` -- identical nav bars copied verbatim. The Svelte `Nav.svelte` component already exists and handles this for the SPA entry point, but the static HTML pages duplicate it. This is a known trade-off of multi-page playground architecture and not in scope for this fix PR. Noting for future consideration only. 2. **Dependency gate is well-documented**: The PR body clearly states "DO NOT MERGE until pal-e-deployments PR #49 is merged and applied" with a numbered merge order. Good practice. ### SOP COMPLIANCE - [x] Branch named after issue: `7-revert-base-path` references issue #7 - [x] PR body follows template: Summary, Changes, Test Plan, Related sections all present - [x] Related references: `Closes #7`, cross-repo dependency `forgejo_admin/pal-e-deployments#49` documented - [ ] Related references plan slug: No plan slug referenced. Acceptable -- this is a standalone fix issue, not plan-driven work - [x] No secrets committed - [x] No unnecessary file changes -- all 8 files are directly related to the base path removal - [x] Commit messages are descriptive ### PROCESS OBSERVATIONS - **Change failure risk**: Low. This is a mechanical find-and-replace with a clear verification method (`grep -r '/svelte/' dist/`). The test plan includes both pre-deploy verification (build + grep) and post-deploy smoke tests. - **Deployment frequency**: This PR has an explicit deployment dependency (pal-e-deployments PR #49 must land first). The merge order is clearly documented, reducing coordination risk. - **Documentation**: PR body is thorough -- includes dependency callout, merge order, and verification steps. Well done. ### VERDICT: APPROVED