forgejo_admin/svelte-playground
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

feat: move kanban prototype from pal-e-playground #4

Merged
forgejo_admin merged 1 commit from 2-move-kanban-prototype into main 2026-03-24 17:28:13 +00:00
Conversation 1 Commits 1 Files changed 4 +402 -3
forgejo_admin commented 2026-03-24 17:27:04 +00:00
Owner
Copy link

Summary

Moves the Svelte 5 kanban board prototype from pal-e-playground into svelte-playground where it belongs, since it requires a build step. Hub landing page now links directly to the live prototype.

Changes

  • pal-e-app/index.html -- new entry point adapted from pal-e-playground version, references /shared.css instead of /app.css
  • pal-e-app/board.svelte -- kanban component copied from pal-e-playground (no modifications needed)
  • vite.config.js -- added pal-e-app/index.html as a multi-page rollup entry point
  • index.html -- converted Coming Soon <div> card to a working <a> link pointing to /pal-e-app/, removed Coming Soon badge

Test Plan

  • npm run build compiles without errors, produces dist/pal-e-app/index.html
  • npm run dev serves kanban board at /pal-e-app/
  • Hub page at / contains working link to /pal-e-app/
  • pal-e-app/index.html references /shared.css (not /app.css)
  • Drag-and-drop, filter pills, child drill-down all functional (manual verification)

Review Checklist

  • Passed automated review-fix loop
  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive

Related

## Summary Moves the Svelte 5 kanban board prototype from pal-e-playground into svelte-playground where it belongs, since it requires a build step. Hub landing page now links directly to the live prototype. ## Changes - `pal-e-app/index.html` -- new entry point adapted from pal-e-playground version, references `/shared.css` instead of `/app.css` - `pal-e-app/board.svelte` -- kanban component copied from pal-e-playground (no modifications needed) - `vite.config.js` -- added `pal-e-app/index.html` as a multi-page rollup entry point - `index.html` -- converted Coming Soon `<div>` card to a working `<a>` link pointing to `/pal-e-app/`, removed Coming Soon badge ## Test Plan - [x] `npm run build` compiles without errors, produces `dist/pal-e-app/index.html` - [x] `npm run dev` serves kanban board at `/pal-e-app/` - [x] Hub page at `/` contains working link to `/pal-e-app/` - [x] `pal-e-app/index.html` references `/shared.css` (not `/app.css`) - [ ] Drag-and-drop, filter pills, child drill-down all functional (manual verification) ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related - Closes forgejo_admin/svelte-playground#2 - Cleanup of pal-e-playground source: forgejo_admin/pal-e-playground#9 (separate issue)
Copies board.svelte and creates entry point referencing /shared.css.
Updates vite.config.js with multi-page entry. Hub card now links
to the live prototype instead of showing Coming Soon badge.

Closes forgejo_admin/svelte-playground#2

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-03-24 17:27:46 +00:00
Author
Owner
Copy link

QA Review -- PR #4

Files Reviewed (4 changed, +402/-3)

pal-e-app/index.html -- Clean entry point. References /shared.css (not /app.css). Mounts board.svelte via Svelte 5 mount(). Nav brand links to / (hub root). No issues.

pal-e-app/board.svelte -- Exact copy from pal-e-playground source. No stale app.css references. Uses CSS classes from shared.css. Svelte 5 runes ($state, $derived) used correctly. Drag-and-drop, filters, child expansion all wired. No issues.

vite.config.js -- Adds pal-e-app as multi-page rollup entry point. Correct format. No issues.

index.html (hub) -- Converts <div class="card"> to <a class="card" href="/pal-e-app/">. Removes Coming Soon badge. Semantic improvement (<a> is correct for a navigation card). .card:hover styles apply correctly to the <a> element.

Acceptance Criteria Check

  • Hub card links to /pal-e-app/ with Coming Soon badge removed
  • pal-e-app/index.html references /shared.css instead of /app.css
  • npm run build produces dist/pal-e-app/index.html
  • No cross-repo changes (pal-e-playground untouched)
  • No secrets committed
  • No unnecessary file changes

Nit (non-blocking)

  • The .badge-coming CSS class in the hub index.html <style> block (lines 94-98) is now unused dead CSS since the Coming Soon span was removed. Not a blocker -- can be cleaned up in a future PR if more hub cards are added.

VERDICT: APPROVE

Clean move with all acceptance criteria met. Build verified. No blockers.

## QA Review -- PR #4 ### Files Reviewed (4 changed, +402/-3) **pal-e-app/index.html** -- Clean entry point. References `/shared.css` (not `/app.css`). Mounts `board.svelte` via Svelte 5 `mount()`. Nav brand links to `/` (hub root). No issues. **pal-e-app/board.svelte** -- Exact copy from pal-e-playground source. No stale `app.css` references. Uses CSS classes from `shared.css`. Svelte 5 runes (`$state`, `$derived`) used correctly. Drag-and-drop, filters, child expansion all wired. No issues. **vite.config.js** -- Adds `pal-e-app` as multi-page rollup entry point. Correct format. No issues. **index.html** (hub) -- Converts `<div class="card">` to `<a class="card" href="/pal-e-app/">`. Removes Coming Soon badge. Semantic improvement (`<a>` is correct for a navigation card). `.card:hover` styles apply correctly to the `<a>` element. ### Acceptance Criteria Check - [x] Hub card links to `/pal-e-app/` with Coming Soon badge removed - [x] `pal-e-app/index.html` references `/shared.css` instead of `/app.css` - [x] `npm run build` produces `dist/pal-e-app/index.html` - [x] No cross-repo changes (pal-e-playground untouched) - [x] No secrets committed - [x] No unnecessary file changes ### Nit (non-blocking) - The `.badge-coming` CSS class in the hub `index.html` `<style>` block (lines 94-98) is now unused dead CSS since the Coming Soon span was removed. Not a blocker -- can be cleaned up in a future PR if more hub cards are added. ### VERDICT: APPROVE Clean move with all acceptance criteria met. Build verified. No blockers.
forgejo_admin deleted branch 2-move-kanban-prototype 2026-03-24 17:28:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/svelte-playground!4
No description provided.