fix: add transparent favicon and apple-touch-icon (#103)

forgejo_admin commented

2026-03-27 05:46:35 +00:00

Owner

Summary

Adds background-removed logo as favicon (32x32 transparent PNG from MinIO branding assets)
Adds apple-touch-icon (180x180 transparent PNG) for iOS home screen
Fixes the 404 console error on every page load

Changes

static/favicon.png — 32x32 transparent logo from MinIO assets/westside/branding/favicon-32x32-transparent.png
static/apple-touch-icon.png — 180x180 transparent logo from MinIO assets/westside/branding/apple-touch-icon-transparent.png
src/app.html — add apple-touch-icon link tag

Test Plan

Favicon displays in browser tab (no 404 in console)
Apple-touch-icon renders when bookmarking to iOS home screen
No regression on existing pages

Review Checklist

No secrets committed
No unnecessary file changes
Assets sourced from MinIO branding (canonical source)

Closes #103
project-westside-basketball

## Summary - Adds background-removed logo as favicon (32x32 transparent PNG from MinIO branding assets) - Adds apple-touch-icon (180x180 transparent PNG) for iOS home screen - Fixes the 404 console error on every page load ## Changes - `static/favicon.png` — 32x32 transparent logo from MinIO `assets/westside/branding/favicon-32x32-transparent.png` - `static/apple-touch-icon.png` — 180x180 transparent logo from MinIO `assets/westside/branding/apple-touch-icon-transparent.png` - `src/app.html` — add apple-touch-icon link tag ## Test Plan - [ ] Favicon displays in browser tab (no 404 in console) - [ ] Apple-touch-icon renders when bookmarking to iOS home screen - [ ] No regression on existing pages ## Review Checklist - [x] No secrets committed - [x] No unnecessary file changes - [x] Assets sourced from MinIO branding (canonical source) ## Related Notes - Closes #103 - `project-westside-basketball`

forgejo_admin added 1 commit

2026-03-27 05:46:35 +00:00

fix: add transparent favicon and apple-touch-icon from MinIO branding

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

c093ca87a2

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-27 05:47:46 +00:00

Author

Owner

PR #104 Review

DOMAIN REVIEW

Stack: SvelteKit (adapter-static) / HTML

The diff is clean and correct:

src/app.html -- Replaced a bare <link rel="icon"> with a properly attributed <link rel="icon" type="image/png" sizes="32x32">. Added <link rel="apple-touch-icon" sizes="180x180">. Both follow standard HTML5 favicon best practices.
static/favicon.png -- 32x32 transparent PNG added to the canonical SvelteKit static asset directory. Sourced from MinIO branding assets per the PR description.
static/apple-touch-icon.png -- 180x180 transparent PNG. Correct size for iOS home screen icons.

The %sveltekit.assets% prefix is the correct SvelteKit pattern for referencing static assets in app.html. No issues with asset paths.

CI pipeline (npm run check, npm run build, test -f build/index.html) will validate the build still succeeds with these changes.

BLOCKERS

None.

Test coverage note: This PR adds two static image files and one HTML link tag. The repo has no test infrastructure. Requiring unit tests for a favicon/apple-touch-icon addition is not reasonable -- the CI build validation step and the manual Test Plan items in the PR body are sufficient for this scope.

NITS

Branch naming: Branch is fix-favicon rather than 103-fix-favicon or 103/fix-favicon. Convention is to name branches after the issue number for traceability. Minor.
Consider adding a favicon.ico fallback: Some older browsers and tools (bookmarklets, RSS readers) look for favicon.ico at the root. Not critical for this audience, but worth noting for completeness.

SOP COMPLIANCE

Branch named after issue -- branch is fix-favicon, not 103-*
PR body follows template (Summary, Changes, Test Plan, Related)
Related references project slug (project-westside-basketball)
No secrets committed
No unnecessary file changes (3 files, all directly related)
Commit message references issue number

PROCESS OBSERVATIONS

Low-risk change: 2 static assets + 1 HTML line. Change failure risk is near zero.
Deployment frequency: This is a quick bug fix that unblocks a cleaner user experience (no 404 console noise). Good candidate for fast merge.
The PR correctly identifies the canonical asset source (MinIO branding), which supports asset traceability.

VERDICT: APPROVED

## PR #104 Review ### DOMAIN REVIEW **Stack: SvelteKit (adapter-static) / HTML** The diff is clean and correct: 1. `src/app.html` -- Replaced a bare `<link rel="icon">` with a properly attributed `<link rel="icon" type="image/png" sizes="32x32">`. Added `<link rel="apple-touch-icon" sizes="180x180">`. Both follow standard HTML5 favicon best practices. 2. `static/favicon.png` -- 32x32 transparent PNG added to the canonical SvelteKit static asset directory. Sourced from MinIO branding assets per the PR description. 3. `static/apple-touch-icon.png` -- 180x180 transparent PNG. Correct size for iOS home screen icons. The `%sveltekit.assets%` prefix is the correct SvelteKit pattern for referencing static assets in `app.html`. No issues with asset paths. CI pipeline (`npm run check`, `npm run build`, `test -f build/index.html`) will validate the build still succeeds with these changes. ### BLOCKERS None. **Test coverage note:** This PR adds two static image files and one HTML link tag. The repo has no test infrastructure. Requiring unit tests for a favicon/apple-touch-icon addition is not reasonable -- the CI build validation step and the manual Test Plan items in the PR body are sufficient for this scope. ### NITS 1. **Branch naming:** Branch is `fix-favicon` rather than `103-fix-favicon` or `103/fix-favicon`. Convention is to name branches after the issue number for traceability. Minor. 2. **Consider adding a `favicon.ico` fallback:** Some older browsers and tools (bookmarklets, RSS readers) look for `favicon.ico` at the root. Not critical for this audience, but worth noting for completeness. ### SOP COMPLIANCE - [ ] Branch named after issue -- branch is `fix-favicon`, not `103-*` - [x] PR body follows template (Summary, Changes, Test Plan, Related) - [x] Related references project slug (`project-westside-basketball`) - [x] No secrets committed - [x] No unnecessary file changes (3 files, all directly related) - [x] Commit message references issue number ### PROCESS OBSERVATIONS - Low-risk change: 2 static assets + 1 HTML line. Change failure risk is near zero. - Deployment frequency: This is a quick bug fix that unblocks a cleaner user experience (no 404 console noise). Good candidate for fast merge. - The PR correctly identifies the canonical asset source (MinIO branding), which supports asset traceability. ### VERDICT: APPROVED