forgejo_admin/westside-contracts
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

Fix: split payment text — wrong amounts, wrong dates, wrong framing #15

New issue
Closed
opened 2026-03-24 20:34:59 +00:00 by forgejo_admin · 1 comment
forgejo_admin commented 2026-03-24 20:34:59 +00:00
Owner
Copy link

Type

Bug

Lineage

plan-wkq → Phase 14 (Billing Tiers & Contracts) — discovered during E2E validation with Marcus

Repo

forgejo_admin/westside-contracts

What Broke

Lines 319 and 377 of +page.svelte both say:

Split payments available: $100 on the 15th, $100 on the 30th.

Three problems:

  1. Hardcoded "$100" — wrong for players with non-$200 fees ($80, $100, $150, $180)
  2. "15th and 30th" — should be 1st and 15th
  3. Framing — presented as a default option, should be "reach out to us" opt-in

Repro Steps

  1. Open any contract page for a non-$200 player
  2. Scroll to Payment Schedule section
  3. See "$100 on the 15th, $100 on the 30th" — wrong amount, wrong dates

Expected Behavior

Text should read something like:
"Payment links will be sent as each deadline approaches. If you'd like to split your monthly fee into two payments (1st and 15th), reach out to us and we'll set that up."

No hardcoded dollar amounts — the monthly fee is already shown above in the "Monthly Fees" section.

Environment

  • Cluster/namespace: prod / westside-contracts
  • Service version/commit: d1a6cbe (current main)

Acceptance Criteria

  • Split payment text updated on both travel (line 319) and local (line 377) variants
  • No hardcoded dollar amounts in the split payment text
  • Dates changed from 15th/30th to 1st/15th
  • Framed as opt-in ("reach out to us") not default
  • Build passes, tests pass

Related

  • project-westside-basketball
### Type Bug ### Lineage `plan-wkq` → Phase 14 (Billing Tiers & Contracts) — discovered during E2E validation with Marcus ### Repo `forgejo_admin/westside-contracts` ### What Broke Lines 319 and 377 of `+page.svelte` both say: ``` Split payments available: $100 on the 15th, $100 on the 30th. ``` Three problems: 1. **Hardcoded "$100"** — wrong for players with non-$200 fees ($80, $100, $150, $180) 2. **"15th and 30th"** — should be **1st and 15th** 3. **Framing** — presented as a default option, should be "reach out to us" opt-in ### Repro Steps 1. Open any contract page for a non-$200 player 2. Scroll to Payment Schedule section 3. See "$100 on the 15th, $100 on the 30th" — wrong amount, wrong dates ### Expected Behavior Text should read something like: "Payment links will be sent as each deadline approaches. If you'd like to split your monthly fee into two payments (1st and 15th), reach out to us and we'll set that up." No hardcoded dollar amounts — the monthly fee is already shown above in the "Monthly Fees" section. ### Environment - Cluster/namespace: prod / westside-contracts - Service version/commit: `d1a6cbe` (current main) ### Acceptance Criteria - [ ] Split payment text updated on both travel (line 319) and local (line 377) variants - [ ] No hardcoded dollar amounts in the split payment text - [ ] Dates changed from 15th/30th to 1st/15th - [ ] Framed as opt-in ("reach out to us") not default - [ ] Build passes, tests pass ### Related - `project-westside-basketball`
forgejo_admin commented 2026-03-24 20:39:14 +00:00
Author
Owner
Copy link

Scope Review: READY

Review note: review-wc-15-2026-03-24
Scope is solid. All file targets verified (lines 319 and 377 in src/routes/contract/[token]/+page.svelte). Fix already implemented in PR #16 (commit bbd13e3). No blast radius in sibling services. Two minor template gaps (incomplete file path, missing Test Expectations) are immaterial for a 2-line text change.

## Scope Review: READY Review note: `review-wc-15-2026-03-24` Scope is solid. All file targets verified (lines 319 and 377 in `src/routes/contract/[token]/+page.svelte`). Fix already implemented in PR #16 (commit bbd13e3). No blast radius in sibling services. Two minor template gaps (incomplete file path, missing Test Expectations) are immaterial for a 2-line text change.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
29-add-age-based-team-reassignment-clause-t
23-fix-kaniko-push-permission-check-timeout
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/westside-contracts#15
No description provided.