forgejo_admin/westside-contracts
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

fix: remove hardcoded split payment amounts #16

Merged
forgejo_admin merged 1 commit from 15-fix-split-payment-text into main 2026-03-24 20:43:05 +00:00
Conversation 2 Commits 1 Files changed 1 +2 -2
forgejo_admin commented 2026-03-24 20:36:41 +00:00
Owner
Copy link

Summary

  • Replaces hardcoded split payment text ($100 on the 15th, $100 on the 30th) with generic opt-in language on both travel and local contract types
  • No dollar amounts, dates changed to 1st/15th, framed as opt-in reach-out

Changes

  • src/routes/contract/[token]/+page.svelte: Updated split payment description on line 319 (travel contract) and line 377 (local contract)

Test Plan

  • Tests pass locally (12/12)
  • npm run build passes clean
  • Manual verification: both travel and local contract sections use new text
  • No regressions — only two lines changed, no logic affected

Review Checklist

  • Passed automated review-fix loop
  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive

Related

## Summary - Replaces hardcoded split payment text ($100 on the 15th, $100 on the 30th) with generic opt-in language on both travel and local contract types - No dollar amounts, dates changed to 1st/15th, framed as opt-in reach-out ## Changes - `src/routes/contract/[token]/+page.svelte`: Updated split payment description on line 319 (travel contract) and line 377 (local contract) ## Test Plan - [x] Tests pass locally (12/12) - [x] `npm run build` passes clean - [x] Manual verification: both travel and local contract sections use new text - [x] No regressions — only two lines changed, no logic affected ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related - Closes #15
Replace specific dollar amounts and dates (15th/30th) with generic
opt-in language (1st/15th) for both travel and local contract types.

Closes #15

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-03-24 20:37:00 +00:00
Author
Owner
Copy link

Review: Approved

Diff: 1 file, +2/-2. Exactly the two lines specified in #15, no extraneous changes.

Verification:

  • npm run build -- clean
  • npm test -- 12/12 pass
  • No secrets, no logic changes, no regressions

No findings. Ready to merge.

## Review: Approved **Diff:** 1 file, +2/-2. Exactly the two lines specified in #15, no extraneous changes. **Verification:** - `npm run build` -- clean - `npm test` -- 12/12 pass - No secrets, no logic changes, no regressions No findings. Ready to merge.
forgejo_admin commented 2026-03-24 20:40:36 +00:00
Author
Owner
Copy link

PR #16 Review

DOMAIN REVIEW

Stack: SvelteKit / Svelte template (HTML content change only)

This is a pure content/copy fix -- two lines of static text inside a .svelte template. No logic, no bindings, no reactive statements, no CSS, and no server-side code changed.

Content correctness:

  • Old text hardcoded "$100 on the 15th, $100 on the 30th" -- assumes a fixed fee amount and specific dates. The fix correctly removes the dollar amount (monthly fees vary by contract type) and changes dates from 15th/30th to 1st/15th.
  • New text reframes split payments as opt-in ("reach out to us") rather than automatic. This is a deliberate business decision, not a bug.
  • Both contract types (travel at line 319, local at line 377) receive identical replacement text, which is correct -- the split payment offer should be consistent across contract types.
  • Verified no stale references remain: grep for "on the 15th" and "on the 30th" returns zero hits. The remaining $100 at line 209 is an unrelated gas cost in a trip breakdown table.

Accessibility: No accessibility impact -- plain paragraph text, no new interactive elements, no ARIA concerns.

Performance: No bundle impact -- static text change only.

BLOCKERS

None.

This is a two-line static text change. No new functionality is introduced, so the "new functionality must have tests" blocker does not apply. No user input handling, no secrets, no auth paths, no logic changes.

NITS

  1. Apostrophe encoding: The text uses a literal curly apostrophe in "you'd" and "we'll". This renders correctly in browsers but some linters or build tools can flag non-ASCII in source. Not a real problem here -- SvelteKit handles UTF-8 fine -- but worth noting for awareness.

  2. Hardcoded dates still present elsewhere: The payment schedule sections still contain hardcoded dates ("March 27", "April 6", "May 1", "June 18"). These are intentionally specific per the contract terms, but if the business changes dates frequently, extracting them to a config or data layer would reduce future one-off text fixes. This is out of scope for this PR.

SOP COMPLIANCE

  • Branch named after issue: 15-fix-split-payment-text references issue #15
  • PR body follows template: Summary, Changes, Test Plan, Related all present
  • Related references parent issue: "Closes #15"
  • Related references plan slug: No plan slug referenced (this is a standalone bug fix, so a plan slug is not expected)
  • No secrets committed: Confirmed -- diff is two lines of static HTML text
  • No unnecessary file changes: Single file changed, exactly the two lines described
  • Commit messages are descriptive: PR title "fix: remove hardcoded split payment amounts" follows conventional commit format
  • Tests exist and pass: 12/12 tests pass per PR body. No new tests needed -- no logic changed.

PROCESS OBSERVATIONS

  • Change failure risk: Minimal. Static text change with no logic impact. The existing 12 tests all pass.
  • Deployment frequency: Clean, small, focused fix. Good example of a low-risk incremental change.
  • Scope discipline: Excellent -- exactly two lines changed, exactly what the issue describes. No scope creep.

VERDICT: APPROVED

## PR #16 Review ### DOMAIN REVIEW **Stack**: SvelteKit / Svelte template (HTML content change only) This is a pure content/copy fix -- two lines of static text inside a `.svelte` template. No logic, no bindings, no reactive statements, no CSS, and no server-side code changed. **Content correctness:** - Old text hardcoded "$100 on the 15th, $100 on the 30th" -- assumes a fixed fee amount and specific dates. The fix correctly removes the dollar amount (monthly fees vary by contract type) and changes dates from 15th/30th to 1st/15th. - New text reframes split payments as opt-in ("reach out to us") rather than automatic. This is a deliberate business decision, not a bug. - Both contract types (travel at line 319, local at line 377) receive identical replacement text, which is correct -- the split payment offer should be consistent across contract types. - Verified no stale references remain: `grep` for "on the 15th" and "on the 30th" returns zero hits. The remaining `$100` at line 209 is an unrelated gas cost in a trip breakdown table. **Accessibility**: No accessibility impact -- plain paragraph text, no new interactive elements, no ARIA concerns. **Performance**: No bundle impact -- static text change only. ### BLOCKERS None. This is a two-line static text change. No new functionality is introduced, so the "new functionality must have tests" blocker does not apply. No user input handling, no secrets, no auth paths, no logic changes. ### NITS 1. **Apostrophe encoding**: The text uses a literal curly apostrophe in "you'd" and "we'll". This renders correctly in browsers but some linters or build tools can flag non-ASCII in source. Not a real problem here -- SvelteKit handles UTF-8 fine -- but worth noting for awareness. 2. **Hardcoded dates still present elsewhere**: The payment schedule sections still contain hardcoded dates ("March 27", "April 6", "May 1", "June 18"). These are intentionally specific per the contract terms, but if the business changes dates frequently, extracting them to a config or data layer would reduce future one-off text fixes. This is out of scope for this PR. ### SOP COMPLIANCE - [x] Branch named after issue: `15-fix-split-payment-text` references issue #15 - [x] PR body follows template: Summary, Changes, Test Plan, Related all present - [x] Related references parent issue: "Closes #15" - [ ] Related references plan slug: No plan slug referenced (this is a standalone bug fix, so a plan slug is not expected) - [x] No secrets committed: Confirmed -- diff is two lines of static HTML text - [x] No unnecessary file changes: Single file changed, exactly the two lines described - [x] Commit messages are descriptive: PR title "fix: remove hardcoded split payment amounts" follows conventional commit format - [x] Tests exist and pass: 12/12 tests pass per PR body. No new tests needed -- no logic changed. ### PROCESS OBSERVATIONS - **Change failure risk**: Minimal. Static text change with no logic impact. The existing 12 tests all pass. - **Deployment frequency**: Clean, small, focused fix. Good example of a low-risk incremental change. - **Scope discipline**: Excellent -- exactly two lines changed, exactly what the issue describes. No scope creep. ### VERDICT: APPROVED
forgejo_admin deleted branch 15-fix-split-payment-text 2026-03-24 20:43:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/westside-contracts!16
No description provided.