forgejo_admin/westside-landing
1
0
Fork 1
Code Issues 17 Pull requests 2 Projects Releases Packages Wiki Activity Actions

feat: change landing hero CTA to registration #146

Merged
forgejo_admin merged 1 commit from 144-landing-hero-cta-registration into main 2026-03-28 19:10:17 +00:00
Conversation 1 Commits 1 Files changed 1 +2 -1
forgejo_admin commented 2026-03-28 18:55:02 +00:00
Owner
Copy link

Summary

  • Replace hero CTA from "Learn About Our Program" -> /about to "Register Your Player" -> /register
  • Keep "Learn More" as secondary btn-secondary link to /about for visitors wanting info first
  • /register is confirmed safe for unauthenticated users (in PUBLIC_APP_ROUTES)

Changes

  • src/routes/(public)/+page.svelte: changed hero-cta div from single informational button to primary registration CTA + secondary learn more link

Test Plan

  • Hero button says "Register Your Player" and links to /register
  • Secondary "Learn More" link goes to /about
  • Mobile rendering looks correct (hero-cta is flex-column with gap)
  • No layout/styling regressions
  • Bottom CTA section unchanged

Review Checklist

  • Passed automated review-fix loop
  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive

Related Notes

  • forgejo_admin/westside-app #144 -- the Forgejo issue this PR implements
  • westside-app -- the project this work belongs to

Closes #144

## Summary - Replace hero CTA from "Learn About Our Program" -> /about to "Register Your Player" -> /register - Keep "Learn More" as secondary btn-secondary link to /about for visitors wanting info first - /register is confirmed safe for unauthenticated users (in PUBLIC_APP_ROUTES) ## Changes - `src/routes/(public)/+page.svelte`: changed hero-cta div from single informational button to primary registration CTA + secondary learn more link ## Test Plan - [ ] Hero button says "Register Your Player" and links to /register - [ ] Secondary "Learn More" link goes to /about - [ ] Mobile rendering looks correct (hero-cta is flex-column with gap) - [ ] No layout/styling regressions - [ ] Bottom CTA section unchanged ## Review Checklist - [ ] Passed automated review-fix loop - [ ] No secrets committed - [ ] No unnecessary file changes - [ ] Commit messages are descriptive ## Related Notes - `forgejo_admin/westside-app #144` -- the Forgejo issue this PR implements - `westside-app` -- the project this work belongs to Closes #144
feat: change landing hero CTA from informational to registration
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
7c4c6c2e41 
Replace "Learn About Our Program" → /about with "Register Your Player" → /register
as the primary call-to-action. Keeps "Learn More" as secondary link to /about.

Closes #144

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-03-28 19:06:15 +00:00
Author
Owner
Copy link

PR #146 Review

DOMAIN REVIEW

Stack: SvelteKit / CSS (static markup change)

This is a minimal, well-scoped change: 1 file, +2/-1 lines. The hero CTA in src/routes/(public)/+page.svelte was changed from a single informational link ("Learn About Our Program" -> /about) to a primary registration CTA ("Register Your Player" -> /register) with a secondary "Learn More" link to /about.

Verified:

  • /register is in PUBLIC_APP_ROUTES (src/routes/(app)/+layout.svelte:26) -- safe for unauthenticated visitors
  • btn-secondary is defined in src/app.css:224 with proper background, color, and hover state
  • .hero-cta uses flex-direction: column; gap: 0.5rem; max-width: 320px -- handles two stacked buttons cleanly
  • Bottom CTA section (lines 100-107, "Ready to Compete?") is completely untouched
  • No other files modified
  • Both link targets (/register, /about) are valid existing routes

Accessibility: Both links use semantic <a> elements with descriptive text. The primary/secondary visual hierarchy (btn-primary vs btn-secondary) provides clear affordance for the conversion funnel.

BLOCKERS

None.

This is a static markup change with no new functionality, no user input handling, no dynamic behavior, and no security surface. The BLOCKER criteria (tests, input validation, secrets, DRY) do not apply.

NITS

None. The change is clean and minimal.

SOP COMPLIANCE

  • Branch named after issue (144-landing-hero-cta-registration follows {issue}-{kebab-case})
  • PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related)
  • Related references issue #144, Closes #144 present
  • No secrets committed
  • No unnecessary file changes (1 file, 3 lines -- surgically scoped)
  • Commit messages are descriptive

PROCESS OBSERVATIONS

Clean single-purpose PR. Low change failure risk -- static markup only, no logic changes. Good conversion funnel improvement (informational CTA -> lead generation CTA) while preserving the informational path as secondary.

VERDICT: APPROVED

## PR #146 Review ### DOMAIN REVIEW **Stack**: SvelteKit / CSS (static markup change) This is a minimal, well-scoped change: 1 file, +2/-1 lines. The hero CTA in `src/routes/(public)/+page.svelte` was changed from a single informational link ("Learn About Our Program" -> /about) to a primary registration CTA ("Register Your Player" -> /register) with a secondary "Learn More" link to /about. **Verified:** - `/register` is in `PUBLIC_APP_ROUTES` (`src/routes/(app)/+layout.svelte:26`) -- safe for unauthenticated visitors - `btn-secondary` is defined in `src/app.css:224` with proper background, color, and hover state - `.hero-cta` uses `flex-direction: column; gap: 0.5rem; max-width: 320px` -- handles two stacked buttons cleanly - Bottom CTA section (lines 100-107, "Ready to Compete?") is completely untouched - No other files modified - Both link targets (`/register`, `/about`) are valid existing routes **Accessibility**: Both links use semantic `<a>` elements with descriptive text. The primary/secondary visual hierarchy (btn-primary vs btn-secondary) provides clear affordance for the conversion funnel. ### BLOCKERS None. This is a static markup change with no new functionality, no user input handling, no dynamic behavior, and no security surface. The BLOCKER criteria (tests, input validation, secrets, DRY) do not apply. ### NITS None. The change is clean and minimal. ### SOP COMPLIANCE - [x] Branch named after issue (`144-landing-hero-cta-registration` follows `{issue}-{kebab-case}`) - [x] PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related) - [x] Related references issue #144, `Closes #144` present - [x] No secrets committed - [x] No unnecessary file changes (1 file, 3 lines -- surgically scoped) - [x] Commit messages are descriptive ### PROCESS OBSERVATIONS Clean single-purpose PR. Low change failure risk -- static markup only, no logic changes. Good conversion funnel improvement (informational CTA -> lead generation CTA) while preserving the informational path as secondary. ### VERDICT: APPROVED
forgejo_admin deleted branch 144-landing-hero-cta-registration 2026-03-28 19:10:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend
No labels
domain:backend
domain:devops
domain:frontend
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/westside-landing!146
No description provided.