feat: add Coach Manny photo to staff page (#110)

forgejo_admin commented

2026-03-27 06:53:21 +00:00

Owner

Summary

Replace the "Photo coming soon" placeholder for Coach Manny with his actual photo served from MinIO

Changes

src/routes/(public)/staff/+page.svelte: swapped placeholder <div> for <img> tag pointing to minio-api.tail5b443a.ts.net/assets/westside/coaches/manny-800w.jpg

Test Plan

Tests pass locally
Visit /staff page and confirm Coach Manny's photo renders correctly
No other coach entries changed
No CSS changes

Review Checklist

Passed automated review-fix loop
No secrets committed
No unnecessary file changes
Commit messages are descriptive

forgejo_admin/westside-app #110 -- the Forgejo issue this PR implements
westside-app -- the project this work belongs to

Closes #110

## Summary - Replace the "Photo coming soon" placeholder for Coach Manny with his actual photo served from MinIO ## Changes - `src/routes/(public)/staff/+page.svelte`: swapped placeholder `<div>` for `<img>` tag pointing to `minio-api.tail5b443a.ts.net/assets/westside/coaches/manny-800w.jpg` ## Test Plan - [ ] Tests pass locally - [ ] Visit `/staff` page and confirm Coach Manny's photo renders correctly - [ ] No other coach entries changed - [ ] No CSS changes ## Review Checklist - [ ] Passed automated review-fix loop - [ ] No secrets committed - [ ] No unnecessary file changes - [ ] Commit messages are descriptive ## Related Notes - `forgejo_admin/westside-app #110` -- the Forgejo issue this PR implements - `westside-app` -- the project this work belongs to Closes #110

forgejo_admin added 2 commits

2026-03-27 06:53:21 +00:00

feat: add post-build step to auto-update kustomize image tag 41244f3bbf

After build-and-push succeeds, the new update-tag step clones
pal-e-deployments, updates the newTag in the westsidekingsandqueens
kustomization overlay to the commit SHA, and pushes. This closes
the gap where image tags required manual PRs to deploy.

Requires a ci_forgejo_token Woodpecker secret with push access
to pal-e-deployments.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: add Coach Manny photo to staff page e6b2e7d560

Replace placeholder text with actual photo served from MinIO.

Closes #110

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin force-pushed 110-add-manny-photo from e6b2e7d560 to ec908d939e

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

2026-03-27 06:54:14 +00:00

Compare

forgejo_admin commented

2026-03-27 06:54:30 +00:00

Author

Owner

QA Review

Diff: 1 file changed, 1 insertion, 1 deletion. Exactly scoped.

Correctness:

Placeholder <div class="coach-photo-placeholder">Photo coming soon</div> replaced with <img> tag
Image URL points to MinIO asset path (minio-api.tail5b443a.ts.net/assets/westside/coaches/manny-800w.jpg)
Alt text is descriptive and matches coach role: Coach Manny, 17U Girls Elite Coach
Explicit width="400" height="528" prevents layout shift (CLS)

Scope check:

No other coach entries modified
No CSS changes
No coach reordering
No unrelated file changes (woodpecker yaml issue from earlier force-push is resolved)

SOP compliance:

PR body has all required sections (Summary, Changes, Test Plan, Review Checklist, Related Notes)
Closes #110 reference present
Commit message is descriptive

Nits: None.

VERDICT: APPROVED

## QA Review **Diff**: 1 file changed, 1 insertion, 1 deletion. Exactly scoped. **Correctness**: - Placeholder `<div class="coach-photo-placeholder">Photo coming soon</div>` replaced with `<img>` tag - Image URL points to MinIO asset path (`minio-api.tail5b443a.ts.net/assets/westside/coaches/manny-800w.jpg`) - Alt text is descriptive and matches coach role: `Coach Manny, 17U Girls Elite Coach` - Explicit `width="400" height="528"` prevents layout shift (CLS) **Scope check**: - No other coach entries modified - No CSS changes - No coach reordering - No unrelated file changes (woodpecker yaml issue from earlier force-push is resolved) **SOP compliance**: - PR body has all required sections (Summary, Changes, Test Plan, Review Checklist, Related Notes) - `Closes #110` reference present - Commit message is descriptive **Nits**: None. --- **VERDICT: APPROVED**

forgejo_admin commented

2026-03-27 06:55:49 +00:00

Author

Owner

PR #112 Review

DOMAIN REVIEW

Tech stack: SvelteKit (adapter-static), pure HTML/CSS, MinIO-hosted assets.

Change scope: Single-line content swap in src/routes/(public)/staff/+page.svelte -- replaces a <div class="coach-photo-placeholder">Photo coming soon</div> with an <img> tag for Coach Manny's photo.

Consistency check (PASS):

The <img> tag follows the identical pattern used by all 5 other coach entries on the staff page: same MinIO base URL (minio-api.tail5b443a.ts.net), same asset path (/assets/westside/coaches/), same naming convention (manny-800w.jpg matching james-taylor-800w.jpg, kj-ng-800w.jpg, etc.), explicit width/height attributes, and descriptive alt text including name and role.
The hardcoded MinIO URL is the established pattern across 20+ occurrences in this codebase. Not a new pattern.

Accessibility check (PASS):

alt="Coach Manny, 17U Girls Elite Coach" -- descriptive, includes name and role. Consistent with other coach alt text patterns.
Explicit width="400" height="528" prevents layout shift (CLS).

Test coverage: No tests exist in this repo (adapter-static landing site). This is a pure content change (placeholder to image), not new functionality. No blocker triggered.

BLOCKERS

None.

NITS

loading="lazy" missing: Coach Manny is the 5th coach card, likely below the fold on most viewports. The gear page uses loading="lazy" on its images. However, no coach images on this page use it either, so adding it here alone would be inconsistent. Consider a follow-up to add loading="lazy" to all below-fold coach photos (cards 3-6) for LCP improvement.
PR body Related section: The Related section references forgejo_admin/westside-app #110 and westside-app but does not reference a plan slug. This appears to be a standalone content task without a parent plan, so this is acceptable, but noting for completeness.

SOP COMPLIANCE

Branch named after issue (110-add-manny-photo references #110)
PR body has Summary, Changes, Test Plan, Related
Closes #110 links PR to parent issue
No secrets committed
No unnecessary file changes (1 file, 1 line changed)
Commit message is descriptive
Related section does not reference a plan slug (acceptable -- standalone content task)

PROCESS OBSERVATIONS

Minimal-risk content change. Single line, follows established patterns exactly, no logic or functionality changes. Low change failure risk. No deployment frequency impact beyond a standard content update.

VERDICT: APPROVED

## PR #112 Review ### DOMAIN REVIEW **Tech stack**: SvelteKit (adapter-static), pure HTML/CSS, MinIO-hosted assets. **Change scope**: Single-line content swap in `src/routes/(public)/staff/+page.svelte` -- replaces a `<div class="coach-photo-placeholder">Photo coming soon</div>` with an `<img>` tag for Coach Manny's photo. **Consistency check (PASS)**: - The `<img>` tag follows the identical pattern used by all 5 other coach entries on the staff page: same MinIO base URL (`minio-api.tail5b443a.ts.net`), same asset path (`/assets/westside/coaches/`), same naming convention (`manny-800w.jpg` matching `james-taylor-800w.jpg`, `kj-ng-800w.jpg`, etc.), explicit `width`/`height` attributes, and descriptive `alt` text including name and role. - The hardcoded MinIO URL is the established pattern across 20+ occurrences in this codebase. Not a new pattern. **Accessibility check (PASS)**: - `alt="Coach Manny, 17U Girls Elite Coach"` -- descriptive, includes name and role. Consistent with other coach alt text patterns. - Explicit `width="400" height="528"` prevents layout shift (CLS). **Test coverage**: No tests exist in this repo (adapter-static landing site). This is a pure content change (placeholder to image), not new functionality. No blocker triggered. ### BLOCKERS None. ### NITS 1. **`loading="lazy"` missing**: Coach Manny is the 5th coach card, likely below the fold on most viewports. The gear page uses `loading="lazy"` on its images. However, no coach images on this page use it either, so adding it here alone would be inconsistent. Consider a follow-up to add `loading="lazy"` to all below-fold coach photos (cards 3-6) for LCP improvement. 2. **PR body Related section**: The Related section references `forgejo_admin/westside-app #110` and `westside-app` but does not reference a plan slug. This appears to be a standalone content task without a parent plan, so this is acceptable, but noting for completeness. ### SOP COMPLIANCE - [x] Branch named after issue (`110-add-manny-photo` references #110) - [x] PR body has Summary, Changes, Test Plan, Related - [x] `Closes #110` links PR to parent issue - [x] No secrets committed - [x] No unnecessary file changes (1 file, 1 line changed) - [x] Commit message is descriptive - [ ] Related section does not reference a plan slug (acceptable -- standalone content task) ### PROCESS OBSERVATIONS Minimal-risk content change. Single line, follows established patterns exactly, no logic or functionality changes. Low change failure risk. No deployment frequency impact beyond a standard content update. ### VERDICT: APPROVED