forgejo_admin/westside-playground
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

feat: strip tryout content + fix practice count (#75) #35

Merged
forgejo_admin merged 2 commits from 75-strip-tryout-content into main 2026-03-26 17:15:10 +00:00
Conversation 2 Commits 2 Files changed 21 +2461
forgejo_admin commented 2026-03-26 03:14:55 +00:00
Owner
Copy link

Summary

Strips all stale tryout content from the public site index page and fixes the practice count from 3 to 2 per week. Playground prototype for phone review before copying to the production west-side-basketball repo.

Changes

  • westside-index.html -- cleaned copy of west-side-basketball/index.html with:
    • Tryout announcement banner removed entirely
    • Tryout details section (#tryouts) removed entirely
    • All Stripe payment links removed (3 instances)
    • Hero CTA changed from "Sign Up for Tryouts -- $30" to "Contact Us to Join" (mailto link)
    • Nav "Tryouts" link removed
    • About card: "Three 2-hour team practices per week" changed to "Two 2-hour practices per week"
    • "How It Works" section rewritten as "How to Join" with general onboarding steps (Reach Out, Meet the Coaches, Get Placed)
    • FAQ practice commitment answer updated from 3 to 2
    • FAQ "What if my child doesn't make a team?" removed (tryout-specific)
    • Bottom CTA replaced: "Ready to Compete?" / tryout pitch changed to "Join Westside" / general season messaging
    • Meta description and OG/Twitter descriptions updated to remove tryout references
  • shared/westside-style.css -- copy of production CSS for playground rendering
  • shared/westside-main.js -- copy of production JS for playground rendering

Test Plan

  • Open westside-index.html on phone -- no tryout content visible
  • Search page source for "tryout" / "Tryouts" / "Register Now" / "stripe.com" -- zero hits (verified)
  • All remaining nav links functional (Home, About, Staff, Sponsors, FAQ)
  • Practice count reads "Two 2-hour practices per week" in About card and FAQ
  • Hero and bottom CTAs link to mailto, not Stripe

Review Checklist

  • Passed automated review-fix loop
  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive

Related

## Summary Strips all stale tryout content from the public site index page and fixes the practice count from 3 to 2 per week. Playground prototype for phone review before copying to the production `west-side-basketball` repo. ## Changes - `westside-index.html` -- cleaned copy of `west-side-basketball/index.html` with: - Tryout announcement banner removed entirely - Tryout details section (`#tryouts`) removed entirely - All Stripe payment links removed (3 instances) - Hero CTA changed from "Sign Up for Tryouts -- $30" to "Contact Us to Join" (mailto link) - Nav "Tryouts" link removed - About card: "Three 2-hour team practices per week" changed to "Two 2-hour practices per week" - "How It Works" section rewritten as "How to Join" with general onboarding steps (Reach Out, Meet the Coaches, Get Placed) - FAQ practice commitment answer updated from 3 to 2 - FAQ "What if my child doesn't make a team?" removed (tryout-specific) - Bottom CTA replaced: "Ready to Compete?" / tryout pitch changed to "Join Westside" / general season messaging - Meta description and OG/Twitter descriptions updated to remove tryout references - `shared/westside-style.css` -- copy of production CSS for playground rendering - `shared/westside-main.js` -- copy of production JS for playground rendering ## Test Plan - [ ] Open `westside-index.html` on phone -- no tryout content visible - [ ] Search page source for "tryout" / "Tryouts" / "Register Now" / "stripe.com" -- zero hits (verified) - [ ] All remaining nav links functional (Home, About, Staff, Sponsors, FAQ) - [ ] Practice count reads "Two 2-hour practices per week" in About card and FAQ - [ ] Hero and bottom CTAs link to mailto, not Stripe ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related - Closes forgejo_admin/westside-app#75 - Standalone content cleanup -- no plan phase
Remove stale tryout banner, tryout details section, all Stripe payment
links, and "Register Now" CTAs. Update practice count from 3 to 2 per
week in About card and FAQ. Replace "How It Works" tryout flow with
general "How to Join" section. Replace bottom CTA with "Join Westside"
messaging. Remove nav Tryouts link. Update meta descriptions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-03-26 03:15:27 +00:00
Author
Owner
Copy link

Review: PASS

Reviewed full diff (3 files, 1004 additions). All acceptance criteria from issue #75 verified:

  • Tryout announcement banner removed
  • Tryout details section (#tryouts) removed
  • All Stripe payment links removed (3 instances)
  • Hero CTA replaced with mailto "Contact Us to Join"
  • Nav "Tryouts" link removed
  • About card: "Three 2-hour team practices" -> "Two 2-hour practices per week"
  • FAQ practice commitment: 3 -> 2
  • Bottom CTA: tryout pitch replaced with "Join Westside" + general messaging
  • "How It Works" rewritten as "How to Join" (general onboarding, no tryout flow)
  • Meta/OG/Twitter descriptions updated ("Join the program" replaces "Sign up for tryouts")
  • Source searched for "tryout"/"Tryouts"/"Register Now"/"stripe.com" -- zero hits

No issues found. CSS and JS are unmodified copies of production files for playground rendering only.

## Review: PASS Reviewed full diff (3 files, 1004 additions). All acceptance criteria from issue #75 verified: - [x] Tryout announcement banner removed - [x] Tryout details section (#tryouts) removed - [x] All Stripe payment links removed (3 instances) - [x] Hero CTA replaced with mailto "Contact Us to Join" - [x] Nav "Tryouts" link removed - [x] About card: "Three 2-hour team practices" -> "Two 2-hour practices per week" - [x] FAQ practice commitment: 3 -> 2 - [x] Bottom CTA: tryout pitch replaced with "Join Westside" + general messaging - [x] "How It Works" rewritten as "How to Join" (general onboarding, no tryout flow) - [x] Meta/OG/Twitter descriptions updated ("Join the program" replaces "Sign up for tryouts") - [x] Source searched for "tryout"/"Tryouts"/"Register Now"/"stripe.com" -- zero hits No issues found. CSS and JS are unmodified copies of production files for playground rendering only.
Copies all HTML, CSS, JS, and assets from west-side-basketball so the
playground serves a working mirror of the full site. Updates
westside-index.html to reference real css/style.css and js/main.js
instead of shared/ copies.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-03-26 17:10:52 +00:00
Author
Owner
Copy link

PR #35 Review

DOMAIN REVIEW

Tech stack: Static HTML/CSS/JS (vanilla, no frameworks). This is a playground/prototype repo -- design source of truth for the westside-app SvelteKit production app.

Scope: PR copies the full production west-side-basketball site (12 image assets, CSS, JS, 4 HTML pages) into the playground and creates a cleaned westside-index.html with tryout content stripped and practice count corrected.

Files added (21 total):

  • 12 binary image assets in assets/images/
  • css/style.css + js/main.js (production CSS/JS in original paths)
  • shared/westside-style.css + shared/westside-main.js (duplicates in shared dir)
  • original-index.html (preserved production original with tryout content)
  • westside-index.html (cleaned version -- the deliverable)
  • staff.html, sponsors.html, success.html (production page copies)

Cleanup verification -- westside-index.html:

  • Tryout Announcement Banner: REMOVED
  • Tryouts Details section: REMOVED
  • Nav link to #tryouts: REMOVED
  • All 3 Stripe payment URLs (buy.stripe.com): REMOVED
  • Hero CTA: Changed from "Sign Up for Tryouts -- $30" to "Contact Us to Join" (mailto)
  • Bottom CTA: Changed from tryout-specific to general "Join Westside" (mailto)
  • "How It Works" section: Renamed to "How to Join" with generic steps
  • Practice count: "Three 2-hour" changed to "Two 2-hour" in both About card (line 80) and FAQ (line 143)
  • FAQ "What if my child doesn't make a team?" question: REMOVED
  • FAQ "Does my child need prior AAU experience?" updated to remove "Tryouts are open to all skill levels"
  • Meta descriptions: Updated from "Sign up for tryouts" to "Join the program"
  • Zero residual instances of "tryout" or "stripe" in the cleaned file (verified via grep)

Secrets scan:

  • No API keys, tokens, passwords, or credentials in any file
  • No .env files
  • Stripe URLs only appear in original-index.html (the preserved original, intentionally kept)
  • register.html and billing.html contain design-note comments about API response shapes (e.g., credentials: { email, temp_password }) and k8s secret names -- these are documentation comments in existing playground files, not actual secrets

BLOCKERS

None.

This is a static HTML/CSS/JS playground -- no executable backend code, no user input processing, no auth logic. The BLOCKER criteria (test coverage for new functionality, unvalidated user input, secrets, DRY auth violations) do not apply to static prototype files. The deliverable is a cleaned HTML page, and it is clean.

NITS

  1. Duplicate CSS/JS files. css/style.css and shared/westside-style.css are identical copies (804 lines). Same for js/main.js and shared/westside-main.js (20 lines). The HTML files reference the css/ and js/ paths, making the shared/westside-* copies dead files. PR #36 (CSS/JS unification) likely addresses this, but in isolation this PR ships unused duplicates.

  2. Stale OG/Twitter metadata URLs. westside-index.html lines 13-14 and 21 reference https://ldraney.github.io/west-side-basketball/ for OG URL and image paths. If the production site has moved from GitHub Pages, these are stale. Non-blocking for a playground file.

  3. Production copies retain tryout nav links. The newly added staff.html and sponsors.html (production copies) still contain <li><a href="index.html#tryouts">Tryouts</a></li> in their nav. This is expected for faithful production copies and outside the cleanup scope, but worth noting if these pages are intended to be used standalone alongside westside-index.html.

  4. success.html has stale dates. The copied registration success page references "Friday, March 13" tryout date and Kongo Basketball Gym. Again expected for a faithful production copy, but stale content.

  5. index.html (app-style page) still says "Three" practices. The existing playground index.html (lines 70, 156) still references "Three 2-hour team practices per week." This file was not part of this PR's scope, but the discrepancy between the two index pages is worth a follow-up ticket.

SOP COMPLIANCE

  • Branch named after issue: 75-strip-tryout-content references westside-app#75
  • PR body has Summary, Changes, Test Plan, Related sections
  • Related references plan slug: No plan slug (stated as "standalone cleanup with no planning phase required" -- acceptable per context that parent issue #75 was already completed via a different path)
  • No secrets committed
  • No unnecessary file changes: The shared/westside-style.css and shared/westside-main.js duplicates are unused by any HTML file in this PR. Minor scope creep, likely prep for PR #36.

PROCESS OBSERVATIONS

  • Change failure risk: LOW. This is a playground repo with static files. No deployment pipeline, no backend impact. The cleanup is straightforward text removal and replacement.
  • Dependency chain: PR #36 (CSS/JS unification) depends on this PR. The duplicate files in shared/ appear to be deliberate staging for that follow-up work.
  • Parent issue already closed. westside-app#75 was completed via svelte-playground PR #6 in the production app. This PR provides the playground prototype that was a prerequisite. The ordering is unusual (production shipped before playground) but the work itself is valid.

VERDICT: APPROVED

## PR #35 Review ### DOMAIN REVIEW **Tech stack:** Static HTML/CSS/JS (vanilla, no frameworks). This is a playground/prototype repo -- design source of truth for the westside-app SvelteKit production app. **Scope:** PR copies the full production west-side-basketball site (12 image assets, CSS, JS, 4 HTML pages) into the playground and creates a cleaned `westside-index.html` with tryout content stripped and practice count corrected. **Files added (21 total):** - 12 binary image assets in `assets/images/` - `css/style.css` + `js/main.js` (production CSS/JS in original paths) - `shared/westside-style.css` + `shared/westside-main.js` (duplicates in shared dir) - `original-index.html` (preserved production original with tryout content) - `westside-index.html` (cleaned version -- the deliverable) - `staff.html`, `sponsors.html`, `success.html` (production page copies) **Cleanup verification -- westside-index.html:** - Tryout Announcement Banner: REMOVED - Tryouts Details section: REMOVED - Nav link to `#tryouts`: REMOVED - All 3 Stripe payment URLs (`buy.stripe.com`): REMOVED - Hero CTA: Changed from "Sign Up for Tryouts -- $30" to "Contact Us to Join" (mailto) - Bottom CTA: Changed from tryout-specific to general "Join Westside" (mailto) - "How It Works" section: Renamed to "How to Join" with generic steps - Practice count: "Three 2-hour" changed to "Two 2-hour" in both About card (line 80) and FAQ (line 143) - FAQ "What if my child doesn't make a team?" question: REMOVED - FAQ "Does my child need prior AAU experience?" updated to remove "Tryouts are open to all skill levels" - Meta descriptions: Updated from "Sign up for tryouts" to "Join the program" - Zero residual instances of "tryout" or "stripe" in the cleaned file (verified via grep) **Secrets scan:** - No API keys, tokens, passwords, or credentials in any file - No `.env` files - Stripe URLs only appear in `original-index.html` (the preserved original, intentionally kept) - `register.html` and `billing.html` contain design-note comments about API response shapes (e.g., `credentials: { email, temp_password }`) and k8s secret names -- these are documentation comments in existing playground files, not actual secrets ### BLOCKERS None. This is a static HTML/CSS/JS playground -- no executable backend code, no user input processing, no auth logic. The BLOCKER criteria (test coverage for new functionality, unvalidated user input, secrets, DRY auth violations) do not apply to static prototype files. The deliverable is a cleaned HTML page, and it is clean. ### NITS 1. **Duplicate CSS/JS files.** `css/style.css` and `shared/westside-style.css` are identical copies (804 lines). Same for `js/main.js` and `shared/westside-main.js` (20 lines). The HTML files reference the `css/` and `js/` paths, making the `shared/westside-*` copies dead files. PR #36 (CSS/JS unification) likely addresses this, but in isolation this PR ships unused duplicates. 2. **Stale OG/Twitter metadata URLs.** `westside-index.html` lines 13-14 and 21 reference `https://ldraney.github.io/west-side-basketball/` for OG URL and image paths. If the production site has moved from GitHub Pages, these are stale. Non-blocking for a playground file. 3. **Production copies retain tryout nav links.** The newly added `staff.html` and `sponsors.html` (production copies) still contain `<li><a href="index.html#tryouts">Tryouts</a></li>` in their nav. This is expected for faithful production copies and outside the cleanup scope, but worth noting if these pages are intended to be used standalone alongside `westside-index.html`. 4. **`success.html` has stale dates.** The copied registration success page references "Friday, March 13" tryout date and Kongo Basketball Gym. Again expected for a faithful production copy, but stale content. 5. **`index.html` (app-style page) still says "Three" practices.** The existing playground `index.html` (lines 70, 156) still references "Three 2-hour team practices per week." This file was not part of this PR's scope, but the discrepancy between the two index pages is worth a follow-up ticket. ### SOP COMPLIANCE - [x] Branch named after issue: `75-strip-tryout-content` references westside-app#75 - [x] PR body has Summary, Changes, Test Plan, Related sections - [ ] Related references plan slug: No plan slug (stated as "standalone cleanup with no planning phase required" -- acceptable per context that parent issue #75 was already completed via a different path) - [x] No secrets committed - [ ] No unnecessary file changes: The `shared/westside-style.css` and `shared/westside-main.js` duplicates are unused by any HTML file in this PR. Minor scope creep, likely prep for PR #36. ### PROCESS OBSERVATIONS - **Change failure risk: LOW.** This is a playground repo with static files. No deployment pipeline, no backend impact. The cleanup is straightforward text removal and replacement. - **Dependency chain:** PR #36 (CSS/JS unification) depends on this PR. The duplicate files in `shared/` appear to be deliberate staging for that follow-up work. - **Parent issue already closed.** westside-app#75 was completed via svelte-playground PR #6 in the production app. This PR provides the playground prototype that was a prerequisite. The ordering is unusual (production shipped before playground) but the work itself is valid. ### VERDICT: APPROVED
forgejo_admin deleted branch 75-strip-tryout-content 2026-03-26 17:15:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/westside-playground!35
No description provided.