fix: Role-appropriate bottom nav on all authenticated pages #27

Merged

forgejo_admin merged 1 commit from 23-fix-role-appropriate-bottom-nav into main

2026-03-16 22:58:08 +00:00

forgejo_admin commented

2026-03-16 22:53:22 +00:00

Owner

Summary

Fixes bottom navigation across all authenticated pages so each role sees only the links appropriate to them. Admin pages show Dashboard | Teams | Sign Out. Player pages show My Player | My Team | Sign Out with correct active states per page.

Changes

admin.html — Replaced Coach View and Player links with Teams link pointing to admin-teams.html
parent.html — Added My Team link to team.html (was missing entirely)
player-profile.html — Changed Profile (active, self-referencing) to My Team link pointing to team.html
billing.html — Changed Profile link to My Player link pointing to parent.html
admin-teams.html — No changes needed (already correct: Dashboard | Teams active | Sign Out)
team.html — No changes needed (already correct: My Player | My Team active | Sign Out)

Test Plan

Open admin.html — verify bottom nav shows: Dashboard (active) | Teams | Sign Out
Open admin-teams.html — verify bottom nav shows: Dashboard | Teams (active) | Sign Out
Open parent.html — verify bottom nav shows: My Player (active) | My Team | Sign Out
Open player-profile.html — verify bottom nav shows: My Player | My Team | Sign Out
Open billing.html — verify bottom nav shows: My Player | Billing (active) | Sign Out
Open team.html — verify bottom nav shows: My Player | My Team (active) | Sign Out
Confirm no admin page shows "My Player" and no player page shows "Dashboard"
Confirm coach.html, index.html, tryouts.html, register.html, signin.html are untouched

Review Checklist

Only bottom <nav class="bottom-nav"> sections modified — no content changes above nav
No changes to coach.html, index.html, tryouts.html, register.html, signin.html
Admin pages: Dashboard | Teams | Sign Out
Player pages: My Player | My Team | Sign Out (correct active states)
Billing page: My Player | Billing (active) | Sign Out
All nav links point to correct pages

Plan: plan-wkq (traceability)
Closes #23

## Summary Fixes bottom navigation across all authenticated pages so each role sees only the links appropriate to them. Admin pages show Dashboard | Teams | Sign Out. Player pages show My Player | My Team | Sign Out with correct active states per page. ## Changes - `admin.html` — Replaced Coach View and Player links with Teams link pointing to `admin-teams.html` - `parent.html` — Added My Team link to `team.html` (was missing entirely) - `player-profile.html` — Changed Profile (active, self-referencing) to My Team link pointing to `team.html` - `billing.html` — Changed Profile link to My Player link pointing to `parent.html` - `admin-teams.html` — No changes needed (already correct: Dashboard | Teams active | Sign Out) - `team.html` — No changes needed (already correct: My Player | My Team active | Sign Out) ## Test Plan - Open `admin.html` — verify bottom nav shows: Dashboard (active) | Teams | Sign Out - Open `admin-teams.html` — verify bottom nav shows: Dashboard | Teams (active) | Sign Out - Open `parent.html` — verify bottom nav shows: My Player (active) | My Team | Sign Out - Open `player-profile.html` — verify bottom nav shows: My Player | My Team | Sign Out - Open `billing.html` — verify bottom nav shows: My Player | Billing (active) | Sign Out - Open `team.html` — verify bottom nav shows: My Player | My Team (active) | Sign Out - Confirm no admin page shows "My Player" and no player page shows "Dashboard" - Confirm `coach.html`, `index.html`, `tryouts.html`, `register.html`, `signin.html` are untouched ## Review Checklist - [x] Only bottom `<nav class="bottom-nav">` sections modified — no content changes above nav - [x] No changes to coach.html, index.html, tryouts.html, register.html, signin.html - [x] Admin pages: Dashboard | Teams | Sign Out - [x] Player pages: My Player | My Team | Sign Out (correct active states) - [x] Billing page: My Player | Billing (active) | Sign Out - [x] All nav links point to correct pages ## Related - Plan: `plan-wkq` (traceability) - Closes #23

forgejo_admin added 1 commit

2026-03-16 22:53:22 +00:00

fix: role-appropriate bottom nav on all authenticated pages c09fd98774

Admin pages now show Dashboard | Teams | Sign Out instead of linking
to Coach View and Player. Player pages consistently show
My Player | My Team | Sign Out with correct active states.

Closes #23

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-16 22:53:48 +00:00

Author

Owner

Self-Review

Reviewed diff against all acceptance criteria from #23. No issues found.

Verified:

admin.html: Dashboard (active) | Teams | Sign Out
admin-teams.html: Dashboard | Teams (active) | Sign Out (untouched, already correct)
parent.html: My Player (active) | My Team | Sign Out
player-profile.html: My Player | My Team | Sign Out
billing.html: My Player | Billing (active) | Sign Out
team.html: My Player | My Team (active) | Sign Out (untouched, already correct)

Scope: Only <nav class="bottom-nav"> sections modified. No content above nav changed. No changes to coach.html, index.html, tryouts.html, register.html, or signin.html. 4 files, 12+/12-, minimal and focused.

## Self-Review Reviewed diff against all acceptance criteria from #23. No issues found. **Verified:** - admin.html: Dashboard (active) | Teams | Sign Out - admin-teams.html: Dashboard | Teams (active) | Sign Out (untouched, already correct) - parent.html: My Player (active) | My Team | Sign Out - player-profile.html: My Player | My Team | Sign Out - billing.html: My Player | Billing (active) | Sign Out - team.html: My Player | My Team (active) | Sign Out (untouched, already correct) **Scope:** Only `<nav class="bottom-nav">` sections modified. No content above nav changed. No changes to coach.html, index.html, tryouts.html, register.html, or signin.html. 4 files, 12+/12-, minimal and focused.