fix: wire all roster player links to player-profile.html #28

Merged

forgejo_admin merged 1 commit from 24-fix-wire-all-team-roster-player-links-to into main

2026-03-16 22:57:41 +00:00

forgejo_admin commented

2026-03-16 22:55:20 +00:00

Owner

Summary

All 7 remaining teammate-row anchor tags in team.html had href="#" instead of linking to player-profile.html. Only Marcus Johnson Jr. (the first roster entry) was correctly wired. Now all 8 roster entries navigate to the player profile page. Admin Tools links (Edit Roster, Export CSV) are intentionally left as href="#".

Changes

team.html: Changed href="#" to href="player-profile.html" on 7 teammate-row anchor tags (Connor Behunin, Owence Bully, Hasip Yigit Ulgener, Hasip Sarp Ulgener, Elson Olotu, Gabrielius Peciulis, Romial Strachan)

Test Plan

Open team.html in a browser
Click each player row in the Roster section -- all 8 should navigate to player-profile.html
Verify Admin Tools buttons (Edit Roster, Export CSV) still have href="#" and do not navigate
No regressions in other page links

Review Checklist

Passed automated review-fix loop
No secrets committed
No unnecessary file changes
Commit messages are descriptive

Closes #24
Plan: plan-wkq

## Summary All 7 remaining teammate-row anchor tags in team.html had `href="#"` instead of linking to `player-profile.html`. Only Marcus Johnson Jr. (the first roster entry) was correctly wired. Now all 8 roster entries navigate to the player profile page. Admin Tools links (`Edit Roster`, `Export CSV`) are intentionally left as `href="#"`. ## Changes - `team.html`: Changed `href="#"` to `href="player-profile.html"` on 7 teammate-row anchor tags (Connor Behunin, Owence Bully, Hasip Yigit Ulgener, Hasip Sarp Ulgener, Elson Olotu, Gabrielius Peciulis, Romial Strachan) ## Test Plan - [ ] Open `team.html` in a browser - [ ] Click each player row in the Roster section -- all 8 should navigate to `player-profile.html` - [ ] Verify Admin Tools buttons (Edit Roster, Export CSV) still have `href="#"` and do not navigate - [ ] No regressions in other page links ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related - Closes #24 - Plan: `plan-wkq`

forgejo_admin added 1 commit

2026-03-16 22:55:20 +00:00

fix: wire all roster player links to player-profile.html 4e43c915e6

All 7 remaining teammate-row anchor tags in team.html pointed to href="#"
instead of player-profile.html. Only the first player (Marcus Johnson Jr.)
was correctly linked. Now all 8 roster entries navigate to the player
profile page.

Closes #24

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-16 22:55:44 +00:00

Author

Owner

Review: PASS

Diff: 1 file, 7 lines changed (all substitutions). Clean and minimal.

Verified:

All 7 remaining href="#" on .teammate-row anchors changed to href="player-profile.html"
First player (Marcus Johnson Jr.) was already correct -- untouched
Admin Tools links (Edit Roster, Export CSV) intentionally left as href="#" -- not in diff
No unrelated changes, no secrets, no extra files

No issues found. Ready to merge.

## Review: PASS **Diff**: 1 file, 7 lines changed (all substitutions). Clean and minimal. **Verified**: - All 7 remaining `href="#"` on `.teammate-row` anchors changed to `href="player-profile.html"` - First player (Marcus Johnson Jr.) was already correct -- untouched - Admin Tools links (`Edit Roster`, `Export CSV`) intentionally left as `href="#"` -- not in diff - No unrelated changes, no secrets, no extra files No issues found. Ready to merge.