fix: coach bottom nav — Team/Plays/Sign Out #34

Merged

forgejo_admin merged 2 commits from 33-coach-bottom-nav-fix into main

2026-03-16 23:17:42 +00:00

forgejo_admin commented

2026-03-16 23:15:05 +00:00

Owner

Summary

Replaces the coach page bottom nav items. "My Team" becomes "Team", "My Player" becomes "Plays" (links to the plays tab on the same page), and "Sign Out" stays unchanged.

Changes

coach.html: Replaced bottom nav "My Team | My Player | Sign Out" with "Team | Plays | Sign Out". The Plays nav item uses the gear icon (matching the plays tab header) and activates the plays tab via an onclick handler instead of navigating to parent.html.

Test Plan

Open coach.html in a browser
Verify bottom nav shows "Team | Plays | Sign Out"
Tap "Team" — stays on coach.html with team tab active
Tap "Plays" — switches to the plays tab on the same page
Tap "Sign Out" — navigates to index.html

Review Checklist

Passed automated review-fix loop
No secrets committed
No unnecessary file changes
Commit messages are descriptive

Closes #33
plan-wkq

## Summary Replaces the coach page bottom nav items. "My Team" becomes "Team", "My Player" becomes "Plays" (links to the plays tab on the same page), and "Sign Out" stays unchanged. ## Changes - `coach.html`: Replaced bottom nav "My Team | My Player | Sign Out" with "Team | Plays | Sign Out". The Plays nav item uses the gear icon (matching the plays tab header) and activates the plays tab via an onclick handler instead of navigating to parent.html. ## Test Plan - [ ] Open coach.html in a browser - [ ] Verify bottom nav shows "Team | Plays | Sign Out" - [ ] Tap "Team" — stays on coach.html with team tab active - [ ] Tap "Plays" — switches to the plays tab on the same page - [ ] Tap "Sign Out" — navigates to index.html ## Review Checklist - [ ] Passed automated review-fix loop - [ ] No secrets committed - [ ] No unnecessary file changes - [ ] Commit messages are descriptive ## Related - Closes #33 - `plan-wkq`

forgejo_admin added 1 commit

2026-03-16 23:15:06 +00:00

fix: replace coach bottom nav My Team/My Player with Team/Plays/Sign Out 56eae217bc

Closes #33

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin added 1 commit

2026-03-16 23:15:31 +00:00

fix: prevent page reload when clicking Plays nav item a8a2c2b473

Use href="#" with event.preventDefault() so clicking Plays switches
tabs without reloading the page.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-16 23:15:47 +00:00

Author

Owner

Review-Fix Loop

Finding: The Plays nav item had href="coach.html" which would reload the page before the onclick handler could switch tabs. Since the user is already on coach.html, this would cause a full page reload and the tab switch would never happen.

Fix (a8a2c2b): Changed to href="#" with event.preventDefault() so the Plays button stays on the current page and switches to the plays tab without reloading.

No other issues found. Diff is minimal (4 additions, 4 deletions across 1 file), scoped exactly to the bottom nav replacement.

## Review-Fix Loop **Finding:** The Plays nav item had `href="coach.html"` which would reload the page before the `onclick` handler could switch tabs. Since the user is already on coach.html, this would cause a full page reload and the tab switch would never happen. **Fix (a8a2c2b):** Changed to `href="#"` with `event.preventDefault()` so the Plays button stays on the current page and switches to the plays tab without reloading. No other issues found. Diff is minimal (4 additions, 4 deletions across 1 file), scoped exactly to the bottom nav replacement.