forgejo_admin/westside-playground
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

feat: dedicated About page + landing page trim (#91) #40

Merged
forgejo_admin merged 1 commit from 91-about-page into main 2026-03-27 00:20:47 +00:00
Conversation 2 Commits 1 Files changed 7 +177 -34
forgejo_admin commented 2026-03-27 00:14:52 +00:00
Owner
Copy link

Summary

Moves the About section from the landing page to a dedicated about.html with expanded program information. The landing page is trimmed to Hero > How to Join > CTA. Nav updated site-wide.

Changes

  • about.html (new) -- Dedicated About page with: What We Do (3 cards from index), Program Philosophy (4 values cards + Marcus quote), Divisions (15U/16U/17U), Location section, CTA + footer. Component doc comment at top.
  • index.html -- Removed About section (3 cards + blockquote). Nav link updated from #about to about.html. Landing page is now Hero > How to Join > CTA.
  • staff.html -- Nav link updated from index.html#about to about.html.
  • sponsors.html -- Nav link updated from index.html#about to about.html.
  • schedule.html -- Nav link updated from index.html#about to about.html.
  • register.html -- Nav link updated from index.html#about to about.html.
  • success.html -- Nav link updated from index.html#about to about.html.

Test Plan

  • All nav links resolve (Home, About, Staff, Sponsors, Schedule)
  • about.html renders all sections: hero, What We Do cards, Philosophy cards + quote, Divisions, Location, CTA
  • index.html no longer has About section -- Hero > How to Join > CTA only
  • Visual check at 390px mobile viewport
  • No remaining #about or index.html#about references in any HTML file

Review Checklist

  • Nav spec matches comment override: Home | About | Staff | Sponsors | Schedule
  • No Tryouts, Teams, or Gear links added (those pages do not exist yet)
  • Component doc comment at top of about.html
  • Uses shared/style.css and shared/app.js defer
  • Mobile-first structure (same patterns as existing pages)
  • All 7 public pages updated with consistent nav

Related

## Summary Moves the About section from the landing page to a dedicated `about.html` with expanded program information. The landing page is trimmed to Hero > How to Join > CTA. Nav updated site-wide. ## Changes - **`about.html` (new)** -- Dedicated About page with: What We Do (3 cards from index), Program Philosophy (4 values cards + Marcus quote), Divisions (15U/16U/17U), Location section, CTA + footer. Component doc comment at top. - **`index.html`** -- Removed About section (3 cards + blockquote). Nav link updated from `#about` to `about.html`. Landing page is now Hero > How to Join > CTA. - **`staff.html`** -- Nav link updated from `index.html#about` to `about.html`. - **`sponsors.html`** -- Nav link updated from `index.html#about` to `about.html`. - **`schedule.html`** -- Nav link updated from `index.html#about` to `about.html`. - **`register.html`** -- Nav link updated from `index.html#about` to `about.html`. - **`success.html`** -- Nav link updated from `index.html#about` to `about.html`. ## Test Plan - [ ] All nav links resolve (Home, About, Staff, Sponsors, Schedule) - [ ] `about.html` renders all sections: hero, What We Do cards, Philosophy cards + quote, Divisions, Location, CTA - [ ] `index.html` no longer has About section -- Hero > How to Join > CTA only - [ ] Visual check at 390px mobile viewport - [ ] No remaining `#about` or `index.html#about` references in any HTML file ## Review Checklist - [x] Nav spec matches comment override: `Home | About | Staff | Sponsors | Schedule` - [x] No Tryouts, Teams, or Gear links added (those pages do not exist yet) - [x] Component doc comment at top of `about.html` - [x] Uses `shared/style.css` and `shared/app.js defer` - [x] Mobile-first structure (same patterns as existing pages) - [x] All 7 public pages updated with consistent nav ## Related - Closes forgejo_admin/westside-app#91 - Nav spec per comment override: `Home | About | Staff | Sponsors | Schedule`
Move About section (3 cards + Marcus quote) from index.html to a
dedicated about.html with expanded program info: philosophy, divisions,
location. Landing page trimmed to Hero > How to Join > CTA. Nav updated
on all 7 public pages: Home | About | Staff | Sponsors | Schedule.

Closes forgejo_admin/westside-app#91

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-03-27 00:15:35 +00:00
Author
Owner
Copy link

QA Review: PR #40

Scope Verification (vs. westside-app#91 + comment overrides)

  • about.html created with expanded program info (What We Do, Philosophy, Divisions, Location)
  • 3 cards (Structured Training, Competitive Play, Next-Level Prep) moved from index to about
  • Marcus quote ("Built on the Westside. Built to win the right way.") present in Philosophy section
  • About section fully removed from index.html -- landing page is Hero > How to Join > CTA
  • Nav updated on all 7 public pages: Home | About | Staff | Sponsors | Schedule
  • Nav spec matches comment override exactly -- no Tryouts, Teams, or Gear links

Structural Review

  • Component doc comment at top of about.html (@route /about, @auth public, @nav About (active), @api none)
  • Uses shared/style.css and shared/app.js defer
  • OG meta tags present and consistent with sibling pages
  • Favicon links present and consistent
  • Nav HTML structure identical across all 7 files -- no drift
  • Footer identical across all files
  • CSS classes follow existing patterns (section, section-alt, grid grid-3, grid grid-2, card, card-centered, quote-block, cta-banner, mt-md)
  • No stale #about or index.html#about references remain anywhere in the diff

Content Review

  • Program details expanded: West Valley Utah, AAU, boys and girls, 15U/16U/17U, Power 32 + regional + local leagues
  • Philosophy section adds depth: Accountability, Toughness, Confidence, Culture
  • Division descriptions appropriate for each age group
  • Location section with contact info

Findings

No issues found.

VERDICT: APPROVED

## QA Review: PR #40 ### Scope Verification (vs. westside-app#91 + comment overrides) - [x] `about.html` created with expanded program info (What We Do, Philosophy, Divisions, Location) - [x] 3 cards (Structured Training, Competitive Play, Next-Level Prep) moved from index to about - [x] Marcus quote ("Built on the Westside. Built to win the right way.") present in Philosophy section - [x] About section fully removed from `index.html` -- landing page is Hero > How to Join > CTA - [x] Nav updated on all 7 public pages: Home | About | Staff | Sponsors | Schedule - [x] Nav spec matches comment override exactly -- no Tryouts, Teams, or Gear links ### Structural Review - [x] Component doc comment at top of `about.html` (`@route /about`, `@auth public`, `@nav About (active)`, `@api none`) - [x] Uses `shared/style.css` and `shared/app.js defer` - [x] OG meta tags present and consistent with sibling pages - [x] Favicon links present and consistent - [x] Nav HTML structure identical across all 7 files -- no drift - [x] Footer identical across all files - [x] CSS classes follow existing patterns (`section`, `section-alt`, `grid grid-3`, `grid grid-2`, `card`, `card-centered`, `quote-block`, `cta-banner`, `mt-md`) - [x] No stale `#about` or `index.html#about` references remain anywhere in the diff ### Content Review - [x] Program details expanded: West Valley Utah, AAU, boys and girls, 15U/16U/17U, Power 32 + regional + local leagues - [x] Philosophy section adds depth: Accountability, Toughness, Confidence, Culture - [x] Division descriptions appropriate for each age group - [x] Location section with contact info ### Findings No issues found. **VERDICT: APPROVED**
forgejo_admin commented 2026-03-27 00:18:58 +00:00
Author
Owner
Copy link

PR #40 Review

DOMAIN REVIEW

Tech stack: Static HTML/CSS playground (vanilla HTML, shared CSS design system, no JS logic).

Content migration: The 3 "What We Do" cards (Structured Training, Competitive Play, Next-Level Prep) and the Coach Marcus blockquote were cleanly moved from index.html to about.html. Content is preserved verbatim -- no drift.

New content in about.html: Program Philosophy (4 values cards), Divisions (15U/16U/17U), Location section, CTA + footer. All use existing CSS classes from shared/style.css. Verified: .grid-2, .grid-3, .section-alt, .quote-block, .quote-author, .card-centered, .mt-md all exist in the stylesheet.

Nav consistency: All 6 active public pages updated from #about / index.html#about to about.html. Nav order is Home | About | Staff | Sponsors | Schedule on every touched file. No Tryouts/Teams/Gear links added -- correct per scope.

HTML quality:

  • Proper lang="en", viewport meta, charset on about.html
  • Semantic sectioning: <nav>, <section>, <footer>, <blockquote>
  • aria-label="Main navigation" on nav, aria-expanded/aria-controls/aria-label on toggle button
  • OG tags with correct URL pattern (ldraney.github.io/west-side-basketball/about.html)
  • Favicon links match existing page pattern
  • <script src="shared/app.js" defer> at end of body -- matches all other pages

Accessibility: Nav toggle has proper ARIA attributes. Logo image has alt="" (decorative, correct since brand name is in adjacent text). Heading hierarchy is clean: single <h1> in hero, <h2> per section, <h3> per card.

index.html after change: Hero > How to Join > CTA. The About section (lines 65-91 on main) is fully removed. Landing page is now a focused funnel. Correct per spec.

BLOCKERS

None.

This is a static HTML playground with no JavaScript logic, no user input processing, no API calls, and no authentication. The BLOCKER criteria (test coverage, input validation, secrets, DRY auth) do not apply. There is nothing to test programmatically -- validation is visual inspection per the Test Plan.

NITS

  1. tryouts.html stale #about reference (line 42): This file still has <a href="index.html#about">About</a> in its nav. Since the #about anchor no longer exists on index.html, this is now a dead fragment link. The page is not in the active nav and is not linked from any other page, so this is not user-facing. However, if/when tryouts.html is reactivated (issue #92), the nav will need updating. Consider updating it now for completeness, or note it as discovered scope on issue #92.

  2. No aria-current="page" on active nav links: None of the playground pages mark their own nav link as the current page. This is a pre-existing pattern (not introduced by this PR), but worth noting for future accessibility polish. Screen readers benefit from aria-current="page" to indicate the user's current location.

SOP COMPLIANCE

  • Branch named after issue: 91-about-page references westside-app#91
  • PR body has Summary, Changes, Test Plan, Related sections
  • Related references parent issue: Closes forgejo_admin/westside-app#91
  • No plan slug (confirmed: no plan slug expected per task context)
  • No secrets, credentials, or .env files committed
  • No scope creep -- all changes are nav updates and about page creation
  • Commit messages are descriptive (PR title: feat: dedicated About page + landing page trim (#91))

PROCESS OBSERVATIONS

Clean, focused PR. 7 files changed, 177 additions, 34 deletions. The content migration preserves existing copy exactly while expanding the About page with new sections. All active public pages have consistent nav. The playground-first workflow is working well here -- this prototype will gate the production SvelteKit implementation.

The stale tryouts.html nav link is the only loose end. Since issue #92 (Tryouts page) exists on the board, that is the natural place to address it.

VERDICT: APPROVED

## PR #40 Review ### DOMAIN REVIEW **Tech stack:** Static HTML/CSS playground (vanilla HTML, shared CSS design system, no JS logic). **Content migration:** The 3 "What We Do" cards (Structured Training, Competitive Play, Next-Level Prep) and the Coach Marcus blockquote were cleanly moved from `index.html` to `about.html`. Content is preserved verbatim -- no drift. **New content in `about.html`:** Program Philosophy (4 values cards), Divisions (15U/16U/17U), Location section, CTA + footer. All use existing CSS classes from `shared/style.css`. Verified: `.grid-2`, `.grid-3`, `.section-alt`, `.quote-block`, `.quote-author`, `.card-centered`, `.mt-md` all exist in the stylesheet. **Nav consistency:** All 6 active public pages updated from `#about` / `index.html#about` to `about.html`. Nav order is `Home | About | Staff | Sponsors | Schedule` on every touched file. No Tryouts/Teams/Gear links added -- correct per scope. **HTML quality:** - Proper `lang="en"`, viewport meta, charset on `about.html` - Semantic sectioning: `<nav>`, `<section>`, `<footer>`, `<blockquote>` - `aria-label="Main navigation"` on nav, `aria-expanded`/`aria-controls`/`aria-label` on toggle button - OG tags with correct URL pattern (`ldraney.github.io/west-side-basketball/about.html`) - Favicon links match existing page pattern - `<script src="shared/app.js" defer>` at end of body -- matches all other pages **Accessibility:** Nav toggle has proper ARIA attributes. Logo image has `alt=""` (decorative, correct since brand name is in adjacent text). Heading hierarchy is clean: single `<h1>` in hero, `<h2>` per section, `<h3>` per card. **`index.html` after change:** Hero > How to Join > CTA. The About section (lines 65-91 on main) is fully removed. Landing page is now a focused funnel. Correct per spec. ### BLOCKERS None. This is a static HTML playground with no JavaScript logic, no user input processing, no API calls, and no authentication. The BLOCKER criteria (test coverage, input validation, secrets, DRY auth) do not apply. There is nothing to test programmatically -- validation is visual inspection per the Test Plan. ### NITS 1. **`tryouts.html` stale `#about` reference (line 42):** This file still has `<a href="index.html#about">About</a>` in its nav. Since the `#about` anchor no longer exists on `index.html`, this is now a dead fragment link. The page is not in the active nav and is not linked from any other page, so this is not user-facing. However, if/when `tryouts.html` is reactivated (issue #92), the nav will need updating. Consider updating it now for completeness, or note it as discovered scope on issue #92. 2. **No `aria-current="page"` on active nav links:** None of the playground pages mark their own nav link as the current page. This is a pre-existing pattern (not introduced by this PR), but worth noting for future accessibility polish. Screen readers benefit from `aria-current="page"` to indicate the user's current location. ### SOP COMPLIANCE - [x] Branch named after issue: `91-about-page` references westside-app#91 - [x] PR body has Summary, Changes, Test Plan, Related sections - [x] Related references parent issue: `Closes forgejo_admin/westside-app#91` - [x] No plan slug (confirmed: no plan slug expected per task context) - [x] No secrets, credentials, or `.env` files committed - [x] No scope creep -- all changes are nav updates and about page creation - [x] Commit messages are descriptive (PR title: `feat: dedicated About page + landing page trim (#91)`) ### PROCESS OBSERVATIONS Clean, focused PR. 7 files changed, 177 additions, 34 deletions. The content migration preserves existing copy exactly while expanding the About page with new sections. All active public pages have consistent nav. The playground-first workflow is working well here -- this prototype will gate the production SvelteKit implementation. The stale `tryouts.html` nav link is the only loose end. Since issue #92 (Tryouts page) exists on the board, that is the natural place to address it. ### VERDICT: APPROVED
forgejo_admin deleted branch 91-about-page 2026-03-27 00:20:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/westside-playground!40
No description provided.