feat: add brand_color default to load_email_template (#344) #352

Merged

forgejo_admin merged 1 commit from 344-brand-color-templates into main

2026-04-06 15:50:39 +00:00

forgejo_admin commented

2026-04-06 15:48:16 +00:00

Contributor

Summary

Add a default brand_color of #d42026 (Kings red) to load_email_template() so templates using {{brand_color}} placeholders render correctly without callers needing to explicitly pass it. Queens callers pass brand_color='#e91e8c' to override.

Changes

src/basketball_api/services/email.py — After loading HTML and before the replacement loop, default data['brand_color'] to #d42026 if not already provided

Test Plan

All 840 existing tests pass (pytest tests/ — 0 failures)
Existing callers unaffected (brand_color defaults to Kings red)
Queens callers can override by passing brand_color='#e91e8c' in data dict

Review Checklist

Code change is minimal and focused
All 840 tests pass
Backwards compatible — no existing callers need changes
Companion template changes applied on host filesystem (not in this PR)

Closes #344
Companion change: {{brand_color}} placeholders applied to action.html (10 replacements), announcement.html (13), notification.html (9) on host filesystem

None

## Summary Add a default `brand_color` of `#d42026` (Kings red) to `load_email_template()` so templates using `{{brand_color}}` placeholders render correctly without callers needing to explicitly pass it. Queens callers pass `brand_color='#e91e8c'` to override. ## Changes - `src/basketball_api/services/email.py` — After loading HTML and before the replacement loop, default `data['brand_color']` to `#d42026` if not already provided ## Test Plan - All 840 existing tests pass (`pytest tests/` — 0 failures) - Existing callers unaffected (brand_color defaults to Kings red) - Queens callers can override by passing `brand_color='#e91e8c'` in data dict ## Review Checklist - [x] Code change is minimal and focused - [x] All 840 tests pass - [x] Backwards compatible — no existing callers need changes - [x] Companion template changes applied on host filesystem (not in this PR) ## Related - Closes #344 - Companion change: `{{brand_color}}` placeholders applied to action.html (10 replacements), announcement.html (13), notification.html (9) on host filesystem ## Related Notes - None

forgejo_admin added 1 commit

2026-04-06 15:48:16 +00:00

feat: add brand_color default to load_email_template (#344 )

ci/woodpecker/pr/woodpecker Pipeline failed

Details

ff9d916af7

Default brand_color to Kings red (#d42026) if not provided in data dict,
enabling templates to use {{brand_color}} placeholders while maintaining
backwards compatibility for all existing callers.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-04-06 15:49:17 +00:00

Author

Contributor

QA Review — PR #352

Diff Summary

1 file changed: src/basketball_api/services/email.py (+4 lines)
Adds default brand_color = '#d42026' in load_email_template() if not provided in data dict
Placement is correct: after HTML load, before replacement loop

Findings

Correctness: Logic is sound. The not in check ensures existing callers are unaffected while new template placeholders resolve.
Backwards compatibility: Confirmed — no existing callers pass brand_color, so they all get Kings red by default.
Side effect: The function mutates the caller's data dict. This is acceptable given current usage patterns (callers construct data inline), but worth noting.
Tests: 840 tests pass, 0 failures.
Style: Clean, idiomatic Python. Comment explains the default clearly.

Nits

None.

VERDICT: APPROVED

## QA Review — PR #352 ### Diff Summary - **1 file changed**: `src/basketball_api/services/email.py` (+4 lines) - Adds default `brand_color = '#d42026'` in `load_email_template()` if not provided in `data` dict - Placement is correct: after HTML load, before replacement loop ### Findings - **Correctness**: Logic is sound. The `not in` check ensures existing callers are unaffected while new template placeholders resolve. - **Backwards compatibility**: Confirmed — no existing callers pass `brand_color`, so they all get Kings red by default. - **Side effect**: The function mutates the caller's `data` dict. This is acceptable given current usage patterns (callers construct `data` inline), but worth noting. - **Tests**: 840 tests pass, 0 failures. - **Style**: Clean, idiomatic Python. Comment explains the default clearly. ### Nits - None. **VERDICT: APPROVED**