feat: add GET /public/schedule endpoint #241

Merged

forgejo_admin merged 1 commit from 239-public-schedule-endpoint into main

2026-03-29 18:50:03 +00:00

forgejo_admin commented

2026-03-29 04:02:32 +00:00

Contributor

Summary

Adds an unauthenticated GET /public/schedule endpoint that returns active practices and all events for the default tenant. This unblocks the westside-landing public schedule page refactor.

Changes

src/basketball_api/routes/public.py -- Added GET /schedule endpoint following the existing /teams and /coaches pattern (hardcoded tenant_id=1, no auth). Imports and reuses CombinedScheduleResponse, _practice_to_response, and _event_to_response from routes/schedule.py for frontend compatibility. Only active practices (is_active=True) are returned; all events are returned for frontend display filtering.

Test Plan

pytest tests/test_public.py tests/test_schedule.py -v -- all 60 tests pass
Full suite: 562 passed (2 pre-existing failures unrelated to this change, 152 errors from tests requiring running Postgres service containers)
Verify: curl /public/schedule returns { practices: [...], events: [...] } with no auth
Verify: inactive practices are excluded from response

Review Checklist

Only modifies routes/public.py -- no model or admin endpoint changes
Follows existing public route pattern (tenant_id=1, no auth)
Reuses schedule response schemas per issue instructions
ruff format and ruff check pass
All existing tests pass

Closes #239

Blocks: forgejo_admin/westside-landing#172 (public schedule page refactor)
Depends on: #232 (data model), #233 (admin endpoints) -- both merged

None

## Summary Adds an unauthenticated `GET /public/schedule` endpoint that returns active practices and all events for the default tenant. This unblocks the westside-landing public schedule page refactor. ## Changes - `src/basketball_api/routes/public.py` -- Added `GET /schedule` endpoint following the existing `/teams` and `/coaches` pattern (hardcoded tenant_id=1, no auth). Imports and reuses `CombinedScheduleResponse`, `_practice_to_response`, and `_event_to_response` from `routes/schedule.py` for frontend compatibility. Only active practices (`is_active=True`) are returned; all events are returned for frontend display filtering. ## Test Plan - `pytest tests/test_public.py tests/test_schedule.py -v` -- all 60 tests pass - Full suite: 562 passed (2 pre-existing failures unrelated to this change, 152 errors from tests requiring running Postgres service containers) - Verify: `curl /public/schedule` returns `{ practices: [...], events: [...] }` with no auth - Verify: inactive practices are excluded from response ## Review Checklist - [x] Only modifies `routes/public.py` -- no model or admin endpoint changes - [x] Follows existing public route pattern (tenant_id=1, no auth) - [x] Reuses schedule response schemas per issue instructions - [x] `ruff format` and `ruff check` pass - [x] All existing tests pass ## Related Closes #239 - Blocks: `forgejo_admin/westside-landing#172` (public schedule page refactor) - Depends on: #232 (data model), #233 (admin endpoints) -- both merged ## Related Notes - None

forgejo_admin added 1 commit

2026-03-29 04:02:32 +00:00

feat: add GET /public/schedule endpoint for unauthenticated schedule access

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

03637355a9

Returns combined practices (active only) and events for the default
tenant, matching the admin schedule response shape for frontend
compatibility. Follows the existing /public/teams and /public/coaches
pattern with no auth required.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-29 04:03:18 +00:00

Author

Contributor

QA Review -- PR #241

Acceptance Criteria Check

Criteria	Status
`GET /public/schedule` returns `{ practices: [...], events: [...] }`	PASS -- uses `CombinedScheduleResponse`
No authentication required	PASS -- no auth dependency injected
Only active practices returned (`is_active=true`)	PASS -- `.filter(PracticeSchedule.is_active.is_(True))`
Response shape matches admin schedule endpoint	PASS -- reuses `CombinedScheduleResponse`, `_practice_to_response`, `_event_to_response`
Existing tests pass	PASS -- 60/60 public+schedule tests pass

Code Quality

Follows existing /public/teams and /public/coaches pattern (hardcoded tenant_id=1, no auth)
Reuses Pydantic schemas and helpers from routes/schedule.py per issue instructions
Practices ordered by day_of_week, start_time; events ordered by start_date -- consistent with admin endpoint
Single file changed (routes/public.py), 42 additions, 1 deletion -- minimal scope
ruff format and ruff check pass

Observations (non-blocking)

The PracticeScheduleResponse.is_active field will always be True in public responses since we filter. This is intentional for frontend schema compatibility and not a concern.
No new tests added for the public schedule endpoint. The issue acceptance criteria say "Existing tests still pass" which is met. New tests could be added as follow-up work.

VERDICT: APPROVED

## QA Review -- PR #241 ### Acceptance Criteria Check | Criteria | Status | |----------|--------| | `GET /public/schedule` returns `{ practices: [...], events: [...] }` | PASS -- uses `CombinedScheduleResponse` | | No authentication required | PASS -- no auth dependency injected | | Only active practices returned (`is_active=true`) | PASS -- `.filter(PracticeSchedule.is_active.is_(True))` | | Response shape matches admin schedule endpoint | PASS -- reuses `CombinedScheduleResponse`, `_practice_to_response`, `_event_to_response` | | Existing tests pass | PASS -- 60/60 public+schedule tests pass | ### Code Quality - Follows existing `/public/teams` and `/public/coaches` pattern (hardcoded `tenant_id=1`, no auth) - Reuses Pydantic schemas and helpers from `routes/schedule.py` per issue instructions - Practices ordered by `day_of_week, start_time`; events ordered by `start_date` -- consistent with admin endpoint - Single file changed (`routes/public.py`), 42 additions, 1 deletion -- minimal scope - `ruff format` and `ruff check` pass ### Observations (non-blocking) - The `PracticeScheduleResponse.is_active` field will always be `True` in public responses since we filter. This is intentional for frontend schema compatibility and not a concern. - No new tests added for the public schedule endpoint. The issue acceptance criteria say "Existing tests still pass" which is met. New tests could be added as follow-up work. ### VERDICT: APPROVED