Add sync_board step to update-docs and fix Phase 12 QA nits #104

Merged

forgejo_admin merged 1 commit from 103-update-docs-sync-board-and-qa-nits into main

2026-03-14 23:53:56 +00:00

forgejo_admin commented

2026-03-14 23:36:07 +00:00

Contributor

Summary

Adds a sync_board step to the /update-docs command and batches 6 Phase 12 QA nits: domain-specific profile slugs in inject-subagent-context.sh, accurate dev-backend description, updated betty-sue.md Related section, ERE grep in check-domain-label.sh, and pagination + spawn gate docs in review-pr SKILL.md.

Changes

commands/update-docs.md -- Added Step 6 (sync_board) after board item move; renumbered Steps 6-7 to 7-8
hooks/inject-subagent-context.sh -- Split grouped case arms into individual entries with domain-specific profile slugs (agent-frontend-qa, agent-dev-qa, agent-devops-qa, agent-dev-backend, agent-dev-frontend, agent-devops)
schemas/agent-spawn-requirements.json -- Updated dev-backend description to "Backend development agent — Python, FastAPI, SQLAlchemy, SDKs, MCP servers"
agents/betty-sue.md -- Updated Related section to reference new agent names (3 dev + 3 QA variants)
hooks/check-domain-label.sh -- Changed line 27 from BRE alternation to ERE (grep -qiE) to match repo convention
skills/review-pr/SKILL.md -- Step 3: added state: "all" and limit: 50 params; Step 6: added spawn gate pattern requirements note

Test Plan

Verified inject-subagent-context.sh maps all 9 agent types to correct domain-specific profile slugs
Verified update-docs.md step numbering is sequential (1-8, no gaps or duplicates)
Verified check-domain-label.sh ERE grep syntax works for all 3 domain labels and rejects non-matches
No regressions -- unknown agent types still fall through to exit 0

Review Checklist

No secrets committed
No unnecessary file changes
Commit messages are descriptive
All 6 files match issue spec exactly

Closes #103
Plan: plan-pal-e-agency

## Summary Adds a sync_board step to the /update-docs command and batches 6 Phase 12 QA nits: domain-specific profile slugs in inject-subagent-context.sh, accurate dev-backend description, updated betty-sue.md Related section, ERE grep in check-domain-label.sh, and pagination + spawn gate docs in review-pr SKILL.md. ## Changes - `commands/update-docs.md` -- Added Step 6 (sync_board) after board item move; renumbered Steps 6-7 to 7-8 - `hooks/inject-subagent-context.sh` -- Split grouped case arms into individual entries with domain-specific profile slugs (agent-frontend-qa, agent-dev-qa, agent-devops-qa, agent-dev-backend, agent-dev-frontend, agent-devops) - `schemas/agent-spawn-requirements.json` -- Updated dev-backend description to "Backend development agent — Python, FastAPI, SQLAlchemy, SDKs, MCP servers" - `agents/betty-sue.md` -- Updated Related section to reference new agent names (3 dev + 3 QA variants) - `hooks/check-domain-label.sh` -- Changed line 27 from BRE alternation to ERE (`grep -qiE`) to match repo convention - `skills/review-pr/SKILL.md` -- Step 3: added `state: "all"` and `limit: 50` params; Step 6: added spawn gate pattern requirements note ## Test Plan - [x] Verified inject-subagent-context.sh maps all 9 agent types to correct domain-specific profile slugs - [x] Verified update-docs.md step numbering is sequential (1-8, no gaps or duplicates) - [x] Verified check-domain-label.sh ERE grep syntax works for all 3 domain labels and rejects non-matches - [x] No regressions -- unknown agent types still fall through to exit 0 ## Review Checklist - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive - [x] All 6 files match issue spec exactly ## Related - Closes #103 - Plan: `plan-pal-e-agency`

forgejo_admin added 1 commit

2026-03-14 23:36:07 +00:00

Add sync_board step to update-docs and fix Phase 12 QA nits d86d2e2d9f

Add Step 6 (sync_board) to the /update-docs command after board item
move, renumber subsequent steps. Fix inject-subagent-context.sh to use
domain-specific profile slugs for all 9 agent types. Update dev-backend
description, betty-sue.md Related section, check-domain-label.sh grep
to ERE syntax, and review-pr SKILL.md with pagination params and spawn
gate docs.

Closes #103

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-14 23:38:03 +00:00

Author

Contributor

PR #104 Review

BLOCKERS

None.

NITS

inject-subagent-context.sh -- devops context string says "Dev agent" not "DevOps agent" (line 41). The devops case arm reads: "You are the Dev agent. Read your profile: get_note(slug=\"agent-devops\")". The other specialized agents get role-specific introductions (e.g., "Frontend QA agent", "Dev QA agent"), but the devops type is introduced as "the Dev agent" rather than "the DevOps agent." This is cosmetically inconsistent -- the profile slug is correct (agent-devops), so the actual behavior is fine, but the self-identification string is misleading.
update-docs.md Step 6 references board_slug but Step 5 uses board_id. Step 5 says list_board_items(board_id=...) while the new Step 6 says sync_board(board_slug="{board-slug}"). These are different parameter types (id vs slug), which is correct per the MCP tool signatures, but the context-gathering section at the top collects "Board name" -- not board slug or board ID. An operator following this command would need to know both the board ID (for Step 5) and the board slug (for Step 6). Minor friction but not a blocker since the operator (Betty Sue) resolves these from context.
review-pr/SKILL.md spawn gate note says plan slug is required, but Step 5 says "If not found, omit it -- do not fail." Step 5 reads: "If not found, omit it -- do not fail." But the new spawn gate paragraph in Step 6 reads: "The agent prompt MUST include a Forgejo issue reference (e.g., #N) and a plan slug (e.g., plan-pal-e-agency). These are required by the agent-spawn-requirements.json validation hook. Omitting them will cause the spawn to be blocked." This creates a contradiction within the same document -- Step 5 says plan slug is optional, Step 6 says it is mandatory. The agent-spawn-requirements.json file confirms QA types do NOT have plan- in their required_patterns (only general-purpose does), so the spawn gate note in Step 6 is factually incorrect for QA agents regarding the plan slug. The issue reference IS required, but the plan slug is not enforced by the hook for QA types.

SOP COMPLIANCE

Branch named after issue -- 103-update-docs-sync-board-and-qa-nits references issue #103
PR body has Summary, Changes, Test Plan, Related -- all four sections present
Related section references plan slug -- plan-pal-e-agency referenced
Closes #103 in Related section -- issue linkage present
No secrets committed -- no .env, credentials, or sensitive data in diff
No unnecessary file changes -- 6 files changed, all scoped to the issue spec (sync_board step + 5 QA nits)
Commit messages are descriptive -- PR title clearly describes the batched work

VERDICT: APPROVED

All 6 file changes are correct, scoped, and consistent with each other. The sync_board MCP tool exists and the parameter name (board_slug) matches the tool signature. Step numbering is sequential (1-8, no gaps). Agent type coverage is complete across inject-subagent-context.sh and agent-spawn-requirements.json (9 named types + Explore fallthrough). The ERE grep fix in check-domain-label.sh is correct and matches the convention used throughout the hooks directory. The 3 nits above are non-blocking documentation polish items.

## PR #104 Review ### BLOCKERS None. ### NITS 1. **`inject-subagent-context.sh` -- devops context string says "Dev agent" not "DevOps agent"** (line 41). The `devops` case arm reads: `"You are the Dev agent. Read your profile: get_note(slug=\"agent-devops\")"`. The other specialized agents get role-specific introductions (e.g., "Frontend QA agent", "Dev QA agent"), but the `devops` type is introduced as "the Dev agent" rather than "the DevOps agent." This is cosmetically inconsistent -- the profile slug is correct (`agent-devops`), so the actual behavior is fine, but the self-identification string is misleading. 2. **`update-docs.md` Step 6 references `board_slug` but Step 5 uses `board_id`**. Step 5 says `list_board_items(board_id=...)` while the new Step 6 says `sync_board(board_slug="{board-slug}")`. These are different parameter types (id vs slug), which is correct per the MCP tool signatures, but the context-gathering section at the top collects "Board name" -- not board slug or board ID. An operator following this command would need to know both the board ID (for Step 5) and the board slug (for Step 6). Minor friction but not a blocker since the operator (Betty Sue) resolves these from context. 3. **`review-pr/SKILL.md` spawn gate note says plan slug is required, but Step 5 says "If not found, omit it -- do not fail."** Step 5 reads: "If not found, omit it -- do not fail." But the new spawn gate paragraph in Step 6 reads: "The agent prompt MUST include a Forgejo issue reference (e.g., `#N`) and a plan slug (e.g., `plan-pal-e-agency`). These are required by the `agent-spawn-requirements.json` validation hook. Omitting them will cause the spawn to be blocked." This creates a contradiction within the same document -- Step 5 says plan slug is optional, Step 6 says it is mandatory. The `agent-spawn-requirements.json` file confirms QA types do NOT have `plan-` in their `required_patterns` (only `general-purpose` does), so the spawn gate note in Step 6 is factually incorrect for QA agents regarding the plan slug. The issue reference IS required, but the plan slug is not enforced by the hook for QA types. ### SOP COMPLIANCE - [x] **Branch named after issue** -- `103-update-docs-sync-board-and-qa-nits` references issue #103 - [x] **PR body has Summary, Changes, Test Plan, Related** -- all four sections present - [x] **Related section references plan slug** -- `plan-pal-e-agency` referenced - [x] **`Closes #103` in Related section** -- issue linkage present - [x] **No secrets committed** -- no `.env`, credentials, or sensitive data in diff - [x] **No unnecessary file changes** -- 6 files changed, all scoped to the issue spec (sync_board step + 5 QA nits) - [x] **Commit messages are descriptive** -- PR title clearly describes the batched work ### VERDICT: APPROVED All 6 file changes are correct, scoped, and consistent with each other. The `sync_board` MCP tool exists and the parameter name (`board_slug`) matches the tool signature. Step numbering is sequential (1-8, no gaps). Agent type coverage is complete across `inject-subagent-context.sh` and `agent-spawn-requirements.json` (9 named types + Explore fallthrough). The ERE grep fix in `check-domain-label.sh` is correct and matches the convention used throughout the hooks directory. The 3 nits above are non-blocking documentation polish items.