fix: Phase 16 QA nits — Penny SubagentStart matcher + betty-sue.md Related #120

New issue

Closed

opened 2026-03-17 03:33:41 +00:00 by forgejo_admin · 1 comment

forgejo_admin commented

2026-03-17 03:33:41 +00:00

Contributor

Lineage

todo-phase-16-qa-nits (no plan ancestry — QA nit cleanup from PR #119)

Repo

forgejo_admin/claude-custom

User Story

As the platform operator
I want the SubagentStart hook matcher to include penny and betty-sue.md's Related section to reflect the current 5-agent model
So that Penny agent spawns get proper session context injection and docs stay accurate

Context

PR #119 (Phase 16: Agent Model Completion) was approved and merged. QA flagged two non-blocking nits that need cleanup:

The SubagentStart matcher in settings.json doesn't include penny, meaning Penny spawns won't get injected session context
betty-sue.md's Related section still references the deprecated 6-agent split (dev-frontend, dev-backend, devops, frontend-qa, dev-qa, devops-qa) instead of the consolidated 5-agent model

File Targets

Files to modify:

settings.json line 232 — add penny to the SubagentStart matcher regex: "qa|dev|dev-backend|dev-frontend|devops|frontend-qa|dev-qa|devops-qa|general-purpose|dottie" → add |penny
agents/betty-sue.md lines 73-76 — replace deprecated agent references with 5-agent model (Betty Sue, Penny, Dev, QA, Dottie)

Files NOT to touch:

hooks/inject-subagent-context.sh — the hook itself is correct, only the matcher needs updating
Any other agent definition files

Acceptance Criteria

penny appears in the SubagentStart matcher in settings.json
agents/betty-sue.md Related section references the 5-agent model: Betty Sue, Penny, Dev, QA, Dottie
No references to deprecated agent names (dev-frontend, dev-backend, devops, frontend-qa, dev-qa, devops-qa) in the Related section
No other files modified

Test Expectations

Manual: grep -c penny settings.json returns at least 1
Manual: grep -c 'dev-frontend' agents/betty-sue.md returns 0
Run command: jq '.hooks.SubagentStart[0].matcher' settings.json — output should contain penny

Constraints

Clone to /tmp/claude-custom-{branch} — never work in ~/claude-custom directly
Keep the deprecated agent types in the SubagentStart matcher for backward compatibility (they're harmless)
Do NOT access pal-e-docs

Checklist

PR opened
No unrelated changes

project-pal-e-agency — project this affects
PR #119 — the PR that introduced these nits

### Lineage `todo-phase-16-qa-nits` (no plan ancestry — QA nit cleanup from PR #119) ### Repo `forgejo_admin/claude-custom` ### User Story As the platform operator I want the SubagentStart hook matcher to include `penny` and betty-sue.md's Related section to reflect the current 5-agent model So that Penny agent spawns get proper session context injection and docs stay accurate ### Context PR #119 (Phase 16: Agent Model Completion) was approved and merged. QA flagged two non-blocking nits that need cleanup: 1. The SubagentStart matcher in settings.json doesn't include `penny`, meaning Penny spawns won't get injected session context 2. betty-sue.md's Related section still references the deprecated 6-agent split (dev-frontend, dev-backend, devops, frontend-qa, dev-qa, devops-qa) instead of the consolidated 5-agent model ### File Targets Files to modify: - `settings.json` line 232 — add `penny` to the SubagentStart matcher regex: `"qa|dev|dev-backend|dev-frontend|devops|frontend-qa|dev-qa|devops-qa|general-purpose|dottie"` → add `|penny` - `agents/betty-sue.md` lines 73-76 — replace deprecated agent references with 5-agent model (Betty Sue, Penny, Dev, QA, Dottie) Files NOT to touch: - `hooks/inject-subagent-context.sh` — the hook itself is correct, only the matcher needs updating - Any other agent definition files ### Acceptance Criteria - [ ] `penny` appears in the SubagentStart matcher in `settings.json` - [ ] `agents/betty-sue.md` Related section references the 5-agent model: Betty Sue, Penny, Dev, QA, Dottie - [ ] No references to deprecated agent names (dev-frontend, dev-backend, devops, frontend-qa, dev-qa, devops-qa) in the Related section - [ ] No other files modified ### Test Expectations - [ ] Manual: `grep -c penny settings.json` returns at least 1 - [ ] Manual: `grep -c 'dev-frontend' agents/betty-sue.md` returns 0 - Run command: `jq '.hooks.SubagentStart[0].matcher' settings.json` — output should contain `penny` ### Constraints - Clone to `/tmp/claude-custom-{branch}` — never work in `~/claude-custom` directly - Keep the deprecated agent types in the SubagentStart matcher for backward compatibility (they're harmless) - Do NOT access pal-e-docs ### Checklist - [ ] PR opened - [ ] No unrelated changes ### Related - `project-pal-e-agency` — project this affects - PR #119 — the PR that introduced these nits