ldraney/claude-custom
1
0
Fork 0
Code Issues 32 Pull requests Projects Releases Packages Wiki Activity Actions

fix: add penny to SubagentStart matcher + update betty-sue.md Related #121

Merged
forgejo_admin merged 1 commit from 120-phase-16-qa-nits into main 2026-03-17 03:57:44 +00:00
Conversation 1 Commits 1 Files changed 2 +5 -3
forgejo_admin commented 2026-03-17 03:35:45 +00:00
Contributor
Copy link

Summary

QA nits from PR #119 (Phase 16: Agent Model Completion). Penny agent spawns were missing session context injection because the SubagentStart matcher didn't include penny. Also updates betty-sue.md Related section from the deprecated 6-agent split to the consolidated 5-agent model.

Changes

  • settings.json — added |penny to the SubagentStart matcher regex so Penny spawns get injected session context
  • agents/betty-sue.md — replaced deprecated agent references (dev-frontend, dev-backend, devops, frontend-qa, dev-qa, devops-qa) with the 5-agent model (Penny, Dev, QA, Dottie) in the Related section

Test Plan

  • grep -c penny settings.json returns 1
  • grep -c 'dev-frontend' agents/betty-sue.md returns 0
  • jq '.hooks.SubagentStart[0].matcher' settings.json output contains penny
  • Deprecated agent types kept in SubagentStart matcher for backward compatibility (per issue constraints)

Review Checklist

  • Only 2 files modified (settings.json, agents/betty-sue.md)
  • No unrelated changes
  • Backward compatibility preserved (deprecated agent types kept in matcher)
  • All acceptance criteria from issue #120 verified

Related

  • Plan: todo-phase-16-qa-nits
  • Forgejo issue: #120
  • Parent PR: #119
  • Closes #120
## Summary QA nits from PR #119 (Phase 16: Agent Model Completion). Penny agent spawns were missing session context injection because the SubagentStart matcher didn't include `penny`. Also updates betty-sue.md Related section from the deprecated 6-agent split to the consolidated 5-agent model. ## Changes - `settings.json` — added `|penny` to the SubagentStart matcher regex so Penny spawns get injected session context - `agents/betty-sue.md` — replaced deprecated agent references (dev-frontend, dev-backend, devops, frontend-qa, dev-qa, devops-qa) with the 5-agent model (Penny, Dev, QA, Dottie) in the Related section ## Test Plan - `grep -c penny settings.json` returns 1 - `grep -c 'dev-frontend' agents/betty-sue.md` returns 0 - `jq '.hooks.SubagentStart[0].matcher' settings.json` output contains `penny` - Deprecated agent types kept in SubagentStart matcher for backward compatibility (per issue constraints) ## Review Checklist - [x] Only 2 files modified (settings.json, agents/betty-sue.md) - [x] No unrelated changes - [x] Backward compatibility preserved (deprecated agent types kept in matcher) - [x] All acceptance criteria from issue #120 verified ## Related - Plan: `todo-phase-16-qa-nits` - Forgejo issue: #120 - Parent PR: #119 - Closes #120
QA nits from PR #119: Penny agent spawns were missing session context
injection because the SubagentStart matcher didn't include `penny`.
Also updates betty-sue.md Related section from deprecated 6-agent split
to the consolidated 5-agent model (Betty Sue, Penny, Dev, QA, Dottie).

Closes #120

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-03-17 03:37:42 +00:00
Author
Contributor
Copy link

PR #121 Review

DOMAIN REVIEW

Tech stack: Claude Code configuration (JSON hook settings + Markdown agent profiles). No application code -- this is agent infrastructure.

settings.json -- SubagentStart matcher:
The change appends |penny to the existing regex matcher at line 232. The penny value matches the frontmatter name: penny in agents/penny.md (confirmed). Without this fix, Penny spawns would not trigger inject-subagent-context.sh, meaning she would start sessions without platform context injection. This is a genuine bug fix from the PR #119 oversight.

Backward compatibility is preserved: all deprecated agent types (dev-backend, dev-frontend, devops, frontend-qa, dev-qa, devops-qa) remain in the matcher, which is correct per the issue constraints.

agents/betty-sue.md -- Related section:
The old Related section listed 6 deprecated agent references (dev-frontend, dev-backend, devops, frontend-qa, dev-qa, devops-qa) that no longer exist as separate agent files. The replacement references the actual 5-agent model: agent-penny, agent-dev, agent-qa, agent-dottie. Confirmed all four agent files exist in agents/ with matching names. The agent-workflow and agent-spawn-conventions lines are preserved unchanged.

No issues found in the domain review.

BLOCKERS

None.

  • No new functionality requiring test coverage (config fix + doc update)
  • No user input to validate
  • No secrets or credentials in code
  • No DRY violations

NITS

None. The diff is 5 additions / 3 deletions across 2 files. Both changes are precise and scoped.

SOP COMPLIANCE

  • Branch named after issue (120-phase-16-qa-nits references issue #120)
  • PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related -- all present)
  • Related section references plan slug (todo-phase-16-qa-nits)
  • Related references parent issue (#120) and parent PR (#119)
  • No secrets committed
  • No unnecessary file changes (exactly 2 files, both in scope)
  • Commit message is descriptive (PR title: fix: add penny to SubagentStart matcher + update betty-sue.md Related)

PROCESS OBSERVATIONS

This is a well-executed nit-fix PR from the Phase 16 QA cycle. The QA-to-nit-fix pipeline is working as designed: PR #119 was reviewed, nits were captured, issue #120 was created, and this PR addresses them cleanly. Low change failure risk given the minimal surface area (one regex addition, one doc section rewrite).

VERDICT: APPROVED

## PR #121 Review ### DOMAIN REVIEW **Tech stack:** Claude Code configuration (JSON hook settings + Markdown agent profiles). No application code -- this is agent infrastructure. **settings.json -- SubagentStart matcher:** The change appends `|penny` to the existing regex matcher at line 232. The `penny` value matches the frontmatter `name: penny` in `agents/penny.md` (confirmed). Without this fix, Penny spawns would not trigger `inject-subagent-context.sh`, meaning she would start sessions without platform context injection. This is a genuine bug fix from the PR #119 oversight. Backward compatibility is preserved: all deprecated agent types (`dev-backend`, `dev-frontend`, `devops`, `frontend-qa`, `dev-qa`, `devops-qa`) remain in the matcher, which is correct per the issue constraints. **agents/betty-sue.md -- Related section:** The old Related section listed 6 deprecated agent references (`dev-frontend`, `dev-backend`, `devops`, `frontend-qa`, `dev-qa`, `devops-qa`) that no longer exist as separate agent files. The replacement references the actual 5-agent model: `agent-penny`, `agent-dev`, `agent-qa`, `agent-dottie`. Confirmed all four agent files exist in `agents/` with matching names. The `agent-workflow` and `agent-spawn-conventions` lines are preserved unchanged. No issues found in the domain review. ### BLOCKERS None. - No new functionality requiring test coverage (config fix + doc update) - No user input to validate - No secrets or credentials in code - No DRY violations ### NITS None. The diff is 5 additions / 3 deletions across 2 files. Both changes are precise and scoped. ### SOP COMPLIANCE - [x] Branch named after issue (`120-phase-16-qa-nits` references issue #120) - [x] PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related -- all present) - [x] Related section references plan slug (`todo-phase-16-qa-nits`) - [x] Related references parent issue (#120) and parent PR (#119) - [x] No secrets committed - [x] No unnecessary file changes (exactly 2 files, both in scope) - [x] Commit message is descriptive (PR title: `fix: add penny to SubagentStart matcher + update betty-sue.md Related`) ### PROCESS OBSERVATIONS This is a well-executed nit-fix PR from the Phase 16 QA cycle. The QA-to-nit-fix pipeline is working as designed: PR #119 was reviewed, nits were captured, issue #120 was created, and this PR addresses them cleanly. Low change failure risk given the minimal surface area (one regex addition, one doc section rewrite). ### VERDICT: APPROVED
forgejo_admin deleted branch 120-phase-16-qa-nits 2026-03-17 03:57:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/claude-custom!121
No description provided.