Add Nit-Bundle type to check-issue-template.sh hook #137

New issue

Closed

opened 2026-03-21 17:01:16 +00:00 by forgejo_admin · 1 comment

forgejo_admin commented

2026-03-21 17:01:16 +00:00

Contributor

Type

Feature

Lineage

plan-pal-e-agency → Phase 18 → 18c

Repo

forgejo_admin/claude-custom

User Story

As Betty Sue, when I create a Nit-Bundle Forgejo issue during /update-docs, the hook validates it against template-issue-nit-bundle instead of falling through to the feature template (which has wrong headings and would deny).

Context

Phase 18 added Nit-Bundle as a 4th issue type (template-issue-nit-bundle created in pal-e-docs). The check-issue-template.sh hook's case statement (line 33-37) currently maps unrecognized ### Type values to template-issue-feature via the * fallback. A ### Type\nNit-Bundle issue would be validated against the feature template's required headings (Lineage, Repo, User Story, etc.) and be denied because the nit-bundle template has different headings (Source, Original Work, Nits, etc.).

File Targets

Files the agent should modify:

hooks/check-issue-template.sh — add Nit-Bundle|nit-bundle case before the * fallback (line 33-37)

Files the agent should NOT touch:

Any other hook files
Any template notes (already created in pal-e-docs)

Acceptance Criteria

Creating a Forgejo issue with ### Type\nNit-Bundle validates against template-issue-nit-bundle
Existing types (Bug, Feature, Spike) still validate correctly (no regression)
Default fallback * still maps to feature template

Test Expectations

Manual test: create a test issue body with ### Type\nNit-Bundle and the nit-bundle template headings — hook should allow
Manual test: create a test issue body with ### Type\nNit-Bundle but MISSING required headings — hook should deny with reference to template-issue-nit-bundle

Constraints

Match existing case statement pattern exactly
One line addition, no refactoring

Checklist

PR opened
Tests pass
No unrelated changes

phase-pal-e-agency-18-enterprise-definitions — parent phase
template-issue-nit-bundle — the template this enables
glossary — nit definition

### Type Feature ### Lineage `plan-pal-e-agency` → Phase 18 → 18c ### Repo `forgejo_admin/claude-custom` ### User Story As Betty Sue, when I create a Nit-Bundle Forgejo issue during `/update-docs`, the hook validates it against `template-issue-nit-bundle` instead of falling through to the feature template (which has wrong headings and would deny). ### Context Phase 18 added Nit-Bundle as a 4th issue type (`template-issue-nit-bundle` created in pal-e-docs). The `check-issue-template.sh` hook's case statement (line 33-37) currently maps unrecognized `### Type` values to `template-issue-feature` via the `*` fallback. A `### Type\nNit-Bundle` issue would be validated against the feature template's required headings (Lineage, Repo, User Story, etc.) and be denied because the nit-bundle template has different headings (Source, Original Work, Nits, etc.). ### File Targets Files the agent should modify: - `hooks/check-issue-template.sh` — add `Nit-Bundle|nit-bundle` case before the `*` fallback (line 33-37) Files the agent should NOT touch: - Any other hook files - Any template notes (already created in pal-e-docs) ### Acceptance Criteria - [ ] Creating a Forgejo issue with `### Type\nNit-Bundle` validates against `template-issue-nit-bundle` - [ ] Existing types (Bug, Feature, Spike) still validate correctly (no regression) - [ ] Default fallback `*` still maps to feature template ### Test Expectations - [ ] Manual test: create a test issue body with `### Type\nNit-Bundle` and the nit-bundle template headings — hook should allow - [ ] Manual test: create a test issue body with `### Type\nNit-Bundle` but MISSING required headings — hook should deny with reference to `template-issue-nit-bundle` ### Constraints - Match existing case statement pattern exactly - One line addition, no refactoring ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `phase-pal-e-agency-18-enterprise-definitions` — parent phase - `template-issue-nit-bundle` — the template this enables - `glossary` — nit definition