Nit-bundle: PR #139 — hook header comment + alignment #141

New issue

Open

opened 2026-03-21 17:30:09 +00:00 by forgejo_admin · 0 comments

forgejo_admin commented

2026-03-21 17:30:09 +00:00

Contributor

Type

Nit-Bundle

Source

PR #139 on forgejo_admin/claude-custom — QA verdict: APPROVED with nits
QA agent review: PR #139 comment

Original Work

plan-pal-e-agency → Phase 18 → 18c → Forgejo Issue #137

Nits

Stale header comment — File header (lines 5-8) lists Bug/Feature/Spike but not Nit-Bundle. Should include all 4 types.
Alignment inconsistency — Bug|bug) line was not re-aligned to match the new column width applied to Spike and Nit-Bundle cases.
Missing plan slug in PR Related — PR body's Related section didn't reference plan-pal-e-agency. Process gap in dev agent prompt, not a code fix.

Segmentation Notes

All 3 nits are in the same file (hooks/check-issue-template.sh) and can be addressed in a single PR. Nit #3 is a process gap (dev agent prompt), not a code change — note for future agent prompts but no code fix needed.

Acceptance Criteria

Header comment at lines 5-8 lists all 4 types: Bug, Feature, Spike, Nit-Bundle
All case statement lines aligned consistently
No regression in hook behavior

plan-pal-e-agency — parent plan
phase-pal-e-agency-18-enterprise-definitions — parent phase
forgejo_admin/claude-custom #137 — original issue
forgejo_admin/claude-custom #139 — the PR where nits were identified

### Type Nit-Bundle ### Source PR #139 on `forgejo_admin/claude-custom` — QA verdict: APPROVED with nits QA agent review: PR #139 comment ### Original Work `plan-pal-e-agency` → Phase 18 → 18c → Forgejo Issue #137 ### Nits 1. **Stale header comment** — File header (lines 5-8) lists Bug/Feature/Spike but not Nit-Bundle. Should include all 4 types. 2. **Alignment inconsistency** — `Bug|bug)` line was not re-aligned to match the new column width applied to Spike and Nit-Bundle cases. 3. **Missing plan slug in PR Related** — PR body's Related section didn't reference `plan-pal-e-agency`. Process gap in dev agent prompt, not a code fix. ### Segmentation Notes All 3 nits are in the same file (`hooks/check-issue-template.sh`) and can be addressed in a single PR. Nit #3 is a process gap (dev agent prompt), not a code change — note for future agent prompts but no code fix needed. ### Acceptance Criteria - [ ] Header comment at lines 5-8 lists all 4 types: Bug, Feature, Spike, Nit-Bundle - [ ] All case statement lines aligned consistently - [ ] No regression in hook behavior ### Related - `plan-pal-e-agency` — parent plan - `phase-pal-e-agency-18-enterprise-definitions` — parent phase - `forgejo_admin/claude-custom #137` — original issue - `forgejo_admin/claude-custom #139` — the PR where nits were identified