cleanup: remove deprecated agent profile files from agents/ #158

Merged
forgejo_admin merged 1 commit from 131-remove-deprecated-agents into main 2026-03-26 03:47:17 +00:00
Contributor

Summary

Remove 8 deprecated agent profile markdown files from agents/. Phase 12 of plan-pal-e-agency consolidated to a 5-agent model (dev, qa, dottie, penny, betty-sue). PRs #125 and #128 removed all code references to the specialized agent types but left the profile files behind.

Changes

  • Deleted agents/dev-backend.md.deprecated -- old specialized backend dev agent
  • Deleted agents/dev-frontend.md.deprecated -- old specialized frontend dev agent
  • Deleted agents/devops.md.deprecated -- old specialized devops agent
  • Deleted agents/dev-qa.md.deprecated -- old specialized dev QA agent
  • Deleted agents/frontend-qa.md.deprecated -- old specialized frontend QA agent
  • Deleted agents/devops-qa.md.deprecated -- old specialized devops QA agent
  • Deleted agents/dev.md.deprecated -- old version of dev profile (replaced by current dev.md)
  • Deleted agents/qa.md.deprecated -- old version of QA profile (replaced by current qa.md)

Test Plan

  • Verified grep for deprecated agent slugs (dev-backend, dev-frontend, devops, dev-qa, frontend-qa, devops-qa) in agents/ returns zero matches
  • Verified grep for .deprecated in agents/ returns zero matches
  • Verified remaining files are exactly the 5 active agents: betty-sue.md, dev.md, dottie.md, penny.md, qa.md
  • No code references these files (confirmed via repo-wide grep)

Review Checklist

  • Only deletions, no modifications to active agent profiles
  • All 8 deprecated files removed
  • No unrelated changes
  • Branch named after issue number
  • Closes #131
  • plan-pal-e-agency -- Phase 12 deprecated the specialized agents
  • PR #125 -- schema cleanup
  • PR #128 -- hooks/settings cleanup
## Summary Remove 8 deprecated agent profile markdown files from `agents/`. Phase 12 of plan-pal-e-agency consolidated to a 5-agent model (dev, qa, dottie, penny, betty-sue). PRs #125 and #128 removed all code references to the specialized agent types but left the profile files behind. ## Changes - Deleted `agents/dev-backend.md.deprecated` -- old specialized backend dev agent - Deleted `agents/dev-frontend.md.deprecated` -- old specialized frontend dev agent - Deleted `agents/devops.md.deprecated` -- old specialized devops agent - Deleted `agents/dev-qa.md.deprecated` -- old specialized dev QA agent - Deleted `agents/frontend-qa.md.deprecated` -- old specialized frontend QA agent - Deleted `agents/devops-qa.md.deprecated` -- old specialized devops QA agent - Deleted `agents/dev.md.deprecated` -- old version of dev profile (replaced by current `dev.md`) - Deleted `agents/qa.md.deprecated` -- old version of QA profile (replaced by current `qa.md`) ## Test Plan - Verified grep for deprecated agent slugs (`dev-backend`, `dev-frontend`, `devops`, `dev-qa`, `frontend-qa`, `devops-qa`) in `agents/` returns zero matches - Verified grep for `.deprecated` in `agents/` returns zero matches - Verified remaining files are exactly the 5 active agents: `betty-sue.md`, `dev.md`, `dottie.md`, `penny.md`, `qa.md` - No code references these files (confirmed via repo-wide grep) ## Review Checklist - [x] Only deletions, no modifications to active agent profiles - [x] All 8 deprecated files removed - [x] No unrelated changes - [x] Branch named after issue number ## Related - Closes #131 - `plan-pal-e-agency` -- Phase 12 deprecated the specialized agents - PR #125 -- schema cleanup - PR #128 -- hooks/settings cleanup
Phase 12 of plan-pal-e-agency consolidated to a 5-agent model.
PRs #125 and #128 removed all code references to the specialized
agent types but left the profile markdown files. This removes the
dead files so the repo reflects the current agent model.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
Contributor

PR #158 Review

BLOCKERS

None.

NITS

  • The issue listed 6 files using old agent-* naming, but the repo actually had 8 .deprecated files (including dev.md.deprecated and qa.md.deprecated -- old versions of the current active profiles). Deleting all 8 is correct and stays within the issue's intent.

SOP COMPLIANCE

  • Branch named after issue (131-remove-deprecated-agents)
  • PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related)
  • Closes #131 present for auto-close
  • No secrets committed
  • No unrelated changes -- deletions only
  • Commit message is descriptive

VERDICT: APPROVED

## PR #158 Review ### BLOCKERS None. ### NITS - The issue listed 6 files using old `agent-*` naming, but the repo actually had 8 `.deprecated` files (including `dev.md.deprecated` and `qa.md.deprecated` -- old versions of the current active profiles). Deleting all 8 is correct and stays within the issue's intent. ### SOP COMPLIANCE - [x] Branch named after issue (`131-remove-deprecated-agents`) - [x] PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related) - [x] `Closes #131` present for auto-close - [x] No secrets committed - [x] No unrelated changes -- deletions only - [x] Commit message is descriptive ### VERDICT: APPROVED
Author
Contributor

PR #158 Review

DOMAIN REVIEW

This is a pure file-deletion PR in a Claude Code configuration repo (shell hooks, JSON schemas, markdown agent profiles). The domain is agent configuration management.

Deletion inventory verified (8 files, 739 lines removed, 0 lines added):

  • agents/dev-backend.md.deprecated (76 lines) -- specialized backend dev agent
  • agents/dev-frontend.md.deprecated (92 lines) -- specialized frontend dev agent
  • agents/dev-qa.md.deprecated (106 lines) -- specialized backend QA agent
  • agents/dev.md.deprecated (76 lines) -- old version of unified dev agent
  • agents/devops-qa.md.deprecated (109 lines) -- specialized devops QA agent
  • agents/devops.md.deprecated (82 lines) -- specialized devops agent
  • agents/frontend-qa.md.deprecated (106 lines) -- specialized frontend QA agent
  • agents/qa.md.deprecated (92 lines) -- old version of unified QA agent

Reference safety verified:

  • settings.json SubagentStart matcher: qa|dev|general-purpose|dottie|penny -- no deprecated types referenced
  • schemas/agent-spawn-requirements.json: defines dev, qa, dottie, general-purpose, Explore, claude-code-guide -- no deprecated types referenced
  • Repo-wide grep for dev-backend, dev-frontend, devops-qa, dev-qa, frontend-qa: matches ONLY in the .deprecated files being deleted
  • Repo-wide grep for .deprecated: zero matches outside the deleted files
  • hooks/ directory: zero references to any deprecated agent type
  • README.md: references agents/ generically and nvim-minion only -- no deprecated agent names
  • Prior cleanup confirmed: PR #125 removed schema references, PR #128 removed hook/settings references

Active agents untouched: betty-sue.md, dev.md, dottie.md, penny.md, qa.md are not modified by this PR.

BLOCKERS

None.

NITS

None. Pure deletion of already-deprecated files with no remaining references. Clean as it gets.

SOP COMPLIANCE

  • Branch named after issue: 131-remove-deprecated-agents references issue #131
  • PR body follows template: Summary, Changes, Test Plan, Review Checklist, Related -- all present
  • Related references context: cites plan-pal-e-agency Phase 12, PR #125, PR #128
  • No secrets committed: pure markdown deletion
  • No scope creep: exactly the 8 deprecated files named in issue #131, nothing else
  • Commit message is descriptive: PR title cleanup: remove deprecated agent profile files from agents/

PROCESS OBSERVATIONS

Low-risk housekeeping change. The deprecated files were already .deprecated-suffixed and unreferenced by any code path after PRs #125 and #128. Merging this completes the agent consolidation from Phase 12 of plan-pal-e-agency. Zero change failure risk -- no runtime behavior is affected.

VERDICT: APPROVED

## PR #158 Review ### DOMAIN REVIEW This is a pure file-deletion PR in a Claude Code configuration repo (shell hooks, JSON schemas, markdown agent profiles). The domain is agent configuration management. **Deletion inventory verified (8 files, 739 lines removed, 0 lines added):** - `agents/dev-backend.md.deprecated` (76 lines) -- specialized backend dev agent - `agents/dev-frontend.md.deprecated` (92 lines) -- specialized frontend dev agent - `agents/dev-qa.md.deprecated` (106 lines) -- specialized backend QA agent - `agents/dev.md.deprecated` (76 lines) -- old version of unified dev agent - `agents/devops-qa.md.deprecated` (109 lines) -- specialized devops QA agent - `agents/devops.md.deprecated` (82 lines) -- specialized devops agent - `agents/frontend-qa.md.deprecated` (106 lines) -- specialized frontend QA agent - `agents/qa.md.deprecated` (92 lines) -- old version of unified QA agent **Reference safety verified:** - `settings.json` SubagentStart matcher: `qa|dev|general-purpose|dottie|penny` -- no deprecated types referenced - `schemas/agent-spawn-requirements.json`: defines `dev`, `qa`, `dottie`, `general-purpose`, `Explore`, `claude-code-guide` -- no deprecated types referenced - Repo-wide grep for `dev-backend`, `dev-frontend`, `devops-qa`, `dev-qa`, `frontend-qa`: matches ONLY in the `.deprecated` files being deleted - Repo-wide grep for `.deprecated`: zero matches outside the deleted files - `hooks/` directory: zero references to any deprecated agent type - `README.md`: references `agents/` generically and `nvim-minion` only -- no deprecated agent names - Prior cleanup confirmed: PR #125 removed schema references, PR #128 removed hook/settings references **Active agents untouched:** `betty-sue.md`, `dev.md`, `dottie.md`, `penny.md`, `qa.md` are not modified by this PR. ### BLOCKERS None. ### NITS None. Pure deletion of already-deprecated files with no remaining references. Clean as it gets. ### SOP COMPLIANCE - [x] Branch named after issue: `131-remove-deprecated-agents` references issue #131 - [x] PR body follows template: Summary, Changes, Test Plan, Review Checklist, Related -- all present - [x] Related references context: cites `plan-pal-e-agency` Phase 12, PR #125, PR #128 - [x] No secrets committed: pure markdown deletion - [x] No scope creep: exactly the 8 deprecated files named in issue #131, nothing else - [x] Commit message is descriptive: PR title `cleanup: remove deprecated agent profile files from agents/` ### PROCESS OBSERVATIONS Low-risk housekeeping change. The deprecated files were already `.deprecated`-suffixed and unreferenced by any code path after PRs #125 and #128. Merging this completes the agent consolidation from Phase 12 of plan-pal-e-agency. Zero change failure risk -- no runtime behavior is affected. ### VERDICT: APPROVED
forgejo_admin deleted branch 131-remove-deprecated-agents 2026-03-26 03:47:17 +00:00
Sign in to join this conversation.
No description provided.