ldraney/claude-custom

Fork 0

Align repo with pal-e-docs: agent profiles, fix symlinks, branch cleanup (#38) #39

Merged

forgejo_admin merged 2 commits from 38-align-repo-with-pal-e-docs-agent-profile into main

2026-03-01 05:29:29 +00:00

forgejo_admin commented

2026-03-01 05:20:11 +00:00

Contributor

Summary

Add agent profile files to agents/ matching their pal-e-docs source notes
Fix broken symlinks from PR #37 (agents/ recreated, commands/ symlink removed)
Delete 17 stale remote branches (all merged)

Changes

agents/betty-sue.md — main session coordinator profile
agents/dev.md — code implementation agent profile
agents/qa.md — PR review agent profile
agents/issue-creator.md — plan-to-issue translator profile
Removed broken ~/.claude/commands symlink (commands/ was deleted in #37, replaced by skills/)
Deleted 17 stale remote branches: master, 13 feature branches, 3 dependabot branches

Test Plan

~/.claude/agents/ symlink resolves to 4 agent profile files
~/.claude/commands symlink removed (no longer broken)
Only main + this PR branch remain on remote
Agent profile content matches pal-e-docs notes

Review Checklist

Passed automated review-fix loop
No secrets committed
No unnecessary file changes
Commit messages are descriptive

Issue #38
project-ai-agency — the AI agency project
project-claude-config — the config project
plan-2026-02-25-agent-profiles — agent profiles plan

## Summary - Add agent profile files to agents/ matching their pal-e-docs source notes - Fix broken symlinks from PR #37 (agents/ recreated, commands/ symlink removed) - Delete 17 stale remote branches (all merged) ## Changes - `agents/betty-sue.md` — main session coordinator profile - `agents/dev.md` — code implementation agent profile - `agents/qa.md` — PR review agent profile - `agents/issue-creator.md` — plan-to-issue translator profile - Removed broken `~/.claude/commands` symlink (commands/ was deleted in #37, replaced by skills/) - Deleted 17 stale remote branches: master, 13 feature branches, 3 dependabot branches ## Test Plan - [x] `~/.claude/agents/` symlink resolves to 4 agent profile files - [x] `~/.claude/commands` symlink removed (no longer broken) - [x] Only `main` + this PR branch remain on remote - [ ] Agent profile content matches pal-e-docs notes ## Review Checklist - [ ] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related Notes - Issue #38 - `project-ai-agency` — the AI agency project - `project-claude-config` — the config project - `plan-2026-02-25-agent-profiles` — agent profiles plan

forgejo_admin added 1 commit

2026-03-01 05:20:11 +00:00

Add agent profile files from pal-e-docs (#38 ) 0abdcf0c77

Recreate agents/ directory with markdown representations of agent
profiles from pal-e-docs. Pal-e-docs is source of truth — these files
are the version-controlled snapshot.

- agents/betty-sue.md — main session coordinator
- agents/dev.md — code implementation agent
- agents/qa.md — PR review agent
- agents/issue-creator.md — plan-to-issue translator

Each file includes a header pointing to its pal-e-docs source note.
Fixes the broken ~/.claude/agents symlink from PR #37.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

forgejo_admin commented

2026-03-01 05:21:03 +00:00

Author

Contributor

PR #39 Review

Reviewer: Agent QA (fresh context)
Plan: plan-2026-02-25-agent-profiles
Issue: #38

BLOCKERS

1. agents/betty-sue.md is missing the "What Betty Sue Is NOT" section

The pal-e-docs source note agent-betty-sue contains a ### What Betty Sue Is NOT section with three bullet points:

Not a yes-woman -- pushes back when something doesn't make sense
Not passive -- proactively identifies gaps, missing docs, and risks
Not robotic -- has a personality, preferences, and cares about the work

This section is absent from the PR file. Since the PR's stated purpose is to mirror pal-e-docs source notes, the file must match. This is the only content discrepancy across all four files.

NITS

1. PR title exceeds 70 characters
The title "Align repo with pal-e-docs: agent profiles, fix symlinks, branch cleanup (#38)" is 82 characters. Convention suggests keeping PR titles under 70 characters. Non-blocking since the title is descriptive and clear.

2. Test Plan has an unchecked item
- [ ] Agent profile content matches pal-e-docs notes is unchecked, which is accurate given the blocker above -- but should be checked once the betty-sue.md discrepancy is resolved.

3. Review Checklist has an unchecked item
- [ ] Passed automated review-fix loop is unchecked. This is the first review round, so this is expected. Non-blocking.

SOP COMPLIANCE

Branch named after issue -- 38-align-repo-with-pal-e-docs-agent-profile starts with issue number 38
PR body follows template-pr-body -- Has all required sections: ## Summary, ## Changes, ## Test Plan, ## Review Checklist, ## Related Notes
Related Notes references plan slug -- plan-2026-02-25-agent-profiles is listed
No secrets committed -- Only markdown files, no .env or credentials
No unnecessary file changes (scope creep) -- PR body mentions symlink fixes and branch cleanup, but the diff only contains the 4 agent profile files (248 additions, 0 deletions). The symlink/branch work was likely done outside the diff (remote branch deletions, symlink changes not tracked in git). The 4 files are all in scope.
Commit messages are descriptive -- (Unable to verify individual commits from the diff alone, but PR title is descriptive)
Content matches pal-e-docs -- betty-sue.md is missing the "What Betty Sue Is NOT" section

VERDICT: NOT APPROVED

One blocker: agents/betty-sue.md must include the "What Betty Sue Is NOT" section from the agent-betty-sue pal-e-docs note to fulfill the PR's stated goal of mirroring source notes. The other three files (dev.md, qa.md, issue-creator.md) match their pal-e-docs sources exactly.

## PR #39 Review **Reviewer:** Agent QA (fresh context) **Plan:** `plan-2026-02-25-agent-profiles` **Issue:** #38 --- ### BLOCKERS **1. `agents/betty-sue.md` is missing the "What Betty Sue Is NOT" section** The pal-e-docs source note `agent-betty-sue` contains a `### What Betty Sue Is NOT` section with three bullet points: - Not a yes-woman -- pushes back when something doesn't make sense - Not passive -- proactively identifies gaps, missing docs, and risks - Not robotic -- has a personality, preferences, and cares about the work This section is absent from the PR file. Since the PR's stated purpose is to mirror pal-e-docs source notes, the file must match. This is the only content discrepancy across all four files. --- ### NITS **1. PR title exceeds 70 characters** The title "Align repo with pal-e-docs: agent profiles, fix symlinks, branch cleanup (#38)" is 82 characters. Convention suggests keeping PR titles under 70 characters. Non-blocking since the title is descriptive and clear. **2. Test Plan has an unchecked item** `- [ ] Agent profile content matches pal-e-docs notes` is unchecked, which is accurate given the blocker above -- but should be checked once the betty-sue.md discrepancy is resolved. **3. Review Checklist has an unchecked item** `- [ ] Passed automated review-fix loop` is unchecked. This is the first review round, so this is expected. Non-blocking. --- ### SOP COMPLIANCE - [x] **Branch named after issue** -- `38-align-repo-with-pal-e-docs-agent-profile` starts with issue number `38` - [x] **PR body follows `template-pr-body`** -- Has all required sections: ## Summary, ## Changes, ## Test Plan, ## Review Checklist, ## Related Notes - [x] **Related Notes references plan slug** -- `plan-2026-02-25-agent-profiles` is listed - [x] **No secrets committed** -- Only markdown files, no .env or credentials - [x] **No unnecessary file changes (scope creep)** -- PR body mentions symlink fixes and branch cleanup, but the diff only contains the 4 agent profile files (248 additions, 0 deletions). The symlink/branch work was likely done outside the diff (remote branch deletions, symlink changes not tracked in git). The 4 files are all in scope. - [x] **Commit messages are descriptive** -- (Unable to verify individual commits from the diff alone, but PR title is descriptive) - [ ] **Content matches pal-e-docs** -- `betty-sue.md` is missing the "What Betty Sue Is NOT" section --- ### VERDICT: NOT APPROVED One blocker: `agents/betty-sue.md` must include the "What Betty Sue Is NOT" section from the `agent-betty-sue` pal-e-docs note to fulfill the PR's stated goal of mirroring source notes. The other three files (`dev.md`, `qa.md`, `issue-creator.md`) match their pal-e-docs sources exactly.

forgejo_admin added 1 commit

2026-03-01 05:21:35 +00:00

Fix betty-sue.md: add missing 'What Betty Sue Is NOT' section (#38 ) 9e5a15c797

QA review caught that this section was missing from the pal-e-docs
source note. Adds the three personality constraints: not a yes-woman,
not passive, not robotic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

forgejo_admin commented

2026-03-01 05:27:34 +00:00

Author

Contributor

PR #39 Review (Round 2)

Reviewer: Agent QA (fresh context)

BLOCKERS

None.

All four agent profile files match their pal-e-docs source notes section-for-section and content-for-content. The Round 1 blocker (missing "What Betty Sue Is NOT" section in betty-sue.md) has been resolved in commit 9e5a15c.

NITS

PR body describes work not in the diff. The Changes section lists "Removed broken ~/.claude/commands symlink" and "Deleted 17 stale remote branches" but the diff only contains 4 new files with 254 additions and 0 deletions. These operations likely happened at the git/remote level and don't produce file-level diffs, but the PR body could be clearer about that distinction. Non-blocking.
Test Plan checkbox. The "Agent profile content matches pal-e-docs notes" item is unchecked. This review confirms the content matches -- the author may want to check it off before merge. Non-blocking.

SOP COMPLIANCE

Branch named after issue (38-align-repo-with-pal-e-docs-agent-profile)
PR body follows template-pr-body (all 5 sections: Summary, Changes, Test Plan, Review Checklist, Related Notes)
Related Notes references the plan slug (plan-2026-02-25-agent-profiles)
No secrets, .env files, or credentials committed
No unnecessary file changes (scope limited to 4 agent profile files)
Commit messages are descriptive and reference issue #38
Each markdown file includes source-of-truth pointer to pal-e-docs

Content verification (section-by-section against pal-e-docs):

File	pal-e-docs slug	Sections	Content match
`agents/betty-sue.md`	`agent-betty-sue`	11/11	PASS
`agents/dev.md`	`agent-dev`	7/7	PASS
`agents/qa.md`	`agent-qa`	8/8	PASS
`agents/issue-creator.md`	`agent-issue-creator`	7/7	PASS

VERDICT: APPROVED

All agent profiles faithfully mirror their pal-e-docs source notes. The Round 1 blocker has been fixed. No security issues, no scope creep, full SOP compliance.

## PR #39 Review (Round 2) Reviewer: Agent QA (fresh context) ### BLOCKERS None. All four agent profile files match their pal-e-docs source notes section-for-section and content-for-content. The Round 1 blocker (missing "What Betty Sue Is NOT" section in `betty-sue.md`) has been resolved in commit `9e5a15c`. ### NITS 1. **PR body describes work not in the diff.** The Changes section lists "Removed broken `~/.claude/commands` symlink" and "Deleted 17 stale remote branches" but the diff only contains 4 new files with 254 additions and 0 deletions. These operations likely happened at the git/remote level and don't produce file-level diffs, but the PR body could be clearer about that distinction. Non-blocking. 2. **Test Plan checkbox.** The "Agent profile content matches pal-e-docs notes" item is unchecked. This review confirms the content matches -- the author may want to check it off before merge. Non-blocking. ### SOP COMPLIANCE - [x] Branch named after issue (`38-align-repo-with-pal-e-docs-agent-profile`) - [x] PR body follows `template-pr-body` (all 5 sections: Summary, Changes, Test Plan, Review Checklist, Related Notes) - [x] Related Notes references the plan slug (`plan-2026-02-25-agent-profiles`) - [x] No secrets, .env files, or credentials committed - [x] No unnecessary file changes (scope limited to 4 agent profile files) - [x] Commit messages are descriptive and reference issue #38 - [x] Each markdown file includes source-of-truth pointer to pal-e-docs **Content verification (section-by-section against pal-e-docs):** | File | pal-e-docs slug | Sections | Content match | |------|----------------|----------|---------------| | `agents/betty-sue.md` | `agent-betty-sue` | 11/11 | PASS | | `agents/dev.md` | `agent-dev` | 7/7 | PASS | | `agents/qa.md` | `agent-qa` | 8/8 | PASS | | `agents/issue-creator.md` | `agent-issue-creator` | 7/7 | PASS | ### VERDICT: APPROVED All agent profiles faithfully mirror their pal-e-docs source notes. The Round 1 blocker has been fixed. No security issues, no scope creep, full SOP compliance.