ldraney/landscaping-assistant
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions 4

Property detail page CSS refresh: name as h1, button treatment per ror-css-guide #126

New issue
Closed
opened 2026-06-06 20:56:03 +00:00 by ldraney · 3 comments
ldraney commented 2026-06-06 20:56:03 +00:00
Owner
Copy link

Type

Feature

Lineage

Child of spike #121 (client request flow design). Part of Phase 3. CSS-only portion split from original #126 — projects section moved to separate ticket.

Repo

ldraney/landscaping-assistant

User Story

As a crew lead or admin, I want the property detail page to lead with the client name (not the address) and have consistent button styling so the page is easier to scan and navigate.

Context

The property detail page currently shows address_line as the h1 and uses inconsistent button classes (btn-accent for "Update Address", btn-link for "Go to Location" and "Edit"). This ticket refreshes the layout and buttons per the CSS conventions in ~/ror-css-guide (a local reference repo — plain CSS, design tokens in :root, mobile-first).

File Targets

  • app/views/properties/show.html.erb (update)
  • app/assets/stylesheets/application.css (update detail-actions section)
  • spec/requests/properties_spec.rb (update show spec if heading text changed)

Acceptance Criteria

  • h1 is client_name, not address_line
  • Address line + city/state/zip displayed as subtitle (or "No address yet")
  • Client name removed from the definition list (it's the heading now)
  • All action buttons use .btn base class with modifiers (no .btn-link)
  • Primary action (Update Address) full-width, secondary actions (Directions, Edit) split row below
  • Works on mobile (44px touch targets, proper spacing)

Test Expectations

  • spec/requests/properties_spec.rb: show page renders client_name in h1
  • Run: bundle exec rspec

Constraints

  • CSS follows ~/ror-css-guide — no Tailwind, design tokens in :root
  • Mobile-first, one breakpoint at 600px
  • No projects section in this ticket — that depends on #122

Feature Flag

None

Checklist

  • PR opened
  • Tests pass
  • No unrelated changes

Related

  • #121 — parent spike
  • NEW_ISSUE — projects section (split from this ticket, depends on #122)
### Type Feature ### Lineage Child of spike #121 (client request flow design). Part of Phase 3. CSS-only portion split from original #126 — projects section moved to separate ticket. ### Repo `ldraney/landscaping-assistant` ### User Story As a crew lead or admin, I want the property detail page to lead with the client name (not the address) and have consistent button styling so the page is easier to scan and navigate. ### Context The property detail page currently shows address_line as the h1 and uses inconsistent button classes (btn-accent for "Update Address", btn-link for "Go to Location" and "Edit"). This ticket refreshes the layout and buttons per the CSS conventions in `~/ror-css-guide` (a local reference repo — plain CSS, design tokens in :root, mobile-first). ### File Targets - `app/views/properties/show.html.erb` (update) - `app/assets/stylesheets/application.css` (update detail-actions section) - `spec/requests/properties_spec.rb` (update show spec if heading text changed) ### Acceptance Criteria - [ ] h1 is `client_name`, not `address_line` - [ ] Address line + city/state/zip displayed as subtitle (or "No address yet") - [ ] Client name removed from the definition list (it's the heading now) - [ ] All action buttons use `.btn` base class with modifiers (no `.btn-link`) - [ ] Primary action (Update Address) full-width, secondary actions (Directions, Edit) split row below - [ ] Works on mobile (44px touch targets, proper spacing) ### Test Expectations - `spec/requests/properties_spec.rb`: show page renders client_name in h1 - Run: `bundle exec rspec` ### Constraints - CSS follows `~/ror-css-guide` — no Tailwind, design tokens in :root - Mobile-first, one breakpoint at 600px - No projects section in this ticket — that depends on #122 ### Feature Flag None ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - #121 — parent spike - NEW_ISSUE — projects section (split from this ticket, depends on #122)
ldraney commented 2026-06-08 04:33:42 +00:00
Author
Owner
Copy link

Scope Review: NEEDS_REFINEMENT

Review note: review-1351-2026-06-07

Three issues found before this ticket can move to next_up:

  • Hard blocker: #122 (ServiceRequest model + migration) must land first -- no ServiceRequest model, migration, or service_requests table exists in the codebase. AC #2-4 cannot be implemented without it.
  • Missing reference: ~/ror-css-guide is referenced in the issue body and AC but does not exist as a pal-e-docs note (404). The implementing agent will have no CSS guide to follow.
  • Missing template section: Feature Flag section required by template-issue-feature -- add ### Feature Flag\nnone (CSS/UI work, no flag needed).
## Scope Review: NEEDS_REFINEMENT Review note: `review-1351-2026-06-07` Three issues found before this ticket can move to next_up: - **Hard blocker:** #122 (ServiceRequest model + migration) must land first -- no `ServiceRequest` model, migration, or `service_requests` table exists in the codebase. AC #2-4 cannot be implemented without it. - **Missing reference:** `~/ror-css-guide` is referenced in the issue body and AC but does not exist as a pal-e-docs note (404). The implementing agent will have no CSS guide to follow. - **Missing template section:** Feature Flag section required by `template-issue-feature` -- add `### Feature Flag\nnone` (CSS/UI work, no flag needed).
ldraney changed title from Property detail page refresh: Projects button + ~/ror-css-guide update to Property detail page CSS refresh: name as h1, button treatment per ror-css-guide 2026-06-08 04:35:51 +00:00
ldraney commented 2026-06-08 04:36:13 +00:00
Author
Owner
Copy link

Scope split (post review-1351-2026-06-07):

Split into two tickets:

  • #126 (this ticket): CSS-only refresh — client name as h1, button treatment per ~/ror-css-guide. No dependencies. Reduced to 2pts.
  • #176 (new): Projects section on property detail page. Depends on #122 (ServiceRequest model). 3pts.

Reason: ServiceRequest model doesn't exist yet. CSS refresh is independent and shippable now.

**Scope split (post review-1351-2026-06-07):** Split into two tickets: - **#126 (this ticket)**: CSS-only refresh — client name as h1, button treatment per `~/ror-css-guide`. No dependencies. Reduced to 2pts. - **#176 (new)**: Projects section on property detail page. Depends on #122 (ServiceRequest model). 3pts. Reason: ServiceRequest model doesn't exist yet. CSS refresh is independent and shippable now.
ldraney commented 2026-06-08 04:49:25 +00:00
Author
Owner
Copy link

Scope Review: READY

Review note: review-1351-2026-06-07-v2

Re-review passed. All three issues from the first review are resolved:

  • ServiceRequest dependency split to #176 -- this ticket is CSS-only now
  • ~/ror-css-guide confirmed as valid local repo
  • Feature Flag section added (None -- appropriate for CSS)

All 3 file targets verified, 6 acceptance criteria are agent-testable, no decomposition needed. Ticket is ready for implementation.

## Scope Review: READY Review note: `review-1351-2026-06-07-v2` Re-review passed. All three issues from the first review are resolved: - ServiceRequest dependency split to #176 -- this ticket is CSS-only now - `~/ror-css-guide` confirmed as valid local repo - Feature Flag section added (None -- appropriate for CSS) All 3 file targets verified, 6 acceptance criteria are agent-testable, no decomposition needed. Ticket is ready for implementation.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
docs/update-app-architecture
revert-213
move-other-crew-bottom-remove-schedule
feature/today-view-improvements
154-enable-assume-ssl
revert-145-person-icon
docs/user-stories-auth
docs/update-infra-pipeline-post-incident
fix-cache-step-blocking-deploy
fix-kaniko-registry-pull
deactivate-from-today
feature/quick-address-entry
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant#126
No description provided.