ldraney/landscaping-assistant
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions 4

Fix incorrect SolidCache claim in feature flags doc #143

Merged
ldraney merged 1 commit from docs/fix-solidcache-claim into main 2026-06-07 02:21:32 +00:00
Conversation 1 Commits 1 Files changed 1 +2 -2
ldraney commented 2026-06-07 02:18:59 +00:00
Owner
Copy link

Summary

  • SolidCache is NOT configured in production — cache_store is commented out in production.rb, no solid_cache.yml exists
  • Fixed two references claiming "SolidCache in prod" to correctly state Rails.cache defaults to :file_store
  • Caught during #130 scope review

Changes

  • docs/feature-flags.md: fix model comment (line 58) and rationale paragraph (line 86) to remove false SolidCache claims

Test Plan

  • Specs pass (doc-only, no code impact)
  • Verified config/environments/production.rb line 60 has cache_store commented out
  • Verified no config/solid_cache.yml exists

Review Checklist

  • Passed automated review-fix loop
  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive
  • Feature flag needed? No — doc-only fix

Related Notes

  • ldraney/landscaping-assistant #130 — the implementation ticket this doc supports
  • project-landscaping-assistant — landscaping assistant project
  • Doc accuracy fix only — does NOT close #130
## Summary - SolidCache is NOT configured in production — `cache_store` is commented out in production.rb, no `solid_cache.yml` exists - Fixed two references claiming "SolidCache in prod" to correctly state Rails.cache defaults to `:file_store` - Caught during #130 scope review ## Changes - `docs/feature-flags.md`: fix model comment (line 58) and rationale paragraph (line 86) to remove false SolidCache claims ## Test Plan - [ ] Specs pass (doc-only, no code impact) - [ ] Verified `config/environments/production.rb` line 60 has `cache_store` commented out - [ ] Verified no `config/solid_cache.yml` exists ## Review Checklist - [ ] Passed automated review-fix loop - [ ] No secrets committed - [ ] No unnecessary file changes - [ ] Commit messages are descriptive - [ ] Feature flag needed? No — doc-only fix ## Related Notes - `ldraney/landscaping-assistant #130` — the implementation ticket this doc supports - `project-landscaping-assistant` — landscaping assistant project - Doc accuracy fix only — does NOT close #130
Fix incorrect SolidCache claim in feature flags doc
Some checks failed
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
CI / scan_ruby (pull_request) Has been cancelled
Details
CI / scan_js (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
e78ac0f016 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ldraney commented 2026-06-07 02:20:13 +00:00
Author
Owner
Copy link

PR #143 Review

DOMAIN REVIEW

Tech stack: Ruby on Rails documentation (Markdown). No code changes -- doc-only fix in docs/feature-flags.md.

Correctness of Fix 1 (line 58 comment):

  • Old: "Uses Rails.cache (SolidCache in prod) with a short TTL"
  • New: "Uses Rails.cache with a short TTL"
  • Verified: config/environments/production.rb line 60 shows # config.cache_store = :mem_cache_store (commented out). No active cache_store configuration exists, so Rails defaults to :file_store. The parenthetical "(SolidCache in prod)" was false. Fix is correct.

Correctness of Fix 2 (line 86 rationale):

  • Old: "SolidCache is already configured in production, so this uses existing infrastructure."
  • New: "Rails.cache defaults to :file_store in production (SolidCache is in the Gemfile but not yet configured -- see #2). Rails.cache.fetch works with any cache store."
  • Verified: Gemfile line 27 has gem "solid_cache" (present). config/solid_cache.yml does not exist (confirmed). The replacement text is factually accurate on all three claims: (1) default is :file_store, (2) SolidCache is in the Gemfile, (3) it is not yet configured.

Remaining SolidCache references: Scanned the full docs/feature-flags.md. No other stale SolidCache claims remain. Line 444 references "Solid Cable" (not SolidCache) in the Turbo Streams section -- that is a separate concern and accurate in context.

BLOCKERS

None.

NITS

  1. #2 cross-reference (line 86): The replacement text says "see #2" referring to SolidCache/Solid Cable configuration. This reference is pre-existing (not introduced by this PR), but worth confirming that issue #2 is the correct tracking issue for SolidCache setup. If #2 has been closed or re-scoped, this reference could itself become stale.

  2. :file_store accuracy: The claim "Rails.cache defaults to :file_store in production" is correct for Rails 8.x when no cache_store is explicitly set and no tmp/cache directory configuration overrides it. Technically the default is :file_store (backed by tmp/cache/). Accurate as stated.

SOP COMPLIANCE

  • Branch named after issue -- docs/fix-solidcache-claim does not follow {issue-number}-{kebab-case} convention. Acceptable for a standalone doc fix caught during scope review of #130 with no dedicated issue.
  • PR body follows template -- Summary, Changes, Test Plan, Review Checklist, Related Notes all present and substantive.
  • Related section references context -- references #130 (parent scope review) and project slug.
  • No secrets committed
  • No unnecessary file changes -- single file, 2 lines changed, all on-topic.
  • Commit messages are descriptive

PROCESS OBSERVATIONS

Clean, minimal doc accuracy fix. Caught during scope review of #130, which is exactly the right time to fix doc drift. No deployment risk -- doc-only change. No test impact.

VERDICT: APPROVED

## PR #143 Review ### DOMAIN REVIEW **Tech stack**: Ruby on Rails documentation (Markdown). No code changes -- doc-only fix in `docs/feature-flags.md`. **Correctness of Fix 1 (line 58 comment)**: - Old: "Uses Rails.cache (SolidCache in prod) with a short TTL" - New: "Uses Rails.cache with a short TTL" - Verified: `config/environments/production.rb` line 60 shows `# config.cache_store = :mem_cache_store` (commented out). No active `cache_store` configuration exists, so Rails defaults to `:file_store`. The parenthetical "(SolidCache in prod)" was false. Fix is correct. **Correctness of Fix 2 (line 86 rationale)**: - Old: "SolidCache is already configured in production, so this uses existing infrastructure." - New: "Rails.cache defaults to `:file_store` in production (SolidCache is in the Gemfile but not yet configured -- see #2). `Rails.cache.fetch` works with any cache store." - Verified: `Gemfile` line 27 has `gem "solid_cache"` (present). `config/solid_cache.yml` does not exist (confirmed). The replacement text is factually accurate on all three claims: (1) default is `:file_store`, (2) SolidCache is in the Gemfile, (3) it is not yet configured. **Remaining SolidCache references**: Scanned the full `docs/feature-flags.md`. No other stale SolidCache claims remain. Line 444 references "Solid Cable" (not SolidCache) in the Turbo Streams section -- that is a separate concern and accurate in context. ### BLOCKERS None. ### NITS 1. **`#2` cross-reference (line 86)**: The replacement text says "see #2" referring to SolidCache/Solid Cable configuration. This reference is pre-existing (not introduced by this PR), but worth confirming that issue #2 is the correct tracking issue for SolidCache setup. If #2 has been closed or re-scoped, this reference could itself become stale. 2. **`:file_store` accuracy**: The claim "Rails.cache defaults to `:file_store` in production" is correct for Rails 8.x when no `cache_store` is explicitly set and no `tmp/cache` directory configuration overrides it. Technically the default is `:file_store` (backed by `tmp/cache/`). Accurate as stated. ### SOP COMPLIANCE - [ ] Branch named after issue -- `docs/fix-solidcache-claim` does not follow `{issue-number}-{kebab-case}` convention. Acceptable for a standalone doc fix caught during scope review of #130 with no dedicated issue. - [x] PR body follows template -- Summary, Changes, Test Plan, Review Checklist, Related Notes all present and substantive. - [x] Related section references context -- references #130 (parent scope review) and project slug. - [x] No secrets committed - [x] No unnecessary file changes -- single file, 2 lines changed, all on-topic. - [x] Commit messages are descriptive ### PROCESS OBSERVATIONS Clean, minimal doc accuracy fix. Caught during scope review of #130, which is exactly the right time to fix doc drift. No deployment risk -- doc-only change. No test impact. ### VERDICT: APPROVED
ldraney deleted branch docs/fix-solidcache-claim 2026-06-07 02:21:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant!143
No description provided.