ldraney/landscaping-assistant
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions 4

Update ios-dev-builds.md to reflect xcodebuild workflow #251

New issue
Closed
opened 2026-06-18 22:21:34 +00:00 by ldraney · 1 comment
ldraney commented 2026-06-18 22:21:34 +00:00
Owner
Copy link

Type

Bug

Lineage

Discovered during QA review of PR #250 (iOS pipeline and networking docs).

Repo

ldraney/landscaping-assistant

What Broke

docs/ios-dev-builds.md still references Fastlane as the build tool. PR #250 documented that the actual workflow uses raw xcodebuild because Fastlane's produce action doesn't support API key auth. The README.md doc table also describes ios-dev-builds as "TestFlight, wireless install, Fastlane setup" which is now misleading.

Repro Steps

  1. Read docs/ios-dev-builds.md
  2. Observe Fastlane references that don't match the actual build pipeline documented in docs/ios-pipeline.md

Expected Behavior

ios-dev-builds.md should cross-reference ios-pipeline.md and clarify that Fastlane is installed but not used for production builds. README.md table description should be updated.

Environment

  • Docs only

Acceptance Criteria

  • ios-dev-builds.md updated to reference ios-pipeline.md for production builds
  • README.md table description for ios-dev-builds updated
  • No contradictory Fastlane references remain across docs

Related

  • PR #250 — iOS pipeline docs that exposed the discrepancy
  • docs/ios-pipeline.md — canonical build pipeline doc
### Type Bug ### Lineage Discovered during QA review of PR #250 (iOS pipeline and networking docs). ### Repo `ldraney/landscaping-assistant` ### What Broke `docs/ios-dev-builds.md` still references Fastlane as the build tool. PR #250 documented that the actual workflow uses raw `xcodebuild` because Fastlane's `produce` action doesn't support API key auth. The README.md doc table also describes ios-dev-builds as "TestFlight, wireless install, Fastlane setup" which is now misleading. ### Repro Steps 1. Read `docs/ios-dev-builds.md` 2. Observe Fastlane references that don't match the actual build pipeline documented in `docs/ios-pipeline.md` ### Expected Behavior ios-dev-builds.md should cross-reference ios-pipeline.md and clarify that Fastlane is installed but not used for production builds. README.md table description should be updated. ### Environment - Docs only ### Acceptance Criteria - [ ] ios-dev-builds.md updated to reference ios-pipeline.md for production builds - [ ] README.md table description for ios-dev-builds updated - [ ] No contradictory Fastlane references remain across docs ### Related - PR #250 — iOS pipeline docs that exposed the discrepancy - `docs/ios-pipeline.md` — canonical build pipeline doc
ldraney commented 2026-06-18 23:08:40 +00:00
Author
Owner
Copy link

Issue #251 Template Review

TEMPLATE CONFORMANCE

  • Type header present and valid (Bug)
  • All required sections present (Type, Lineage, Repo, What Broke, Repro Steps, Expected Behavior, Environment, Acceptance Criteria, Related)
  • Sections non-empty -- all contain substantive content
  • Acceptance Criteria should use - [ ] checkbox format per template (nit -- current format uses plain - bullets)

CONTENT QUALITY

Lineage: Clear provenance -- ties back to PR #250, which is confirmed merged. Good traceability.

What Broke: Accurate. Verified against the current docs/ios-dev-builds.md:

  • Lines 12, 18-19: Fastlane presented as the primary build tool (fastlane beta)
  • Lines 96-153: Entire "Fastlane Setup" section with Fastfile lanes
  • Line 3 links to pipeline.md but not the new ios-pipeline.md created by PR #250
  • README doc table still describes ios-dev-builds as "TestFlight, wireless install, Fastlane setup"

All claims in the issue body check out against the actual file contents.

Repro Steps: Sufficient. Steps are "read the doc and observe the contradiction" -- appropriate for a docs-only bug.

Expected Behavior: Clear outcome stated -- cross-reference ios-pipeline.md, clarify Fastlane status, update README description.

Environment: "Docs only" is appropriate. No cluster/SHA needed for a documentation inconsistency.

Acceptance Criteria: Three concrete, verifiable items:

  1. ios-dev-builds.md references ios-pipeline.md -- testable by checking for cross-link
  2. README table description updated -- testable by reading the table
  3. No contradictory Fastlane references remain -- testable by grepping docs for Fastlane

One observation: the third criterion ("No contradictory Fastlane references remain across docs") needs care in implementation. Fastlane is installed and was the original tool -- the fix should clarify that Fastlane is present but not used for production builds, not remove all mention of it. The issue body correctly states this in Expected Behavior ("clarify that Fastlane is installed but not used for production builds"), so the acceptance criteria and expected behavior are aligned.

Related: PR #250 confirmed merged. docs/ios-pipeline.md confirmed to exist on main after that merge.

BLOCKERS

None. The issue is well-formed, all required template sections are present and non-empty, the bug description is accurate and verified against the codebase, and the acceptance criteria are testable.

NITS

  1. Checkbox format: Acceptance criteria use - instead of - [ ]. The template specifies checkbox format. Not blocking but should be standard.
  2. Scope suggestion: The CLAUDE.md file also references ios-dev-builds as "TestFlight, wireless install, Fastlane setup" (identical to README). Consider adding it to scope, or note it as out-of-scope if CLAUDE.md is auto-generated from README.

VERDICT: APPROVED

## Issue #251 Template Review ### TEMPLATE CONFORMANCE - [x] Type header present and valid (`Bug`) - [x] All required sections present (`Type`, `Lineage`, `Repo`, `What Broke`, `Repro Steps`, `Expected Behavior`, `Environment`, `Acceptance Criteria`, `Related`) - [x] Sections non-empty -- all contain substantive content - [ ] Acceptance Criteria should use `- [ ]` checkbox format per template (nit -- current format uses plain `- ` bullets) ### CONTENT QUALITY **Lineage:** Clear provenance -- ties back to PR #250, which is confirmed merged. Good traceability. **What Broke:** Accurate. Verified against the current `docs/ios-dev-builds.md`: - Lines 12, 18-19: Fastlane presented as the primary build tool (`fastlane beta`) - Lines 96-153: Entire "Fastlane Setup" section with `Fastfile` lanes - Line 3 links to `pipeline.md` but not the new `ios-pipeline.md` created by PR #250 - README doc table still describes ios-dev-builds as "TestFlight, wireless install, Fastlane setup" All claims in the issue body check out against the actual file contents. **Repro Steps:** Sufficient. Steps are "read the doc and observe the contradiction" -- appropriate for a docs-only bug. **Expected Behavior:** Clear outcome stated -- cross-reference ios-pipeline.md, clarify Fastlane status, update README description. **Environment:** "Docs only" is appropriate. No cluster/SHA needed for a documentation inconsistency. **Acceptance Criteria:** Three concrete, verifiable items: 1. ios-dev-builds.md references ios-pipeline.md -- testable by checking for cross-link 2. README table description updated -- testable by reading the table 3. No contradictory Fastlane references remain -- testable by grepping docs for Fastlane One observation: the third criterion ("No contradictory Fastlane references remain across docs") needs care in implementation. Fastlane *is* installed and *was* the original tool -- the fix should clarify that Fastlane is present but not used for production builds, not remove all mention of it. The issue body correctly states this in Expected Behavior ("clarify that Fastlane is installed but not used for production builds"), so the acceptance criteria and expected behavior are aligned. **Related:** PR #250 confirmed merged. `docs/ios-pipeline.md` confirmed to exist on main after that merge. ### BLOCKERS None. The issue is well-formed, all required template sections are present and non-empty, the bug description is accurate and verified against the codebase, and the acceptance criteria are testable. ### NITS 1. **Checkbox format:** Acceptance criteria use `- ` instead of `- [ ]`. The template specifies checkbox format. Not blocking but should be standard. 2. **Scope suggestion:** The CLAUDE.md file also references ios-dev-builds as "TestFlight, wireless install, Fastlane setup" (identical to README). Consider adding it to scope, or note it as out-of-scope if CLAUDE.md is auto-generated from README. ### VERDICT: APPROVED
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
docs/update-app-architecture
revert-213
move-other-crew-bottom-remove-schedule
feature/today-view-improvements
154-enable-assume-ssl
revert-145-person-icon
docs/user-stories-auth
docs/update-infra-pipeline-post-incident
fix-cache-step-blocking-deploy
fix-kaniko-registry-pull
deactivate-from-today
feature/quick-address-entry
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant#251
No description provided.