ldraney/landscaping-assistant
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions 4

Remove duplicate .role-badge CSS from Person section #148

Merged
ldraney merged 1 commit from fix/css-role-badge-duplicate into main 2026-06-07 03:29:12 +00:00
Conversation 0 Commits 1 Files changed 1 -11
ldraney commented 2026-06-07 03:28:38 +00:00
Owner
Copy link

Summary

  • Removes duplicate .role-badge definition from Person CSS section that would conflict with PR #146's richer definition

Changes

  • app/assets/stylesheets/application.css: removed .role-badge block (11 lines) from Person component section. PR #146 (Crew tab) defines .role-badge with neutral base colors and role-specific modifiers (.role-badge-admin, .role-badge-lead, etc.). The Person section's definition used fixed accent colors that would override those modifiers via CSS cascade.

Test Plan

  • 196 examples, 0 failures
  • Person page role badges still render (will use #146's definition after that merges)

Review Checklist

  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive
  • Feature flag needed? No — CSS-only fix

Related Notes

  • Retroactive fix for PR #145 (merged without review)
  • Unblocks PR #146 (#117 Crew tab) from CSS conflict
## Summary - Removes duplicate `.role-badge` definition from Person CSS section that would conflict with PR #146's richer definition ## Changes - `app/assets/stylesheets/application.css`: removed `.role-badge` block (11 lines) from Person component section. PR #146 (Crew tab) defines `.role-badge` with neutral base colors and role-specific modifiers (`.role-badge-admin`, `.role-badge-lead`, etc.). The Person section's definition used fixed accent colors that would override those modifiers via CSS cascade. ## Test Plan - [x] 196 examples, 0 failures - [ ] Person page role badges still render (will use #146's definition after that merges) ## Review Checklist - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive - [x] Feature flag needed? No — CSS-only fix ## Related Notes - Retroactive fix for PR #145 (merged without review) - Unblocks PR #146 (#117 Crew tab) from CSS conflict
Remove duplicate .role-badge from Person CSS section
Some checks failed
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
CI / scan_ruby (pull_request) Has been cancelled
Details
CI / scan_js (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
8ca09b21a6 
PR #146 (Crew tab) defines .role-badge with role-specific modifiers
(.role-badge-admin, .role-badge-lead, etc.). The Person section's
definition would override those with a fixed accent color. Removing
it so #146's richer definition is the single source of truth.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ldraney deleted branch fix/css-role-badge-duplicate 2026-06-07 03:29:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant!148
No description provided.