Set app timezone to Mountain Time #38
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "37-fix-timestamps-to-display-in-mountain-ti"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
config.time_zone = "Mountain Time (US & Canada)"so all timestamps display in MDT/MST instead of UTCconfig/application.rbChanges
config/application.rb: Uncomment and setconfig.time_zoneto"Mountain Time (US & Canada)"Test Plan
Review Checklist
Related Notes
ldraney/landscaping-assistant #37— the Forgejo issue this PR implementsproject-landscaping-assistant— the project this work belongs toCloses #37
PR #38 Review
DOMAIN REVIEW
Stack: Ruby on Rails 8.1, PostgreSQL, RSpec
This is a one-line configuration change in
config/application.rb: uncommenting and settingconfig.time_zonefrom the Rails default comment ("Central Time (US & Canada)") to"Mountain Time (US & Canada)".Correctness:
"Mountain Time (US & Canada)"is a validActiveSupport::TimeZoneidentifier. Rails will use it for display-layer time conversion while PostgreSQL continues storing timestamps in UTC. This is the standard and correct approach.Scope: The diff touches exactly one line in one file. No scope creep.
No
config.active_record.default_timezoneoverride: The PR correctly leavesactive_record.default_timezoneat its default (:utc), meaning the database layer remains UTC. Only the application display layer changes. This is the right pattern.BLOCKERS
None.
This is a declarative config change, not new functionality. The BLOCKER criterion "new functionality with zero test coverage" does not apply -- there is no logic to test. The time zone string is a Rails-recognized constant, and the behavior (UTC storage + display conversion) is tested by Rails itself. The PR's manual test plan (verify timestamps display in Mountain Time after deploy) is the appropriate verification for a config-only change.
NITS
None. The change is minimal and correct.
SOP COMPLIANCE
37-fix-timestamps-to-display-in-mountain-tifollows{issue-number}-{kebab-case-purpose})project-landscaping-assistant)Closes #37links PR to parent issuePROCESS OBSERVATIONS
Low-risk, high-confidence change. One line of config, zero logic, no migration. Deployment frequency: this is the kind of small, scoped change that supports high deployment frequency with minimal change failure risk. Manual verification after deploy (timestamps display in MDT/MST) is the correct test plan for this type of change.
VERDICT: APPROVED