Set app timezone to Mountain Time #38

Merged
ldraney merged 1 commit from 37-fix-timestamps-to-display-in-mountain-ti into main 2026-05-29 04:13:52 +00:00
Owner

Summary

  • Set config.time_zone = "Mountain Time (US & Canada)" so all timestamps display in MDT/MST instead of UTC
  • One-line change in config/application.rb

Changes

  • config/application.rb: Uncomment and set config.time_zone to "Mountain Time (US & Canada)"

Test Plan

  • Upload timestamps display in Mountain Time after deploy
  • Existing timestamps still correct (Postgres stores UTC, Rails converts on display)
  • No regressions in week view date labels or work queue dates

Review Checklist

  • Passed automated review-fix loop
  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive
  • ldraney/landscaping-assistant #37 — the Forgejo issue this PR implements
  • project-landscaping-assistant — the project this work belongs to

Closes #37

## Summary - Set `config.time_zone = "Mountain Time (US & Canada)"` so all timestamps display in MDT/MST instead of UTC - One-line change in `config/application.rb` ## Changes - `config/application.rb`: Uncomment and set `config.time_zone` to `"Mountain Time (US & Canada)"` ## Test Plan - [ ] Upload timestamps display in Mountain Time after deploy - [ ] Existing timestamps still correct (Postgres stores UTC, Rails converts on display) - [ ] No regressions in week view date labels or work queue dates ## Review Checklist - [ ] Passed automated review-fix loop - [ ] No secrets committed - [ ] No unnecessary file changes - [ ] Commit messages are descriptive ## Related Notes - `ldraney/landscaping-assistant #37` — the Forgejo issue this PR implements - `project-landscaping-assistant` — the project this work belongs to Closes #37
Set app timezone to Mountain Time (US & Canada)
Some checks failed
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/pr/woodpecker Pipeline was successful
CI / scan_ruby (pull_request) Has been cancelled
CI / scan_js (pull_request) Has been cancelled
CI / lint (pull_request) Has been cancelled
e807db6153
Closes #37

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
Owner

PR #38 Review

DOMAIN REVIEW

Stack: Ruby on Rails 8.1, PostgreSQL, RSpec

This is a one-line configuration change in config/application.rb: uncommenting and setting config.time_zone from the Rails default comment ("Central Time (US & Canada)") to "Mountain Time (US & Canada)".

Correctness: "Mountain Time (US & Canada)" is a valid ActiveSupport::TimeZone identifier. Rails will use it for display-layer time conversion while PostgreSQL continues storing timestamps in UTC. This is the standard and correct approach.

Scope: The diff touches exactly one line in one file. No scope creep.

No config.active_record.default_timezone override: The PR correctly leaves active_record.default_timezone at its default (:utc), meaning the database layer remains UTC. Only the application display layer changes. This is the right pattern.

BLOCKERS

None.

This is a declarative config change, not new functionality. The BLOCKER criterion "new functionality with zero test coverage" does not apply -- there is no logic to test. The time zone string is a Rails-recognized constant, and the behavior (UTC storage + display conversion) is tested by Rails itself. The PR's manual test plan (verify timestamps display in Mountain Time after deploy) is the appropriate verification for a config-only change.

NITS

None. The change is minimal and correct.

SOP COMPLIANCE

  • Branch named after issue (37-fix-timestamps-to-display-in-mountain-ti follows {issue-number}-{kebab-case-purpose})
  • PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related)
  • Related references project (project-landscaping-assistant)
  • Related references plan slug -- N/A, no plan slug for this one-line fix (acceptable)
  • No secrets committed
  • No unnecessary file changes (1 file, 1 line)
  • Closes #37 links PR to parent issue

PROCESS OBSERVATIONS

Low-risk, high-confidence change. One line of config, zero logic, no migration. Deployment frequency: this is the kind of small, scoped change that supports high deployment frequency with minimal change failure risk. Manual verification after deploy (timestamps display in MDT/MST) is the correct test plan for this type of change.

VERDICT: APPROVED

## PR #38 Review ### DOMAIN REVIEW **Stack**: Ruby on Rails 8.1, PostgreSQL, RSpec This is a one-line configuration change in `config/application.rb`: uncommenting and setting `config.time_zone` from the Rails default comment (`"Central Time (US & Canada)"`) to `"Mountain Time (US & Canada)"`. **Correctness**: `"Mountain Time (US & Canada)"` is a valid `ActiveSupport::TimeZone` identifier. Rails will use it for display-layer time conversion while PostgreSQL continues storing timestamps in UTC. This is the standard and correct approach. **Scope**: The diff touches exactly one line in one file. No scope creep. **No `config.active_record.default_timezone` override**: The PR correctly leaves `active_record.default_timezone` at its default (`:utc`), meaning the database layer remains UTC. Only the application display layer changes. This is the right pattern. ### BLOCKERS None. This is a declarative config change, not new functionality. The BLOCKER criterion "new functionality with zero test coverage" does not apply -- there is no logic to test. The time zone string is a Rails-recognized constant, and the behavior (UTC storage + display conversion) is tested by Rails itself. The PR's manual test plan (verify timestamps display in Mountain Time after deploy) is the appropriate verification for a config-only change. ### NITS None. The change is minimal and correct. ### SOP COMPLIANCE - [x] Branch named after issue (`37-fix-timestamps-to-display-in-mountain-ti` follows `{issue-number}-{kebab-case-purpose}`) - [x] PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related) - [x] Related references project (`project-landscaping-assistant`) - [ ] Related references plan slug -- N/A, no plan slug for this one-line fix (acceptable) - [x] No secrets committed - [x] No unnecessary file changes (1 file, 1 line) - [x] `Closes #37` links PR to parent issue ### PROCESS OBSERVATIONS Low-risk, high-confidence change. One line of config, zero logic, no migration. Deployment frequency: this is the kind of small, scoped change that supports high deployment frequency with minimal change failure risk. Manual verification after deploy (timestamps display in MDT/MST) is the correct test plan for this type of change. ### VERDICT: APPROVED
ldraney deleted branch 37-fix-timestamps-to-display-in-mountain-ti 2026-05-29 04:13:52 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant!38
No description provided.