ldraney/pal-e-platform
1
0
Fork 0
Code Issues 104 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Add 7d/30d rolling trend panels for DF and LT #430

New issue
Open
opened 2026-06-13 18:35:42 +00:00 by ldraney · 1 comment
ldraney commented 2026-06-13 18:35:42 +00:00
Owner
Copy link

Type

Feature

Lineage

Migrated from ldraney/DORA#7.
Standalone — part of DORA dashboard improvements.

Repo

ldraney/pal-e-platform

User Story

As a platform operator
I want Tier 1 DORA composite in Grafana
So that I know if production pipelines are healthy without digging

Context

Current dashboard shows point-in-time values. Rolling 7d and 30d averages reveal trajectory — are we improving or regressing? This catches slow degradation before it compounds.

File Targets

Files the agent should modify or create:

  • terraform/dashboards/dora-dashboard.json — add trend timeseries panels

Feature Flag

None required — trend panels are additive dashboard elements.

Acceptance Criteria

  • 7d rolling average panel for Deployment Frequency
  • 30d rolling average panel for Deployment Frequency
  • 7d rolling average panel for Lead Time
  • 30d rolling average panel for Lead Time

Test Expectations

  • Manual: verify trend lines render correctly in Grafana

Constraints

  • Prometheus retention is 15d — 30d rolling average will only have full data after retention is extended or Thanos is added

Checklist

  • PR opened
  • Tests pass
  • No unrelated changes

Related

  • dora-metrics — project this affects
### Type Feature ### Lineage Migrated from ldraney/DORA#7. Standalone — part of DORA dashboard improvements. ### Repo `ldraney/pal-e-platform` ### User Story As a platform operator I want Tier 1 DORA composite in Grafana So that I know if production pipelines are healthy without digging ### Context Current dashboard shows point-in-time values. Rolling 7d and 30d averages reveal trajectory — are we improving or regressing? This catches slow degradation before it compounds. ### File Targets Files the agent should modify or create: - `terraform/dashboards/dora-dashboard.json` — add trend timeseries panels ### Feature Flag None required — trend panels are additive dashboard elements. ### Acceptance Criteria - [ ] 7d rolling average panel for Deployment Frequency - [ ] 30d rolling average panel for Deployment Frequency - [ ] 7d rolling average panel for Lead Time - [ ] 30d rolling average panel for Lead Time ### Test Expectations - [ ] Manual: verify trend lines render correctly in Grafana ### Constraints - Prometheus retention is 15d — 30d rolling average will only have full data after retention is extended or Thanos is added ### Checklist - [ ] PR opened - [ ] Tests pass - [ ] No unrelated changes ### Related - `dora-metrics` — project this affects
ldraney commented 2026-06-13 19:16:13 +00:00
Author
Owner
Copy link

Issue #430 Template Review

TEMPLATE CONFORMANCE

  • ### Type header present and valid (Feature)
  • ### Lineage present and non-empty (migrated from ldraney/DORA#7)
  • ### Repo present and non-empty (ldraney/pal-e-platform)
  • ### User Story present, follows As/I want/So that format
  • ### Context present, explains motivation clearly
  • ### File Targets present and lists a specific path
  • ### Feature Flag present (marked "None required" with reasoning)
  • ### Acceptance Criteria present, uses - [ ] checkbox format
  • ### Test Expectations present, uses - [ ] checkbox format
  • ### Constraints present and non-empty
  • ### Checklist present with standard items
  • ### Related present

All required sections from template-issue-feature are present and non-empty.

CONTENT QUALITY

File Targets: The single target terraform/dashboards/dora-dashboard.json is a real file in the repo -- verified. However, the template calls for a "should NOT touch" section as well. Not a blocker since the scope is narrow (single file), but worth noting.

Acceptance Criteria: Four items, all testable and specific. Each names the window (7d/30d) and metric (DF/LT). Good.

Test Expectations: Only manual verification ("verify trend lines render correctly in Grafana"). For a Grafana dashboard JSON change, manual is reasonable -- there is no unit test framework for dashboard JSON. Acceptable.

Constraints: The Prometheus 15d retention note is valuable. It honestly documents that the 30d rolling average will be incomplete until retention is extended or Thanos is added. This is good scope discipline -- the ticket does not try to also fix the retention problem.

User Story: Slightly mismatched with the title. The user story says "Tier 1 DORA composite in Grafana" but the issue is specifically about rolling trend panels for DF and LT, not a composite score. Minor -- the intent is clear.

Feature Flag: Correctly marked "None required" with reasoning (additive dashboard elements). Matches the template guidance for when to skip.

BLOCKERS

None.

NITS

  1. File Targets "should NOT touch" list missing. The template includes a "Files the agent should NOT touch" sub-section. For a single-file dashboard change this is low risk, but explicitly listing exclusions (e.g., other dashboard JSONs, Terraform state) prevents scope creep.
  2. User story vs. title mismatch. User story mentions "Tier 1 DORA composite" but the ticket is about rolling trend panels for two specific metrics. Consider aligning the user story to match the actual deliverable.
  3. Related section is thin. Lists dora-metrics project but does not reference sibling issues #427, #428, #429 which are also DORA dashboard improvements. Cross-referencing helps agents understand sequencing.

VERDICT: APPROVED

## Issue #430 Template Review ### TEMPLATE CONFORMANCE - [x] `### Type` header present and valid (Feature) - [x] `### Lineage` present and non-empty (migrated from ldraney/DORA#7) - [x] `### Repo` present and non-empty (`ldraney/pal-e-platform`) - [x] `### User Story` present, follows As/I want/So that format - [x] `### Context` present, explains motivation clearly - [x] `### File Targets` present and lists a specific path - [x] `### Feature Flag` present (marked "None required" with reasoning) - [x] `### Acceptance Criteria` present, uses `- [ ]` checkbox format - [x] `### Test Expectations` present, uses `- [ ]` checkbox format - [x] `### Constraints` present and non-empty - [x] `### Checklist` present with standard items - [x] `### Related` present All required sections from `template-issue-feature` are present and non-empty. ### CONTENT QUALITY **File Targets:** The single target `terraform/dashboards/dora-dashboard.json` is a real file in the repo -- verified. However, the template calls for a "should NOT touch" section as well. Not a blocker since the scope is narrow (single file), but worth noting. **Acceptance Criteria:** Four items, all testable and specific. Each names the window (7d/30d) and metric (DF/LT). Good. **Test Expectations:** Only manual verification ("verify trend lines render correctly in Grafana"). For a Grafana dashboard JSON change, manual is reasonable -- there is no unit test framework for dashboard JSON. Acceptable. **Constraints:** The Prometheus 15d retention note is valuable. It honestly documents that the 30d rolling average will be incomplete until retention is extended or Thanos is added. This is good scope discipline -- the ticket does not try to also fix the retention problem. **User Story:** Slightly mismatched with the title. The user story says "Tier 1 DORA composite in Grafana" but the issue is specifically about rolling trend panels for DF and LT, not a composite score. Minor -- the intent is clear. **Feature Flag:** Correctly marked "None required" with reasoning (additive dashboard elements). Matches the template guidance for when to skip. ### BLOCKERS None. ### NITS 1. **File Targets "should NOT touch" list missing.** The template includes a "Files the agent should NOT touch" sub-section. For a single-file dashboard change this is low risk, but explicitly listing exclusions (e.g., other dashboard JSONs, Terraform state) prevents scope creep. 2. **User story vs. title mismatch.** User story mentions "Tier 1 DORA composite" but the ticket is about rolling trend panels for two specific metrics. Consider aligning the user story to match the actual deliverable. 3. **Related section is thin.** Lists `dora-metrics` project but does not reference sibling issues #427, #428, #429 which are also DORA dashboard improvements. Cross-referencing helps agents understand sequencing. ### VERDICT: APPROVED
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix-dashboard-metric-names
netpol-westside-ror
spec-board-centric-renderer
457-add-dns-and-caddy-config-for-myvibes-wor
411-remove-deprecated-pal-e-app-references-f
412-remove-deprecated-westside-admin-referen
fix-gem-bin-path
fix-woodpecker-multi-pipeline
345-harbor-mobile-css
290-payment-pipeline-observability
284-fix-add-pal-e-docs-namespace-to-postgres
284-add-pal-e-docs-postgres-netpol
188-cross-repo-worktree-isolation-for-parall
111-fix-keycloak-probe
86-fix-rotate-woodpecker-api-token-in-salt
71-feat-deploy-pyrra-slo-manager-with-servi
64-hotfix-woodpecker-oauth-login-broken-for
18-fix-grafana-duplicate-default-datasource-v2
18-fix-grafana-duplicate-default-datasource
13-fix-cnpg-all-parameters
No results found.
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/pal-e-platform#430
No description provided.