fix: run update-kustomize-tag step even when test step fails #275

Merged

forgejo_admin merged 2 commits from 274-fix-kustomize-tag-step-skipped into main

2026-04-07 19:30:19 +00:00

forgejo_admin commented

2026-04-07 19:25:35 +00:00

Contributor

Summary

The update-kustomize-tag step in the canonical Woodpecker template gets skipped when an unrelated test step fails, blocking deploys. This adds status: [success, failure] to the when condition so the deploy step runs regardless of test failures, as long as build-and-push succeeded.

Changes

scripts/woodpecker-update-tag-step.yaml — added status: [success, failure] to the when block of the update-kustomize-tag step. This follows the same pattern as failure: ignore at line 332 of this repo's own .woodpecker.yaml.

Test Plan

YAML validates cleanly: python3 -c "import yaml; yaml.safe_load(open('scripts/woodpecker-update-tag-step.yaml'))"
Manual verification: confirm in a repo with a failing test step that update-kustomize-tag now executes after build-and-push succeeds
No regressions in existing deploy pipelines

Review Checklist

Passed automated review-fix loop
No secrets committed
No unnecessary file changes
Commit messages are descriptive

forgejo_admin/pal-e-platform #274 — the Forgejo issue this PR implements
pal-e-platform — the project this work belongs to

Closes forgejo_admin/pal-e-platform#274

## Summary The `update-kustomize-tag` step in the canonical Woodpecker template gets skipped when an unrelated `test` step fails, blocking deploys. This adds `status: [success, failure]` to the `when` condition so the deploy step runs regardless of test failures, as long as `build-and-push` succeeded. ## Changes - `scripts/woodpecker-update-tag-step.yaml` — added `status: [success, failure]` to the `when` block of the `update-kustomize-tag` step. This follows the same pattern as `failure: ignore` at line 332 of this repo's own `.woodpecker.yaml`. ## Test Plan - [x] YAML validates cleanly: `python3 -c "import yaml; yaml.safe_load(open('scripts/woodpecker-update-tag-step.yaml'))"` - [ ] Manual verification: confirm in a repo with a failing test step that `update-kustomize-tag` now executes after `build-and-push` succeeds - [ ] No regressions in existing deploy pipelines ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related Notes - `forgejo_admin/pal-e-platform #274` — the Forgejo issue this PR implements - `pal-e-platform` — the project this work belongs to Closes forgejo_admin/pal-e-platform#274

forgejo_admin added 1 commit

2026-04-07 19:25:35 +00:00

fix: run update-kustomize-tag step even when test step fails

ci/woodpecker/push/woodpecker Pipeline was successful

Details

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

26565ffb1a

The update-kustomize-tag step only depends on build-and-push, but
Woodpecker skips it when the test step fails. Adding status: [success,
failure] to the when condition ensures the deploy step runs regardless
of unrelated test failures, as long as build-and-push succeeded.

Closes forgejo_admin/pal-e-platform#274

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin added 1 commit

2026-04-07 19:28:31 +00:00

fix: address QA nits — add comment and fix staging template

ci/woodpecker/push/woodpecker Pipeline was successful

Details

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful

Details

1d54113b6a

Add explanatory comment for the status condition so future template
consumers understand why it exists. Also add the same status condition
to the commented-out staging template for consistency.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>