ldraney/pal-e-platform
1
0
Fork 0
Code Issues 91 Pull requests 5 Projects Releases Packages Wiki Activity Actions

fix: rename westside-landing → westside-app in monitoring probe #281

Merged
forgejo_admin merged 1 commit from 208-rename-westside-landing-monitoring into main 2026-04-12 17:27:32 +00:00
Conversation 2 Commits 1 Files changed 1 +2 -2
forgejo_admin commented 2026-04-12 17:10:44 +00:00
Contributor
Copy link

Summary

Renames the blackbox exporter probe from westside-landing to westside-app to align with the repo rename.

Changes

  • terraform/modules/monitoring/main.tf — updated probe name and service label from westside-landing to westside-app

Test Plan

  • grep westside-landing terraform/modules/monitoring/main.tf returns no matches
  • After tofu apply, verify the blackbox probe target appears as westside-app in Prometheus

Review Checklist

  • grep westside-landing returns nothing in the changed file
  • No other files in the repo reference westside-landing in monitoring context

Related Notes

Related

## Summary Renames the blackbox exporter probe from `westside-landing` to `westside-app` to align with the repo rename. ## Changes - `terraform/modules/monitoring/main.tf` — updated probe `name` and `service` label from `westside-landing` to `westside-app` ## Test Plan - `grep westside-landing terraform/modules/monitoring/main.tf` returns no matches - After `tofu apply`, verify the blackbox probe target appears as `westside-app` in Prometheus ## Review Checklist - [x] `grep westside-landing` returns nothing in the changed file - [x] No other files in the repo reference `westside-landing` in monitoring context ## Related Notes - Cross-repo rename tracked in forgejo_admin/westside-landing#208 ## Related - Closes forgejo_admin/westside-landing#208
New admin surface for Lucas + Marcus to view and inline-edit jersey
and contract status on the players table. Hybrid architecture:
direct Postgres reads, writes via basketball-api PATCH endpoint
with audit logging. Keycloak SSO continuity from westside-landing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fix: rename westside-landing to westside-app in monitoring probe
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
dab59f48b0 
Aligns blackbox probe name and service label with the repo rename
from westside-landing to westside-app.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-04-12 17:16:12 +00:00
Author
Contributor
Copy link

PR #281 Review

DOMAIN REVIEW

Tech stack: Terraform (HCL) -- Helm release values for blackbox exporter probes.

The actual Terraform change is a clean 2-line rename:

  • name field: westside-landing -> westside-app
  • labels.service: westside-landing -> westside-app

The probe URL (http://westside-app.westsidekingsandqueens.svc.cluster.local:3000) was already correct and did not need changing. The rename aligns the probe name and service label with the current repo/service name. No tofu fmt or validation concerns -- this is a string value change only.

BLOCKERS

1. Unrelated file committed: docs/superpowers/specs/2026-04-10-westside-admin-design.md (183 lines added)

This is a full design spec for a new westside-admin project. It has zero relationship to renaming a monitoring probe from westside-landing to westside-app. This is textbook scope creep -- an unrelated 183-line document riding alongside a 2-line fix.

This file must be removed from this branch before merge. If it belongs in the repo, it should arrive via its own PR with its own issue reference.

NITS

None. The actual Terraform change is minimal and correct.

SOP COMPLIANCE

  • Branch named after issue: 208-rename-westside-landing-monitoring references issue #208
  • PR body follows template: Summary, Changes, Test Plan, Review Checklist, Related all present
  • Related references parent issue (forgejo_admin/westside-landing#208)
  • No unnecessary file changes -- FAIL: docs/superpowers/specs/2026-04-10-westside-admin-design.md is unrelated scope creep
  • No secrets committed
  • No plan slug expected (standalone fix)

PROCESS OBSERVATIONS

Low-risk rename. Change failure risk is near zero for the actual Terraform diff. The stowaway design spec is the only problem -- it inflates the PR from 2 changed lines to 185 additions, obscuring the actual change and violating scope discipline. Keeping PRs atomic is critical for DORA change failure rate.

VERDICT: NOT APPROVED

Remove docs/superpowers/specs/2026-04-10-westside-admin-design.md from this branch. The 2-line monitoring rename is good to go once the unrelated file is dropped.

## PR #281 Review ### DOMAIN REVIEW **Tech stack:** Terraform (HCL) -- Helm release values for blackbox exporter probes. The actual Terraform change is a clean 2-line rename: - `name` field: `westside-landing` -> `westside-app` - `labels.service`: `westside-landing` -> `westside-app` The probe URL (`http://westside-app.westsidekingsandqueens.svc.cluster.local:3000`) was already correct and did not need changing. The rename aligns the probe name and service label with the current repo/service name. No `tofu fmt` or validation concerns -- this is a string value change only. ### BLOCKERS **1. Unrelated file committed: `docs/superpowers/specs/2026-04-10-westside-admin-design.md` (183 lines added)** This is a full design spec for a new `westside-admin` project. It has zero relationship to renaming a monitoring probe from `westside-landing` to `westside-app`. This is textbook scope creep -- an unrelated 183-line document riding alongside a 2-line fix. This file must be removed from this branch before merge. If it belongs in the repo, it should arrive via its own PR with its own issue reference. ### NITS None. The actual Terraform change is minimal and correct. ### SOP COMPLIANCE - [x] Branch named after issue: `208-rename-westside-landing-monitoring` references issue #208 - [x] PR body follows template: Summary, Changes, Test Plan, Review Checklist, Related all present - [x] Related references parent issue (`forgejo_admin/westside-landing#208`) - [ ] No unnecessary file changes -- **FAIL**: `docs/superpowers/specs/2026-04-10-westside-admin-design.md` is unrelated scope creep - [x] No secrets committed - [x] No plan slug expected (standalone fix) ### PROCESS OBSERVATIONS Low-risk rename. Change failure risk is near zero for the actual Terraform diff. The stowaway design spec is the only problem -- it inflates the PR from 2 changed lines to 185 additions, obscuring the actual change and violating scope discipline. Keeping PRs atomic is critical for DORA change failure rate. ### VERDICT: NOT APPROVED Remove `docs/superpowers/specs/2026-04-10-westside-admin-design.md` from this branch. The 2-line monitoring rename is good to go once the unrelated file is dropped.
forgejo_admin force-pushed 208-rename-westside-landing-monitoring from dab59f48b0
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
to 24fbf98ceb
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
2026-04-12 17:17:32 +00:00 Compare
forgejo_admin commented 2026-04-12 17:18:46 +00:00
Author
Contributor
Copy link

PR #281 Review (Re-review)

DOMAIN REVIEW

Tech stack: Terraform/HCL (Helm release values for blackbox exporter)

The change renames the blackbox probe name and service label from westside-landing to westside-app, aligning with the repo rename. Two observations:

  1. The url field already pointed to westside-app.westsidekingsandqueens.svc.cluster.local:3000 before this PR -- only the metadata labels were stale. This PR completes the rename correctly.
  2. No other Terraform files in the repo reference westside-landing. The only remaining hits are in an untracked design spec (docs/superpowers/specs/) and .claude/worktrees/ artifacts -- neither is in scope.

No tofu fmt or tofu validate concerns with a simple string rename. No state-breaking changes -- this modifies Helm release values, not resource addresses.

BLOCKERS

None.

NITS

None. The previous review's blocker (stray design spec file) has been resolved by the force-push rebase. The diff now contains exactly the 2-line change described in the PR body.

SOP COMPLIANCE

  • Branch named after issue (208-rename-westside-landing-monitoring)
  • PR body follows template (Summary, Changes, Test Plan, Related)
  • Related references cross-repo issue forgejo_admin/westside-landing#208
  • No plan slug expected (standalone fix)
  • No secrets committed
  • No scope creep -- 1 file, 2 lines changed

PROCESS OBSERVATIONS

Clean re-review. The force-push rebase removed the stray file cleanly. Low change-failure risk -- metadata-only rename with no functional impact until tofu apply propagates the new labels to Prometheus.

VERDICT: APPROVED

## PR #281 Review (Re-review) ### DOMAIN REVIEW **Tech stack:** Terraform/HCL (Helm release values for blackbox exporter) The change renames the blackbox probe `name` and `service` label from `westside-landing` to `westside-app`, aligning with the repo rename. Two observations: 1. The `url` field already pointed to `westside-app.westsidekingsandqueens.svc.cluster.local:3000` before this PR -- only the metadata labels were stale. This PR completes the rename correctly. 2. No other Terraform files in the repo reference `westside-landing`. The only remaining hits are in an untracked design spec (`docs/superpowers/specs/`) and `.claude/worktrees/` artifacts -- neither is in scope. No `tofu fmt` or `tofu validate` concerns with a simple string rename. No state-breaking changes -- this modifies Helm release values, not resource addresses. ### BLOCKERS None. ### NITS None. The previous review's blocker (stray design spec file) has been resolved by the force-push rebase. The diff now contains exactly the 2-line change described in the PR body. ### SOP COMPLIANCE - [x] Branch named after issue (`208-rename-westside-landing-monitoring`) - [x] PR body follows template (Summary, Changes, Test Plan, Related) - [x] Related references cross-repo issue `forgejo_admin/westside-landing#208` - [x] No plan slug expected (standalone fix) - [x] No secrets committed - [x] No scope creep -- 1 file, 2 lines changed ### PROCESS OBSERVATIONS Clean re-review. The force-push rebase removed the stray file cleanly. Low change-failure risk -- metadata-only rename with no functional impact until `tofu apply` propagates the new labels to Prometheus. ### VERDICT: APPROVED
forgejo_admin deleted branch 208-rename-westside-landing-monitoring 2026-04-12 17:27:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/pal-e-platform!281
No description provided.