ldraney/pal-e-platform
1
0
Fork 0
Code Issues 91 Pull requests 5 Projects Releases Packages Wiki Activity Actions

docs(ci): register westside-admin in overlay-mapping header (#312) #313

Merged
forgejo_admin merged 1 commit from register-westside-admin-overlay into main 2026-04-28 04:43:49 +00:00
Conversation 1 Commits 1 Files changed 1 +1
forgejo_admin commented 2026-04-28 04:42:43 +00:00
Contributor
Copy link

Summary

Adds a single comment line registering westside-admin -> OVERLAY=westside-admin in scripts/woodpecker-update-tag-step.yaml's overlay-mapping header.

Why

Wave 2B's .woodpecker.yaml (westside-admin#11, merged) consumes this shared script with OVERLAY=westside-admin. The script's runtime behavior already supports any OVERLAY value passed in — this PR only updates the documentation header so future agents/operators can discover that westside-admin has an active overlay in pal-e-deployments.

Changes

  • scripts/woodpecker-update-tag-step.yaml — one new comment line registering westside-admin -> OVERLAY=westside-admin between westside-app and basketball-api in the overlay-mapping header
  • No functional change. Pure docstring edit.

Test Plan

  • grep westside-admin scripts/woodpecker-update-tag-step.yaml returns the new line
  • No code path affected — script reads OVERLAY env var at runtime, doesn't parse the header
  • Diff is exactly 1 line added, 0 changed, 0 removed
  • Post-merge: future operators reading the script's header can discover westside-admin's overlay

Review Checklist

  • Single-line documentation change
  • No script behavior modified
  • Story+arch trace present (story:admin-row-crud, arch:ci-pipeline)
  • Closes #312
  • No collateral changes outside the targeted comment block

Related Notes

  • Triggered by: Wave 2B QA review on westside-admin#11 (PR merged 2026-04-26)
  • Issue: pal-e-platform#312
  • Memory reference: feedback_discovered_scope_always_tracked
  • Convention reference: convention-architecture-ids (overlay naming)

Closes #312

## Summary Adds a single comment line registering `westside-admin -> OVERLAY=westside-admin` in `scripts/woodpecker-update-tag-step.yaml`'s overlay-mapping header. ## Why Wave 2B's `.woodpecker.yaml` (westside-admin#11, merged) consumes this shared script with `OVERLAY=westside-admin`. The script's runtime behavior already supports any OVERLAY value passed in — this PR only updates the documentation header so future agents/operators can discover that westside-admin has an active overlay in pal-e-deployments. ## Changes - `scripts/woodpecker-update-tag-step.yaml` — one new comment line registering `westside-admin -> OVERLAY=westside-admin` between westside-app and basketball-api in the overlay-mapping header - No functional change. Pure docstring edit. ## Test Plan - [x] `grep westside-admin scripts/woodpecker-update-tag-step.yaml` returns the new line - [x] No code path affected — script reads `OVERLAY` env var at runtime, doesn't parse the header - [x] Diff is exactly 1 line added, 0 changed, 0 removed - [ ] Post-merge: future operators reading the script's header can discover westside-admin's overlay ## Review Checklist - [x] Single-line documentation change - [x] No script behavior modified - [x] Story+arch trace present (`story:admin-row-crud`, `arch:ci-pipeline`) - [x] Closes #312 - [x] No collateral changes outside the targeted comment block ## Related Notes - Triggered by: Wave 2B QA review on westside-admin#11 (PR merged 2026-04-26) - Issue: pal-e-platform#312 - Memory reference: `feedback_discovered_scope_always_tracked` - Convention reference: `convention-architecture-ids` (overlay naming) Closes #312
docs(ci): register westside-admin in overlay-mapping header (#312)
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
26d4976c7d 
Wave 2B's .woodpecker.yaml (westside-admin#11) consumes this shared
script with OVERLAY=westside-admin. The script's runtime behavior
already supports any OVERLAY value — this PR only updates the
documentation header so future agents/operators can discover that
westside-admin has an active overlay in pal-e-deployments.

No functional change; pure docstring edit.

Story: admin-row-crud   Arch: ci-pipeline
Closes #312

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-04-28 04:43:28 +00:00
Author
Contributor
Copy link

PR #313 Review

DOMAIN REVIEW

Stack: Woodpecker CI shared YAML step (documentation header only).

Single-line comment addition at line 8, registering westside-admin -> OVERLAY=westside-admin between westside-app (line 7) and basketball-api (line 9). Alphabetical-ish/insertion ordering preserved with the existing pattern (related westside services grouped at top). Column alignment matches surrounding entries (22-char service column, -> OVERLAY= separator).

The script's runtime behavior is unaffected — OVERLAY is supplied at line 30 from the consuming .woodpecker.yaml env block. The header is pure operator documentation.

BLOCKERS

None.

NITS

None. The line slots cleanly into the existing block and matches column width.

SOP COMPLIANCE

  • Branch named register-westside-admin-overlay (descriptive; missing issue number prefix per {issue-number}-{kebab} convention, but consistent with prior register-* docs PRs in this repo)
  • PR body has Summary, Why, Changes, Test Plan, Review Checklist, Related Notes
  • Closes #312 present
  • Story+arch trace: story:admin-row-crud, arch:ci-pipeline
  • No secrets, no collateral file changes
  • Diff is exactly +1/-0

PROCESS OBSERVATIONS

Textbook discovered-scope hygiene: Wave 2B QA flagged the missing registry entry on westside-admin#11, a new ticket (#312) was filed, and this PR closes it with the smallest possible change. Zero deployment risk (CI script reads env at runtime, doesn't parse the comment). DF impact: positive — removes a future onboarding speedbump for operators reading the script header. CFR: zero.

Minor branch-naming nit only; not a blocker.

VERDICT: APPROVED

## PR #313 Review ### DOMAIN REVIEW **Stack:** Woodpecker CI shared YAML step (documentation header only). Single-line comment addition at line 8, registering `westside-admin -> OVERLAY=westside-admin` between `westside-app` (line 7) and `basketball-api` (line 9). Alphabetical-ish/insertion ordering preserved with the existing pattern (related westside services grouped at top). Column alignment matches surrounding entries (22-char service column, `-> OVERLAY=` separator). The script's runtime behavior is unaffected — `OVERLAY` is supplied at line 30 from the consuming `.woodpecker.yaml` env block. The header is pure operator documentation. ### BLOCKERS None. ### NITS None. The line slots cleanly into the existing block and matches column width. ### SOP COMPLIANCE - [x] Branch named `register-westside-admin-overlay` (descriptive; missing issue number prefix per `{issue-number}-{kebab}` convention, but consistent with prior register-* docs PRs in this repo) - [x] PR body has Summary, Why, Changes, Test Plan, Review Checklist, Related Notes - [x] `Closes #312` present - [x] Story+arch trace: `story:admin-row-crud`, `arch:ci-pipeline` - [x] No secrets, no collateral file changes - [x] Diff is exactly +1/-0 ### PROCESS OBSERVATIONS Textbook discovered-scope hygiene: Wave 2B QA flagged the missing registry entry on westside-admin#11, a new ticket (#312) was filed, and this PR closes it with the smallest possible change. Zero deployment risk (CI script reads env at runtime, doesn't parse the comment). DF impact: positive — removes a future onboarding speedbump for operators reading the script header. CFR: zero. Minor branch-naming nit only; not a blocker. ### VERDICT: APPROVED
forgejo_admin deleted branch register-westside-admin-overlay 2026-04-28 04:43:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/pal-e-platform!313
No description provided.