Fix: restore pal-e-docs and pal-e-ror in postgres NetworkPolicy #378
No reviewers
Labels
No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
ldraney/pal-e-platform!378
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix-postgres-netpol-restore-pal-e-docs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
pal-e-docsandpal-e-rorChanges
terraform/network-policies.tf: addedpal-e-docsandpal-e-rortonetpol_postgresingress list (2 lines)Test Plan
tofu fmt— no changestofu validate— Successtofu plan -target=kubernetes_manifest.netpol_postgres— 0 add, 1 change, 0 destroytofu applyexecuted — NetworkPolicy updated in clusterReview Checklist
Related Notes
pal-e-platform— project this affectsldraney/pal-e-platform #376— PR that caused the regressionTofu Plan Output (full)
PR #378 Review
DOMAIN REVIEW
Tech stack: OpenTofu / Kubernetes NetworkPolicy (HCL)
The diff adds two lines to
terraform/network-policies.tf, restoringpal-e-docsandpal-e-rornamespaces to thenetpol_postgresingress allowlist. Both were silently dropped by PR #376 (landscaping-assistant rewrite).Terraform correctness:
{ from = [{ namespaceSelector = { matchLabels = { "kubernetes.io/metadata.name" = "<namespace>" } } }] }. Consistent and correct.westside-rorand beforelandscaping-assistant, maintaining readable ordering.tofu fmtandtofu validateboth pass per the PR body.tofu planshows 0 add, 1 change, 0 destroy -- expected for an in-place NetworkPolicy update.k8s security:
State safety:
kubernetes_manifestresource. No state migration needed. No risk of resource recreation.Incident context:
BLOCKERS
None. This is a 2-line restoration of accidentally dropped config. No new functionality requiring tests. No user input. No secrets. No auth changes.
NITS
locals { postgres_allowed_namespaces = [...] }) to make additions append-only and deletions visible in diffs. Not blocking -- track as a separate improvement issue. Note: issue #334 documents a prior identical incident.SOP COMPLIANCE
fix-postgres-netpol-restore-pal-e-docsreferences the fix. Branch does not follow strict{issue-number}-{purpose}convention (would be377-restore-postgres-netpol), but intent is clear.Closes #377present.tofu fmtandtofu validatepass.tofu planoutput documented.PROCESS OBSERVATIONS
localsvariable would reduce recurrence risk. This is the second time this failure mode has occurred.VERDICT: APPROVED