Fix landscaping-assistant dashboard metric names #403

Open

ldraney wants to merge 15 commits from fix-dashboard-metric-names into main

pull from: fix-dashboard-metric-names

merge into: ldraney:main

ldraney:main

ldraney:netpol-westside-ror

ldraney:spec-board-centric-renderer

ldraney:457-add-dns-and-caddy-config-for-myvibes-wor

ldraney:411-remove-deprecated-pal-e-app-references-f

ldraney:412-remove-deprecated-westside-admin-referen

ldraney:fix-gem-bin-path

ldraney:fix-woodpecker-multi-pipeline

ldraney:345-harbor-mobile-css

ldraney:290-payment-pipeline-observability

ldraney:284-fix-add-pal-e-docs-namespace-to-postgres

ldraney:284-add-pal-e-docs-postgres-netpol

ldraney:188-cross-repo-worktree-isolation-for-parall

ldraney:111-fix-keycloak-probe

ldraney:86-fix-rotate-woodpecker-api-token-in-salt

ldraney:71-feat-deploy-pyrra-slo-manager-with-servi

ldraney:64-hotfix-woodpecker-oauth-login-broken-for

ldraney:18-fix-grafana-duplicate-default-datasource-v2

ldraney:18-fix-grafana-duplicate-default-datasource

ldraney:13-fix-cnpg-all-parameters

Conversation 1 Commits 15 Files changed 1 +659 -193

ldraney commented 2026-06-04 05:13:24 +00:00

Owner

Copy link

Closes #401

Summary

Dashboard queries used assumed metric names from docs. Validated against live /metrics endpoint and corrected all 8 mismatched names.

Changes

• terraform/dashboards/landscaping-assistant-golden-signals.json — fix all PromQL expressions to match actual yabeda output

Test Plan

• All metric names verified against curl https://landscaping-assistant.tail5b443a.ts.net/metrics
• tofu apply to update ConfigMap
• Panels show data in Grafana (at least health check traffic visible)

Review Checklist

• Histogram names include _seconds_ suffix (yabeda convention)
• Puma gauge names match puma-stats exporter (no threads_ prefix)
• Panel titles and legends updated to match new metric semantics

Acceptance Criteria

• All 12 panels resolve queries without "No data" (given active traffic)

Related Notes

• Follow-up to PR #402
• Validated by curling live /metrics endpoint

Closes #401 ## Summary Dashboard queries used assumed metric names from docs. Validated against live `/metrics` endpoint and corrected all 8 mismatched names. ## Changes - `terraform/dashboards/landscaping-assistant-golden-signals.json` — fix all PromQL expressions to match actual yabeda output ## Test Plan - [x] All metric names verified against `curl https://landscaping-assistant.tail5b443a.ts.net/metrics` - [ ] `tofu apply` to update ConfigMap - [ ] Panels show data in Grafana (at least health check traffic visible) ## Review Checklist - [x] Histogram names include `_seconds_` suffix (yabeda convention) - [x] Puma gauge names match puma-stats exporter (no `threads_` prefix) - [x] Panel titles and legends updated to match new metric semantics ## Acceptance Criteria - All 12 panels resolve queries without "No data" (given active traffic) ## Related Notes - Follow-up to PR #402 - Validated by curling live `/metrics` endpoint

ldraney added 1 commit 2026-06-04 05:13:24 +00:00

Fix dashboard metric names to match actual yabeda output ... 3a596edee6

Validated against live /metrics endpoint. Fixes:
- rails_request_duration_bucket → rails_request_duration_seconds_bucket
- rails_db_runtime_bucket → rails_db_runtime_seconds_bucket
- rails_view_runtime_bucket → rails_view_runtime_seconds_bucket
- puma_threads_running → puma_running
- puma_threads_total → puma_max_threads
- puma_threads_backlog → puma_backlog
- puma_threads_pool_capacity → puma_pool_capacity
- puma_workers (nonexistent) → puma_requests_count

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ldraney commented 2026-06-04 05:14:48 +00:00

Author

Owner

Copy link

PR #403 Review

DOMAIN REVIEW

Tech stack: Terraform/Grafana dashboard JSON (infrastructure/observability domain).

File changed: terraform/dashboards/landscaping-assistant-golden-signals.json (1 file)

The diff is 659 additions / 193 deletions, but the vast majority is json.dumps reformatting (compact single-line objects expanded to multi-line). The actual semantic changes are 8 metric name corrections and 3 panel title/legend updates. I verified each substantive change:

Histogram names -- adding _seconds_ suffix (yabeda convention):

• rails_request_duration_bucket -> rails_request_duration_seconds_bucket (p50, p95, p99 panels) -- CORRECT
• rails_db_runtime_bucket -> rails_db_runtime_seconds_bucket -- CORRECT
• rails_view_runtime_bucket -> rails_view_runtime_seconds_bucket -- CORRECT

Puma gauge names -- removing threads_ prefix:

• puma_threads_running -> puma_running (2 occurrences incl. utilization calc) -- CORRECT
• puma_threads_total -> puma_max_threads (2 occurrences incl. utilization calc) -- CORRECT
• puma_threads_backlog -> puma_backlog -- CORRECT
• puma_threads_pool_capacity -> puma_pool_capacity -- CORRECT

Non-existent metric replacement:

• puma_workers -> puma_requests_count -- CORRECT (panel title and legend also updated)

Utilization formula consistency check: The utilization percentage formula puma_running / clamp_min(puma_max_threads, 1) * 100 correctly uses the updated metric names on both sides of the division. No stale references remain.

Panel metadata updates: Title "Puma Workers & Pool Capacity" -> "Puma Requests & Pool Capacity" and legend labels updated to match new metric semantics ("max threads", "requests served"). These are accurate.

No structural changes: Panel IDs, grid positions, datasource references, schema version, and template variables are unchanged. The reformatting is cosmetic only.

BLOCKERS

None.

• No new functionality requiring tests (this is a data-only config fix)
• No user input handling, no secrets, no auth paths
• No code logic -- only PromQL string corrections in a declarative JSON file

NITS

1. JSON formatting churn: The reformatting from compact to expanded JSON creates noise in the diff (659+/193- for ~8 actual changes). Future dashboard edits could benefit from a consistent formatter (e.g., python -m json.tool or a pre-commit hook) so formatting is always normalized and diffs only show real changes. Not blocking -- this is a one-time cleanup.

2. Test plan has unchecked items: The PR body shows tofu apply and "Panels show data in Grafana" as unchecked. These are post-merge validation steps, which is fine, but worth confirming they will be done after merge.

SOP COMPLIANCE

• Branch named after issue -- Branch is fix-dashboard-metric-names, not 401-fix-dashboard-metric-names. Missing the issue number prefix per {issue-number}-{kebab-case-purpose} convention. Non-blocking since the parent issue #401 is already closed and this is a hotfix follow-up to PR #402.
• PR body follows template -- Has Summary, Changes, Test Plan, Review Checklist, Acceptance Criteria, Related sections
• Related references plan slug -- Related section references PR #402 but no plan slug. Acceptable for a quick-fix PR.
• No secrets committed -- No credentials, API keys, or sensitive data in the diff
• No scope creep -- All changes are strictly metric name corrections in the single dashboard file
• Commit messages -- PR title is descriptive and accurate

PROCESS OBSERVATIONS

• Change failure risk: LOW. This is a config-only fix to a Grafana dashboard. Incorrect metric names mean "No data" panels, not outages. The fix was validated against the live /metrics endpoint, which is the right approach.
• Deployment frequency: This is a fast follow-up to PR #402 (the original dashboard), showing good iteration speed.
• Documentation gap: Consider adding a brief note in the repo (README or a conventions doc) about yabeda's _seconds_ histogram naming convention so future dashboard authors don't repeat the same mistake.

VERDICT: APPROVED

Clean, well-scoped fix. All 8 metric name corrections are consistent with yabeda/puma-stats-exporter conventions. No stale references, formula consistency verified, panel metadata updated to match. The JSON reformatting noise is cosmetic and harmless.

## PR #403 Review ### DOMAIN REVIEW **Tech stack**: Terraform/Grafana dashboard JSON (infrastructure/observability domain). **File changed**: `terraform/dashboards/landscaping-assistant-golden-signals.json` (1 file) The diff is 659 additions / 193 deletions, but the vast majority is `json.dumps` reformatting (compact single-line objects expanded to multi-line). The actual semantic changes are 8 metric name corrections and 3 panel title/legend updates. I verified each substantive change: **Histogram names -- adding `_seconds_` suffix (yabeda convention):** - `rails_request_duration_bucket` -> `rails_request_duration_seconds_bucket` (p50, p95, p99 panels) -- CORRECT - `rails_db_runtime_bucket` -> `rails_db_runtime_seconds_bucket` -- CORRECT - `rails_view_runtime_bucket` -> `rails_view_runtime_seconds_bucket` -- CORRECT **Puma gauge names -- removing `threads_` prefix:** - `puma_threads_running` -> `puma_running` (2 occurrences incl. utilization calc) -- CORRECT - `puma_threads_total` -> `puma_max_threads` (2 occurrences incl. utilization calc) -- CORRECT - `puma_threads_backlog` -> `puma_backlog` -- CORRECT - `puma_threads_pool_capacity` -> `puma_pool_capacity` -- CORRECT **Non-existent metric replacement:** - `puma_workers` -> `puma_requests_count` -- CORRECT (panel title and legend also updated) **Utilization formula consistency check**: The utilization percentage formula `puma_running / clamp_min(puma_max_threads, 1) * 100` correctly uses the updated metric names on both sides of the division. No stale references remain. **Panel metadata updates**: Title "Puma Workers & Pool Capacity" -> "Puma Requests & Pool Capacity" and legend labels updated to match new metric semantics ("max threads", "requests served"). These are accurate. **No structural changes**: Panel IDs, grid positions, datasource references, schema version, and template variables are unchanged. The reformatting is cosmetic only. ### BLOCKERS None. - No new functionality requiring tests (this is a data-only config fix) - No user input handling, no secrets, no auth paths - No code logic -- only PromQL string corrections in a declarative JSON file ### NITS 1. **JSON formatting churn**: The reformatting from compact to expanded JSON creates noise in the diff (659+/193- for ~8 actual changes). Future dashboard edits could benefit from a consistent formatter (e.g., `python -m json.tool` or a pre-commit hook) so formatting is always normalized and diffs only show real changes. Not blocking -- this is a one-time cleanup. 2. **Test plan has unchecked items**: The PR body shows `tofu apply` and "Panels show data in Grafana" as unchecked. These are post-merge validation steps, which is fine, but worth confirming they will be done after merge. ### SOP COMPLIANCE - [ ] Branch named after issue -- Branch is `fix-dashboard-metric-names`, not `401-fix-dashboard-metric-names`. Missing the issue number prefix per `{issue-number}-{kebab-case-purpose}` convention. Non-blocking since the parent issue #401 is already closed and this is a hotfix follow-up to PR #402. - [x] PR body follows template -- Has Summary, Changes, Test Plan, Review Checklist, Acceptance Criteria, Related sections - [ ] Related references plan slug -- Related section references PR #402 but no plan slug. Acceptable for a quick-fix PR. - [x] No secrets committed -- No credentials, API keys, or sensitive data in the diff - [x] No scope creep -- All changes are strictly metric name corrections in the single dashboard file - [x] Commit messages -- PR title is descriptive and accurate ### PROCESS OBSERVATIONS - **Change failure risk**: LOW. This is a config-only fix to a Grafana dashboard. Incorrect metric names mean "No data" panels, not outages. The fix was validated against the live `/metrics` endpoint, which is the right approach. - **Deployment frequency**: This is a fast follow-up to PR #402 (the original dashboard), showing good iteration speed. - **Documentation gap**: Consider adding a brief note in the repo (README or a conventions doc) about yabeda's `_seconds_` histogram naming convention so future dashboard authors don't repeat the same mistake. ### VERDICT: APPROVED Clean, well-scoped fix. All 8 metric name corrections are consistent with yabeda/puma-stats-exporter conventions. No stale references, formula consistency verified, panel metadata updated to match. The JSON reformatting noise is cosmetic and harmless.

ldraney added 1 commit 2026-06-13 19:45:36 +00:00

Merge branch 'main' into fix-dashboard-metric-names c9ee1c6db7

ldraney added 1 commit 2026-06-13 20:38:38 +00:00

Merge branch 'main' into fix-dashboard-metric-names dfff393c6d

ldraney added 1 commit 2026-06-14 01:32:23 +00:00

Merge branch 'main' into fix-dashboard-metric-names 36c23c941b

ldraney added 1 commit 2026-06-14 11:34:59 +00:00

Merge branch 'main' into fix-dashboard-metric-names 08cd6ad03b

ldraney added 1 commit 2026-06-15 12:44:07 +00:00

Merge branch 'main' into fix-dashboard-metric-names 6b7a960a8f

ldraney added 1 commit 2026-06-16 00:19:41 +00:00

Merge branch 'main' into fix-dashboard-metric-names e8b70adef6

ldraney added 1 commit 2026-06-16 00:45:25 +00:00

Merge branch 'main' into fix-dashboard-metric-names 7a1681412c

ldraney added 1 commit 2026-06-16 01:05:47 +00:00

Merge branch 'main' into fix-dashboard-metric-names ada6bdc073

ldraney added 1 commit 2026-06-16 01:41:55 +00:00

Merge branch 'main' into fix-dashboard-metric-names 62ec69a3b4

ldraney added 1 commit 2026-06-16 02:35:29 +00:00

Merge branch 'main' into fix-dashboard-metric-names 277a60f2be

ldraney added 1 commit 2026-06-16 02:50:04 +00:00

Merge branch 'main' into fix-dashboard-metric-names bdcc676749

ldraney added 1 commit 2026-06-16 12:51:16 +00:00

Merge branch 'main' into fix-dashboard-metric-names 055df8171f

ldraney added 1 commit 2026-06-17 02:56:35 +00:00

Merge branch 'main' into fix-dashboard-metric-names 94cae11fd4

ldraney added 1 commit 2026-06-17 06:57:00 +00:00

Merge branch 'main' into fix-dashboard-metric-names 7955a36500

All checks were successful

Hide all checks

ci/woodpecker/push/terraform Pipeline was successful

Details

ci/woodpecker/pr/terraform Pipeline was successful

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin fix-dashboard-metric-names:fix-dashboard-metric-names

git switch fix-dashboard-metric-names

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

domain:backend

  

domain:devops

  

domain:frontend

  

status:approved

QA passed, awaiting merge approval

  

status:in-progress

Dev agent is actively working

  

status:needs-fix

QA found issues, back to dev

  

status:qa

PR submitted, awaiting QA review

  

type:bug

Bug fix

  

type:devops

Infrastructure/CI/config work

  

type:feature

New functionality

No labels

domain:backend

domain:devops

domain:frontend

status:approved

status:in-progress

status:needs-fix

status:qa

type:bug

type:devops

type:feature

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ldraney/pal-e-platform!403

No description provided.