ldraney/westside-app
1
0
Fork 0
Code Issues 17 Pull requests Projects Releases Packages Wiki Activity Actions

Jersey email: E2E validation + production send to boys #182

New issue
Closed
opened 2026-03-29 18:57:18 +00:00 by forgejo_admin · 3 comments
forgejo_admin commented 2026-03-29 18:57:18 +00:00
Contributor
Copy link

Type

Feature

Lineage

Decomposed from forgejo_admin/basketball-api#243. Ops/validation scope.

Repo

forgejo_admin/westside-landing (UI validation)
forgejo_admin/basketball-api (send trigger)

User Story

As Marcus (admin)
I want the jersey email flow validated end-to-end before sending to all boys
So that parents have a smooth ordering experience with no broken links or stale copy

Context

Template hotfixed via ConfigMap with deadline copy, Kings+Queens gear photos from Marcus, opt-out removed. Code changes (division filter, template persistence) tracked in basketball-api#243. This ticket covers the manual validation and production send gate.

File Targets

No code changes — this is an ops/validation ticket.

Dependency Gate

This ticket MUST NOT execute until both dependencies are merged and deployed:

  1. westside-landing#180 — deadline text fix on jersey page (PR #189 in review)
  2. basketball-api#243 — division filter + exclude_ordered params on send endpoint

Without #243, the send endpoint has no division filter and would email ALL parents (boys + girls).

Acceptance Criteria

  • Dependencies deployed: Both #180 and #243 merged and live in cluster
  • E2E walk-through: email link → jersey page shows 'April 10' deadline → size/number selection → Stripe checkout session created → success page
  • Stripe verified: Products active, webhook endpoint reachable, config confirmed
  • Test send: POST /admin/email/jersey-reminder?test_email=Marcusdraney23@gmail.com — Marcus approves
  • Token generation: Call POST /admin/generate-tokens to generate token for Max Jordan (paid parent, no token). Endpoint auto-generates tokens for paid parents missing them.
  • Production send: POST /admin/email/jersey-reminder?division=boys&exclude_ordered=true — sends to ~35 boys

Test Expectations

  • Playwright screenshot: jersey page with 'April 10' deadline
  • Playwright screenshot: size/number selectors working
  • Confirm Stripe webhook config via basketball-api pod env
  • Run command: manual Playwright/Chrome DevTools validation

Constraints

  • Stripe is LIVE — no test transactions without explicit approval
  • Must not send production emails until Marcus approves final test
  • Sequential: deploy deps → validate → test send → approve → production send

Checklist

  • Validation complete
  • Marcus approved
  • Production send complete

Related

  • project-westside-basketball
  • forgejo_admin/basketball-api#243 — code changes (BLOCKING dependency)
  • forgejo_admin/westside-landing#180 — deadline bug (BLOCKING dependency)
### Type Feature ### Lineage Decomposed from `forgejo_admin/basketball-api#243`. Ops/validation scope. ### Repo `forgejo_admin/westside-landing` (UI validation) `forgejo_admin/basketball-api` (send trigger) ### User Story As Marcus (admin) I want the jersey email flow validated end-to-end before sending to all boys So that parents have a smooth ordering experience with no broken links or stale copy ### Context Template hotfixed via ConfigMap with deadline copy, Kings+Queens gear photos from Marcus, opt-out removed. Code changes (division filter, template persistence) tracked in basketball-api#243. This ticket covers the manual validation and production send gate. ### File Targets No code changes — this is an ops/validation ticket. ### Dependency Gate This ticket MUST NOT execute until both dependencies are merged and deployed: 1. `westside-landing#180` — deadline text fix on jersey page (PR #189 in review) 2. `basketball-api#243` — division filter + exclude_ordered params on send endpoint Without #243, the send endpoint has no division filter and would email ALL parents (boys + girls). ### Acceptance Criteria - [ ] **Dependencies deployed:** Both #180 and #243 merged and live in cluster - [ ] **E2E walk-through:** email link → jersey page shows 'April 10' deadline → size/number selection → Stripe checkout session created → success page - [ ] **Stripe verified:** Products active, webhook endpoint reachable, config confirmed - [ ] **Test send:** `POST /admin/email/jersey-reminder?test_email=Marcusdraney23@gmail.com` — Marcus approves - [ ] **Token generation:** Call `POST /admin/generate-tokens` to generate token for Max Jordan (paid parent, no token). Endpoint auto-generates tokens for paid parents missing them. - [ ] **Production send:** `POST /admin/email/jersey-reminder?division=boys&exclude_ordered=true` — sends to ~35 boys ### Test Expectations - [ ] Playwright screenshot: jersey page with 'April 10' deadline - [ ] Playwright screenshot: size/number selectors working - [ ] Confirm Stripe webhook config via basketball-api pod env - Run command: manual Playwright/Chrome DevTools validation ### Constraints - Stripe is LIVE — no test transactions without explicit approval - Must not send production emails until Marcus approves final test - Sequential: deploy deps → validate → test send → approve → production send ### Checklist - [ ] Validation complete - [ ] Marcus approved - [ ] Production send complete ### Related - `project-westside-basketball` - `forgejo_admin/basketball-api#243` — code changes (BLOCKING dependency) - `forgejo_admin/westside-landing#180` — deadline bug (BLOCKING dependency)
forgejo_admin commented 2026-03-29 19:04:56 +00:00
Author
Contributor
Copy link

Scope Review: NEEDS_REFINEMENT

Review note: review-666-2026-03-29

Ticket is well-structured with complete template and full traceability, but has three refinement items before it can advance:

  • [BODY] AC #5 (Generate token for Max Jordan) has no documented procedure — add the method (DB query, admin endpoint, or manual insert).
  • [BODY] Add explicit dependency gate: "Do not move to next_up until westside-landing#180 and basketball-api#243 are both merged and deployed." Both are currently open (#180 in_progress, #243 in backlog).
  • [SCOPE] AC #2 references #180 for deadline fix, but the jersey page already shows "April 10" in current code. Clarify which surface #180 fixes (email template ConfigMap?) and update AC #2 accordingly.

Critical dependency: The current POST /email/jersey-reminder endpoint has no division or exclude_ordered parameters. AC #6 (production send to boys) is blocked until basketball-api#243 is deployed.

## Scope Review: NEEDS_REFINEMENT Review note: `review-666-2026-03-29` Ticket is well-structured with complete template and full traceability, but has three refinement items before it can advance: - **[BODY]** AC #5 (Generate token for Max Jordan) has no documented procedure — add the method (DB query, admin endpoint, or manual insert). - **[BODY]** Add explicit dependency gate: "Do not move to next_up until westside-landing#180 and basketball-api#243 are both merged and deployed." Both are currently open (#180 in_progress, #243 in backlog). - **[SCOPE]** AC #2 references #180 for deadline fix, but the jersey page already shows "April 10" in current code. Clarify which surface #180 fixes (email template ConfigMap?) and update AC #2 accordingly. **Critical dependency:** The current `POST /email/jersey-reminder` endpoint has no `division` or `exclude_ordered` parameters. AC #6 (production send to boys) is blocked until basketball-api#243 is deployed.
forgejo_admin commented 2026-03-29 19:05:50 +00:00
Author
Contributor
Copy link

Scope review: NEEDS_REFINEMENT → REFINED

Per review review-666-2026-03-29:

  1. Added explicit procedure for token generation (existing POST /admin/generate-tokens endpoint)
  2. Added ### Dependency Gate section — both #180 and #243 must be merged+deployed before execution
  3. Clarified #180 is about the Svelte page text (PR #189 in QA review)

Issue body updated per consolidated spec convention.

**Scope review: NEEDS_REFINEMENT → REFINED** Per review `review-666-2026-03-29`: 1. Added explicit procedure for token generation (existing `POST /admin/generate-tokens` endpoint) 2. Added `### Dependency Gate` section — both #180 and #243 must be merged+deployed before execution 3. Clarified #180 is about the Svelte page text (PR #189 in QA review) Issue body updated per consolidated spec convention.
forgejo_admin commented 2026-03-29 19:09:27 +00:00
Author
Contributor
Copy link

Scope Review: READY (re-review)

Review note: review-666-2026-03-29

All 3 findings from previous NEEDS_REFINEMENT review are resolved:

  • Token generation procedure — AC #5 now documents POST /admin/generate-tokens with clear explanation
  • Dependency gate section — New ### Dependency Gate section added with both blocking dependencies and rationale
  • #180 scope clarification — Confirmed: jersey page at +page.svelte:276 still shows "March 28", fix is needed on the page itself

Scope is solid. Ready to move backlog → todo. Hold at todo until both #180 and #243 are merged and deployed before advancing to next_up.

## Scope Review: READY (re-review) Review note: `review-666-2026-03-29` All 3 findings from previous NEEDS_REFINEMENT review are resolved: - **Token generation procedure** — AC #5 now documents `POST /admin/generate-tokens` with clear explanation - **Dependency gate section** — New `### Dependency Gate` section added with both blocking dependencies and rationale - **#180 scope clarification** — Confirmed: jersey page at `+page.svelte:276` still shows "March 28", fix is needed on the page itself Scope is solid. Ready to move `backlog → todo`. Hold at `todo` until both #180 and #243 are merged and deployed before advancing to `next_up`.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
251-docs-populate-ws-s26-prospect-user-story
252-docs-create-arch-landing-site-architectu
236-fix-jersey-image-urls
hotfix-jersey-image-urls
232-improve-public-roster-page-accuracy-and
180-fix-jersey-deadline
142-validate-coach-login-and-read-only-roste
139-fix-admin-dashboard-stats-showing-all-ze
129-validate-girls-draft-board-coach-login-a
204-auto-tag-update
deploy-update-image-tag
110-fix-harbor-push-target
No results found.
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend
No labels
domain:backend
domain:devops
domain:frontend
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/westside-app#182
No description provided.