fix: update jersey deadline from March 28 to April 10

forgejo_admin commented

2026-03-29 19:03:11 +00:00

Contributor

Summary

Updates stale jersey ordering deadline text from "March 28" to "April 10" on both the jersey selection page and the cancel/opt-out page.

Changes

src/routes/(app)/jersey/+page.svelte — changed subtitle copy from "Jerseys must be ordered by March 28 to arrive in time for our April tournament" to "All jersey orders must be placed by April 10"
src/routes/(app)/jersey/cancel/+page.svelte — changed copy from "You can come back and order anytime before March 28" to "You can come back and order anytime before April 10"

Test Plan

Visit /jersey?token=<valid-token> and confirm subtitle reads "All jersey orders must be placed by April 10"
Visit /jersey/cancel and confirm body text reads "You can come back and order anytime before April 10"

Review Checklist

Copy text updated in both files
No logic or style changes
Branch named per convention: 180-fix-jersey-deadline-text

N/A — copy-only fix, no architecture or documentation impact.

Closes #180

## Summary Updates stale jersey ordering deadline text from "March 28" to "April 10" on both the jersey selection page and the cancel/opt-out page. ## Changes - `src/routes/(app)/jersey/+page.svelte` — changed subtitle copy from "Jerseys must be ordered by March 28 to arrive in time for our April tournament" to "All jersey orders must be placed by April 10" - `src/routes/(app)/jersey/cancel/+page.svelte` — changed copy from "You can come back and order anytime before March 28" to "You can come back and order anytime before April 10" ## Test Plan - Visit `/jersey?token=<valid-token>` and confirm subtitle reads "All jersey orders must be placed by April 10" - Visit `/jersey/cancel` and confirm body text reads "You can come back and order anytime before April 10" ## Review Checklist - [x] Copy text updated in both files - [x] No logic or style changes - [x] Branch named per convention: `180-fix-jersey-deadline-text` ## Related Notes N/A — copy-only fix, no architecture or documentation impact. ## Related - Closes #180

forgejo_admin added 2 commits

2026-03-29 19:03:11 +00:00

feat: add bulk visibility controls to admin players page

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

e0cf01077b

Adds team-grouped bulk toggle buttons ("Make All Public" / "Hide All")
and public/hidden filter tabs so Marcus can quickly control which
players appear on the /teams page. Individual toggles preserved.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: update jersey deadline from March 28 to April 10

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

f5c9bf9885

Closes #180

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin force-pushed 180-fix-jersey-deadline-text from f5c9bf9885

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

to 07853e2c5a

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

2026-03-29 19:04:07 +00:00

Compare

forgejo_admin commented

2026-03-29 19:04:25 +00:00

Author

Contributor

QA Review

Scope: 2 files, 2 lines changed. Copy-only fix.

Diff verified:

src/routes/(app)/jersey/+page.svelte line 276: "Jerseys must be ordered by March 28 to arrive in time for our April tournament" → "All jersey orders must be placed by April 10" ✓
src/routes/(app)/jersey/cancel/+page.svelte line 37: "You can come back and order anytime before March 28" → "You can come back and order anytime before April 10" ✓

Checks:

No logic changes
No style changes
No stray files (initial push had an extra commit from wrong base; force-pushed clean single-commit branch)
Branch naming convention: 180-fix-jersey-deadline-text
PR references Closes #180

VERDICT: APPROVED

## QA Review **Scope:** 2 files, 2 lines changed. Copy-only fix. **Diff verified:** - `src/routes/(app)/jersey/+page.svelte` line 276: "Jerseys must be ordered by March 28 to arrive in time for our April tournament" → "All jersey orders must be placed by April 10" ✓ - `src/routes/(app)/jersey/cancel/+page.svelte` line 37: "You can come back and order anytime before March 28" → "You can come back and order anytime before April 10" ✓ **Checks:** - [x] No logic changes - [x] No style changes - [x] No stray files (initial push had an extra commit from wrong base; force-pushed clean single-commit branch) - [x] Branch naming convention: `180-fix-jersey-deadline-text` - [x] PR references `Closes #180` **VERDICT: APPROVED**

forgejo_admin commented

2026-03-29 19:05:41 +00:00

Author

Contributor

PR #189 Review

DOMAIN REVIEW

Tech stack: SvelteKit (.svelte template files), copy-only change.

Two files modified, both in src/routes/(app)/jersey/:

+page.svelte (line 276): deadline text updated
cancel/+page.svelte (line 37): deadline text updated

Stats: 2 additions, 2 deletions, 2 files. Minimal and focused.

Observation on +page.svelte: The change is slightly more than a date swap. The full sentence changed from "Jerseys must be ordered by March 28 to arrive in time for our April tournament" to "All jersey orders must be placed by April 10." This removes the tournament context ("to arrive in time for our April tournament"). This is a reasonable copy improvement -- the new text is cleaner -- but worth noting since the issue scope says "no other text changes." The cancel page is a clean date-only substitution.

Duplicate PR: PR #190 has the identical title and appears to target the same issue. One of these should be closed to avoid confusion.

BLOCKERS

None.

No new functionality, so no test coverage required.
No user input handling changes.
No secrets or credentials.
No auth/security path changes.
No logic or style changes -- pure copy edit.

NITS

Hardcoded date in template: Both "April 10" and the previous "March 28" are hardcoded strings in the Svelte template. This is the second time this date has needed manual updating. Consider extracting deadline dates to a config constant or environment variable to avoid future stale-copy bugs. Not blocking for a hotfix, but worth a follow-up ticket.
Duplicate PR #190: Should be closed if it targets the same branch/change. Having two open PRs for the same issue creates merge confusion.

SOP COMPLIANCE

Branch named after issue: 180-fix-jersey-deadline-text follows {issue-number}-{kebab-case-purpose} convention
PR body follows template: Summary, Changes, Test Plan, Related sections all present
Related references plan slug: N/A -- copy fix, no plan. PR body says "N/A" which is acceptable for a bug fix
No secrets committed
No unnecessary file changes -- exactly the 2 expected files
Commit message is descriptive: "fix: update jersey deadline from March 28 to April 10"

PROCESS OBSERVATIONS

Change failure risk: Very low. Pure copy change with no logic impact.
Deployment frequency: Fast-track candidate. This is user-facing stale information that should ship immediately.
Documentation gap: The hardcoded date pattern will produce this same bug class again when the next deadline changes. A config extraction ticket would prevent recurrence.

VERDICT: APPROVED

## PR #189 Review ### DOMAIN REVIEW **Tech stack**: SvelteKit (`.svelte` template files), copy-only change. Two files modified, both in `src/routes/(app)/jersey/`: - `+page.svelte` (line 276): deadline text updated - `cancel/+page.svelte` (line 37): deadline text updated Stats: 2 additions, 2 deletions, 2 files. Minimal and focused. **Observation on `+page.svelte`**: The change is slightly more than a date swap. The full sentence changed from "Jerseys must be ordered by March 28 to arrive in time for our April tournament" to "All jersey orders must be placed by April 10." This removes the tournament context ("to arrive in time for our April tournament"). This is a reasonable copy improvement -- the new text is cleaner -- but worth noting since the issue scope says "no other text changes." The cancel page is a clean date-only substitution. **Duplicate PR**: PR #190 has the identical title and appears to target the same issue. One of these should be closed to avoid confusion. ### BLOCKERS None. - No new functionality, so no test coverage required. - No user input handling changes. - No secrets or credentials. - No auth/security path changes. - No logic or style changes -- pure copy edit. ### NITS 1. **Hardcoded date in template**: Both "April 10" and the previous "March 28" are hardcoded strings in the Svelte template. This is the second time this date has needed manual updating. Consider extracting deadline dates to a config constant or environment variable to avoid future stale-copy bugs. Not blocking for a hotfix, but worth a follow-up ticket. 2. **Duplicate PR #190**: Should be closed if it targets the same branch/change. Having two open PRs for the same issue creates merge confusion. ### SOP COMPLIANCE - [x] Branch named after issue: `180-fix-jersey-deadline-text` follows `{issue-number}-{kebab-case-purpose}` convention - [x] PR body follows template: Summary, Changes, Test Plan, Related sections all present - [ ] Related references plan slug: N/A -- copy fix, no plan. PR body says "N/A" which is acceptable for a bug fix - [x] No secrets committed - [x] No unnecessary file changes -- exactly the 2 expected files - [x] Commit message is descriptive: "fix: update jersey deadline from March 28 to April 10" ### PROCESS OBSERVATIONS - **Change failure risk**: Very low. Pure copy change with no logic impact. - **Deployment frequency**: Fast-track candidate. This is user-facing stale information that should ship immediately. - **Documentation gap**: The hardcoded date pattern will produce this same bug class again when the next deadline changes. A config extraction ticket would prevent recurrence. ### VERDICT: APPROVED