Remove cash payment option from registration form

forgejo_admin commented

2026-04-06 16:08:24 +00:00

Contributor

Summary

Remove the cash payment option from the public registration form. Cash remains valid in the API and admin UI (Mark Paid button on player profile). This is a UI-only change.

Changes

src/routes/(app)/register/+page.svelte — removed cash radio button, cash conditional note, and cash submit text variant
src/app.css — removed unused .cash-note and .info-value-cash CSS rules

Test Plan

Verify registration form shows only "Pay Online" and "Use Promo Code" options
Verify admin player profile still has "Mark Paid (Cash)" button at line 647
Verify no references to cash remain in the registration page

Review Checklist

Only registration form UI changed; API untouched
Admin "Mark Paid (Cash)" button in players/[id]/+page.svelte confirmed untouched
Unused CSS rules removed

None

Closes #223

## Summary Remove the cash payment option from the public registration form. Cash remains valid in the API and admin UI (Mark Paid button on player profile). This is a UI-only change. ## Changes - `src/routes/(app)/register/+page.svelte` — removed cash radio button, cash conditional note, and cash submit text variant - `src/app.css` — removed unused `.cash-note` and `.info-value-cash` CSS rules ## Test Plan - Verify registration form shows only "Pay Online" and "Use Promo Code" options - Verify admin player profile still has "Mark Paid (Cash)" button at line 647 - Verify no references to cash remain in the registration page ## Review Checklist - [x] Only registration form UI changed; API untouched - [x] Admin "Mark Paid (Cash)" button in players/[id]/+page.svelte confirmed untouched - [x] Unused CSS rules removed ## Related Notes - None ## Related Closes #223

forgejo_admin added 1 commit

2026-04-06 16:08:24 +00:00

fix: remove cash payment option from registration form

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

a0e20311ae

Remove the cash radio button, its conditional note, and the submit text
variant from the public registration form. Cash remains valid in the API
and admin UI (Mark Paid button). Removes unused .cash-note and
.info-value-cash CSS rules.

Closes #223

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-04-06 16:09:31 +00:00

Author

Contributor

QA Review -- PR #224

Scope Check

Changes match issue #223 spec exactly
Only registration form UI modified; API untouched
Admin "Mark Paid (Cash)" button in players/[id]/+page.svelte confirmed untouched

Diff Review (2 files, 0 additions, 11 deletions)

src/routes/(app)/register/+page.svelte

Cash submit text variant removed from getSubmitText()
Cash radio button label removed from payment options
Cash conditional note block removed
Remaining payment options (card, promo) intact and correctly structured

src/app.css

.cash-note rule removed (line 2106)
.info-value-cash rule removed (lines 3584-3586)
No orphaned selectors or broken rule blocks

Residual Reference Check

grep -i cash on registration page returns zero matches
grep -i cash on app.css returns zero matches
No stale CSS classes left referencing removed elements

Findings

No issues found. Pure deletion PR, surgically scoped. All removed lines match the issue spec exactly.

VERDICT: APPROVED

## QA Review -- PR #224 ### Scope Check - [x] Changes match issue #223 spec exactly - [x] Only registration form UI modified; API untouched - [x] Admin "Mark Paid (Cash)" button in `players/[id]/+page.svelte` confirmed untouched ### Diff Review (2 files, 0 additions, 11 deletions) **src/routes/(app)/register/+page.svelte** - [x] Cash submit text variant removed from `getSubmitText()` - [x] Cash radio button label removed from payment options - [x] Cash conditional note block removed - [x] Remaining payment options (card, promo) intact and correctly structured **src/app.css** - [x] `.cash-note` rule removed (line 2106) - [x] `.info-value-cash` rule removed (lines 3584-3586) - [x] No orphaned selectors or broken rule blocks ### Residual Reference Check - [x] `grep -i cash` on registration page returns zero matches - [x] `grep -i cash` on app.css returns zero matches - [x] No stale CSS classes left referencing removed elements ### Findings No issues found. Pure deletion PR, surgically scoped. All removed lines match the issue spec exactly. **VERDICT: APPROVED**

forgejo_admin commented

2026-04-06 16:11:01 +00:00

Author

Contributor

PR #224 Review

DOMAIN REVIEW

Stack: SvelteKit (Svelte 5 runes), CSS

This is a deletion-only PR (0 additions, 11 deletions) that removes the cash payment option from the public registration form. The change is well-scoped:

Register page (src/routes/(app)/register/+page.svelte): Removes the cash radio button, the conditional cash-note {#if} block, and the getSubmitText() cash branch. After the PR, only 'card' and 'promo' options remain. The default paymentMethod = $state('card') is unchanged, so no dead code path can be reached.
CSS (src/app.css): Removes .cash-note and .info-value-cash rules. Verified neither class is referenced anywhere else in src/ -- both are dead CSS after the template removal.
Admin untouched: Confirmed the "Mark Paid (Cash)" button at src/routes/(app)/players/[id]/+page.svelte:647 is not in the diff. Cash remains a valid admin action.
API payload: payment_method: paymentMethod at line 129 still sends whatever is selected. Since 'cash' can no longer be selected, it will never be sent. No API contract change needed.

No accessibility, performance, or UX concerns -- this is purely removing an option, not adding or restructuring UI.

BLOCKERS

None.

This is a deletion-only change with no new functionality, so the "new functionality must have tests" blocker criterion does not apply. No user input paths added, no secrets, no DRY issues.

NITS

None. Clean removal with no orphaned code.

SOP COMPLIANCE

Branch named after issue: 223-remove-cash-registration-ui follows {issue-number}-{kebab-case-purpose}
PR body follows template: Summary, Changes, Test Plan, Related sections present
Related references issue: Closes #223
Related references plan slug: No plan slug -- acceptable for a standalone fix/ticket
No secrets committed
No scope creep -- only registration form and its CSS touched

PROCESS OBSERVATIONS

Low-risk, well-scoped UI change. Two files, all deletions. Change failure risk is minimal -- the only risk would be if some JS path still tried to set paymentMethod to 'cash', but no such code exists. Deployment frequency positive (small, independent change).

VERDICT: APPROVED

## PR #224 Review ### DOMAIN REVIEW **Stack**: SvelteKit (Svelte 5 runes), CSS This is a deletion-only PR (0 additions, 11 deletions) that removes the cash payment option from the public registration form. The change is well-scoped: - **Register page** (`src/routes/(app)/register/+page.svelte`): Removes the cash radio button, the conditional cash-note `{#if}` block, and the `getSubmitText()` cash branch. After the PR, only `'card'` and `'promo'` options remain. The default `paymentMethod = $state('card')` is unchanged, so no dead code path can be reached. - **CSS** (`src/app.css`): Removes `.cash-note` and `.info-value-cash` rules. Verified neither class is referenced anywhere else in `src/` -- both are dead CSS after the template removal. - **Admin untouched**: Confirmed the "Mark Paid (Cash)" button at `src/routes/(app)/players/[id]/+page.svelte:647` is not in the diff. Cash remains a valid admin action. - **API payload**: `payment_method: paymentMethod` at line 129 still sends whatever is selected. Since `'cash'` can no longer be selected, it will never be sent. No API contract change needed. No accessibility, performance, or UX concerns -- this is purely removing an option, not adding or restructuring UI. ### BLOCKERS None. This is a deletion-only change with no new functionality, so the "new functionality must have tests" blocker criterion does not apply. No user input paths added, no secrets, no DRY issues. ### NITS None. Clean removal with no orphaned code. ### SOP COMPLIANCE - [x] Branch named after issue: `223-remove-cash-registration-ui` follows `{issue-number}-{kebab-case-purpose}` - [x] PR body follows template: Summary, Changes, Test Plan, Related sections present - [x] Related references issue: `Closes #223` - [ ] Related references plan slug: No plan slug -- acceptable for a standalone fix/ticket - [x] No secrets committed - [x] No scope creep -- only registration form and its CSS touched ### PROCESS OBSERVATIONS Low-risk, well-scoped UI change. Two files, all deletions. Change failure risk is minimal -- the only risk would be if some JS path still tried to set `paymentMethod` to `'cash'`, but no such code exists. Deployment frequency positive (small, independent change). ### VERDICT: APPROVED