fix: use MinIO URLs for jersey page images

forgejo_admin commented

2026-04-09 05:08:01 +00:00

Contributor

Summary

Jersey images broken on production — playground asset paths (assets/images/gear/IMG_4165.jpeg) don't exist on the deployed site. Replaces with MinIO URLs conditional on division.

Changes

src/routes/(public)/jersey/+page.svelte — Replace relative playground image paths with MinIO URLs: queens-home/queens-away for girls, kings-home/kings-warmup for boys

Test Plan

Open /jersey?token=... for a girls player — queens images render
Open /jersey?token=... for a boys player — kings images render

Review Checklist

No playground paths remain
Division conditional works for both girls and boys
No unrelated changes

None.

Closes #236

## Summary Jersey images broken on production — playground asset paths (`assets/images/gear/IMG_4165.jpeg`) don't exist on the deployed site. Replaces with MinIO URLs conditional on division. ## Changes - `src/routes/(public)/jersey/+page.svelte` — Replace relative playground image paths with MinIO URLs: queens-home/queens-away for girls, kings-home/kings-warmup for boys ## Test Plan - Open `/jersey?token=...` for a girls player — queens images render - Open `/jersey?token=...` for a boys player — kings images render ## Review Checklist - [x] No playground paths remain - [x] Division conditional works for both girls and boys - [x] No unrelated changes ## Related Notes None. ## Related Closes #236

forgejo_admin added 1 commit

2026-04-09 05:08:01 +00:00

fix: use MinIO URLs for jersey page images

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

a0ce02f92b

Playground asset paths don't exist on production. Replace with
actual MinIO URLs, conditional on division (queens vs kings).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-04-09 05:08:52 +00:00

Author

Contributor

PR #240 Review

DOMAIN REVIEW

Stack: SvelteKit (Svelte template)

This is a 2-line hotfix replacing broken relative playground image paths (assets/images/gear/IMG_4165.jpeg, IMG_4164.jpeg) with MinIO URLs conditional on division. The existing division conditional logic is unchanged -- only the src attribute values are swapped. The TODO comment requesting this exact change is removed, which is correct.

The MinIO hostname (minio-api.tail5b443a.ts.net) is a known platform Tailscale hostname used across the infrastructure. The URLs are hardcoded inline rather than pulled from config/env, which is worth noting for future cleanup but acceptable for a hotfix.

No accessibility regression -- alt attributes are preserved and unchanged. No new component logic, no new imports, no bundle size impact.

BLOCKERS

None.

No new functionality added (image src swap only), so no test coverage blocker applies.
No user input involved -- URLs are static strings, no injection risk.
No secrets or credentials committed.
No DRY violation.

NITS

Hardcoded MinIO URLs -- Consider extracting the MinIO base URL (https://minio-api.tail5b443a.ts.net/assets/westside/jerseys/) to a constant or env variable. If the hostname changes, four inline URLs would need updating. Low priority for a hotfix, but worth a follow-up ticket.
Long lines -- The img tag lines are quite long with the ternary expressions. A {@const} block or local variable for imageSrc would improve readability. Non-blocking.

SOP COMPLIANCE

Branch named after issue -- fix-jersey-image-urls should be 236-fix-jersey-image-urls
PR body follows template (Summary, Changes, Test Plan, Related)
Related references issue (Closes #236)
No plan slug needed (standalone hotfix)
No secrets committed
No unrelated changes (single file, single concern)
Commit message is descriptive

PROCESS OBSERVATIONS

Minimal change failure risk -- this is a static asset URL swap with no logic changes. The branch naming convention miss is minor. Deployment frequency is healthy given the hotfix nature.

VERDICT: APPROVED

## PR #240 Review ### DOMAIN REVIEW **Stack**: SvelteKit (Svelte template) This is a 2-line hotfix replacing broken relative playground image paths (`assets/images/gear/IMG_4165.jpeg`, `IMG_4164.jpeg`) with MinIO URLs conditional on division. The existing division conditional logic is unchanged -- only the `src` attribute values are swapped. The TODO comment requesting this exact change is removed, which is correct. The MinIO hostname (`minio-api.tail5b443a.ts.net`) is a known platform Tailscale hostname used across the infrastructure. The URLs are hardcoded inline rather than pulled from config/env, which is worth noting for future cleanup but acceptable for a hotfix. No accessibility regression -- `alt` attributes are preserved and unchanged. No new component logic, no new imports, no bundle size impact. ### BLOCKERS None. - No new functionality added (image src swap only), so no test coverage blocker applies. - No user input involved -- URLs are static strings, no injection risk. - No secrets or credentials committed. - No DRY violation. ### NITS 1. **Hardcoded MinIO URLs** -- Consider extracting the MinIO base URL (`https://minio-api.tail5b443a.ts.net/assets/westside/jerseys/`) to a constant or env variable. If the hostname changes, four inline URLs would need updating. Low priority for a hotfix, but worth a follow-up ticket. 2. **Long lines** -- The `img` tag lines are quite long with the ternary expressions. A `{@const}` block or local variable for `imageSrc` would improve readability. Non-blocking. ### SOP COMPLIANCE - [ ] Branch named after issue -- `fix-jersey-image-urls` should be `236-fix-jersey-image-urls` - [x] PR body follows template (Summary, Changes, Test Plan, Related) - [x] Related references issue (Closes #236) - [x] No plan slug needed (standalone hotfix) - [x] No secrets committed - [x] No unrelated changes (single file, single concern) - [x] Commit message is descriptive ### PROCESS OBSERVATIONS Minimal change failure risk -- this is a static asset URL swap with no logic changes. The branch naming convention miss is minor. Deployment frequency is healthy given the hotfix nature. ### VERDICT: APPROVED