ldraney/westside-app
1
0
Fork 0
Code Issues 17 Pull requests Projects Releases Packages Wiki Activity Actions

Fix jersey warmup image URLs to correct MinIO filenames #242

Merged
forgejo_admin merged 1 commit from 241-fix-jersey-images into main 2026-04-09 13:22:50 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -1
forgejo_admin commented 2026-04-09 13:21:02 +00:00
Contributor
Copy link

Summary

The warmup package option on the jersey page referenced non-existent image filenames (queens-away.jpeg / kings-warmup.jpeg). Updated to the correct MinIO URLs (queens-away-new.jpeg / kings-away-new.jpeg).

Also closed stale PR #239.

Changes

  • src/routes/(public)/jersey/+page.svelte — updated warmup option img src for both girls and boys divisions to correct filenames

Test Plan

  • Load /jersey page with a girls-division player token — warmup card should show queens-away-new.jpeg
  • Load /jersey page with a boys-division player token — warmup card should show kings-away-new.jpeg
  • Verify reversible jersey images still load correctly (unchanged)

Review Checklist

  • Image URLs point to correct MinIO asset paths
  • Division-conditional logic preserved (girls vs boys)
  • No script or style changes
  • Stale PR #239 closed

Related Notes

None.

Related

Closes #241

## Summary The warmup package option on the jersey page referenced non-existent image filenames (`queens-away.jpeg` / `kings-warmup.jpeg`). Updated to the correct MinIO URLs (`queens-away-new.jpeg` / `kings-away-new.jpeg`). Also closed stale PR #239. ## Changes - `src/routes/(public)/jersey/+page.svelte` — updated warmup option img src for both girls and boys divisions to correct filenames ## Test Plan - Load `/jersey` page with a girls-division player token — warmup card should show `queens-away-new.jpeg` - Load `/jersey` page with a boys-division player token — warmup card should show `kings-away-new.jpeg` - Verify reversible jersey images still load correctly (unchanged) ## Review Checklist - [x] Image URLs point to correct MinIO asset paths - [x] Division-conditional logic preserved (girls vs boys) - [x] No script or style changes - [x] Stale PR #239 closed ## Related Notes None. ## Related Closes #241
fix: update jersey warmup image URLs to correct MinIO filenames
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
2cc0e72c5f 
The warmup package images referenced queens-away.jpeg and kings-warmup.jpeg
which don't exist. Updated to queens-away-new.jpeg and kings-away-new.jpeg.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-04-09 13:22:13 +00:00
Author
Contributor
Copy link

PR #242 Review

DOMAIN REVIEW

Stack: SvelteKit (.svelte template)

This is a 1-line asset URL fix in a Svelte template. Two image filenames are corrected:

  • queens-away.jpeg -> queens-away-new.jpeg
  • kings-warmup.jpeg -> kings-away-new.jpeg

The conditional logic (division === 'girls' ternary) is preserved. Alt text is unchanged and appropriate. No script or style changes.

One observation: the hardcoded MinIO URLs (https://minio-api.tail5b443a.ts.net/assets/westside/jerseys/...) appear across both the reversible and warmup branches. This is an existing pattern, not introduced by this PR, so not a blocker here.

BLOCKERS

None.

This is a pure asset URL correction with no new functionality, so the BLOCKER criteria (test coverage for new functionality, input validation, secrets, auth DRY) do not apply.

NITS

  • The full MinIO base URL is repeated 4 times across the two img tags visible in context. A shared constant (e.g., const JERSEY_BASE = 'https://minio-api.tail5b443a.ts.net/assets/westside/jerseys') would reduce duplication and make future URL changes single-point. Not blocking for a 1-line fix.

SOP COMPLIANCE

  • Branch named after issue: 241-fix-jersey-images matches issue #241
  • PR body follows template: Summary, Changes, Test Plan, Related all present
  • Related references issue: Closes #241
  • Related references plan slug: No plan slug referenced (noted as "None" -- acceptable for a standalone bug fix)
  • No secrets committed: No credentials in diff
  • No scope creep: Single file, single line changed

PROCESS OBSERVATIONS

Minimal change, minimal risk. This is the third iteration on jersey image URLs (#238, #239/#240, now #242), suggesting the MinIO asset naming was not documented or verified before the initial PR. A quick asset inventory before image PRs would prevent churn. Low change failure risk.

VERDICT: APPROVED

## PR #242 Review ### DOMAIN REVIEW **Stack**: SvelteKit (`.svelte` template) This is a 1-line asset URL fix in a Svelte template. Two image filenames are corrected: - `queens-away.jpeg` -> `queens-away-new.jpeg` - `kings-warmup.jpeg` -> `kings-away-new.jpeg` The conditional logic (`division === 'girls'` ternary) is preserved. Alt text is unchanged and appropriate. No script or style changes. One observation: the hardcoded MinIO URLs (`https://minio-api.tail5b443a.ts.net/assets/westside/jerseys/...`) appear across both the reversible and warmup branches. This is an existing pattern, not introduced by this PR, so not a blocker here. ### BLOCKERS None. This is a pure asset URL correction with no new functionality, so the BLOCKER criteria (test coverage for new functionality, input validation, secrets, auth DRY) do not apply. ### NITS - The full MinIO base URL is repeated 4 times across the two `img` tags visible in context. A shared constant (e.g., `const JERSEY_BASE = 'https://minio-api.tail5b443a.ts.net/assets/westside/jerseys'`) would reduce duplication and make future URL changes single-point. Not blocking for a 1-line fix. ### SOP COMPLIANCE - [x] Branch named after issue: `241-fix-jersey-images` matches issue #241 - [x] PR body follows template: Summary, Changes, Test Plan, Related all present - [x] Related references issue: `Closes #241` - [ ] Related references plan slug: No plan slug referenced (noted as "None" -- acceptable for a standalone bug fix) - [x] No secrets committed: No credentials in diff - [x] No scope creep: Single file, single line changed ### PROCESS OBSERVATIONS Minimal change, minimal risk. This is the third iteration on jersey image URLs (#238, #239/#240, now #242), suggesting the MinIO asset naming was not documented or verified before the initial PR. A quick asset inventory before image PRs would prevent churn. Low change failure risk. ### VERDICT: APPROVED
forgejo_admin deleted branch 241-fix-jersey-images 2026-04-09 13:22:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend
No labels
domain:backend
domain:devops
domain:frontend
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/westside-app!242
No description provided.