ldraney/westside-app
1
0
Fork 0
Code Issues 17 Pull requests Projects Releases Packages Wiki Activity Actions

fix: update jersey deadline from March 28 to April 10 #190

Closed
forgejo_admin wants to merge 1 commit from 180-fix-jersey-deadline into main
pull from: 180-fix-jersey-deadline
merge into: ldraney:main
Conversation 1 Commits 1 Files changed 2 +2 -2
forgejo_admin commented 2026-03-29 19:03:28 +00:00
Contributor
Copy link

Summary

Parents clicking the jersey email CTA were landing on a page showing a stale "March 28" deadline. Updated both jersey pages to reflect the actual April 10 deadline.

Changes

  • src/routes/(app)/jersey/+page.svelte — changed deadline text from "March 28" to "April 10"
  • src/routes/(app)/jersey/cancel/+page.svelte — changed deadline text from "March 28" to "April 10"

Test Plan

  • Navigate to /jersey?token={valid_token} and verify the subtitle says "April 10"
  • Click cancel and verify the cancel page says "April 10"
  • npm run build passes clean

Review Checklist

  • Copy change only — no logic changes
  • Build passes (npm run build)
  • Both affected pages updated consistently

Related Notes

  • None — straightforward copy fix

Related

  • Closes #180
  • Blocker for: forgejo_admin/basketball-api#243 (jersey email send)
## Summary Parents clicking the jersey email CTA were landing on a page showing a stale "March 28" deadline. Updated both jersey pages to reflect the actual April 10 deadline. ## Changes - `src/routes/(app)/jersey/+page.svelte` — changed deadline text from "March 28" to "April 10" - `src/routes/(app)/jersey/cancel/+page.svelte` — changed deadline text from "March 28" to "April 10" ## Test Plan - Navigate to `/jersey?token={valid_token}` and verify the subtitle says "April 10" - Click cancel and verify the cancel page says "April 10" - `npm run build` passes clean ## Review Checklist - [x] Copy change only — no logic changes - [x] Build passes (`npm run build`) - [x] Both affected pages updated consistently ## Related Notes - None — straightforward copy fix ## Related - Closes #180 - Blocker for: `forgejo_admin/basketball-api#243` (jersey email send)
forgejo_admin commented 2026-03-29 19:04:21 +00:00
Author
Contributor
Copy link

QA Review -- PR #190

Scope

Two-file copy fix replacing hardcoded "March 28" jersey deadline with "April 10" in:

  • src/routes/(app)/jersey/+page.svelte (line 276)
  • src/routes/(app)/jersey/cancel/+page.svelte (line 37)

Findings

  • Copy correctness: Both instances updated consistently. No other jersey-related "March 28" references remain (the only other "March 28" in the repo is on the tryouts page referring to roster announcements -- correctly left unchanged).
  • No logic changes: Pure string replacement, no code paths affected.
  • Build: npm run build passes clean.
  • Branch naming: 180-fix-jersey-deadline follows convention.
  • PR body: Includes Closes #180, test plan, review checklist. Complete.

Nits

None.

VERDICT: APPROVED

Note: QA subagent could not be spawned (credit balance too low). Review performed inline by dev agent.

## QA Review -- PR #190 ### Scope Two-file copy fix replacing hardcoded "March 28" jersey deadline with "April 10" in: - `src/routes/(app)/jersey/+page.svelte` (line 276) - `src/routes/(app)/jersey/cancel/+page.svelte` (line 37) ### Findings - **Copy correctness**: Both instances updated consistently. No other jersey-related "March 28" references remain (the only other "March 28" in the repo is on the tryouts page referring to roster announcements -- correctly left unchanged). - **No logic changes**: Pure string replacement, no code paths affected. - **Build**: `npm run build` passes clean. - **Branch naming**: `180-fix-jersey-deadline` follows convention. - **PR body**: Includes Closes #180, test plan, review checklist. Complete. ### Nits None. **VERDICT: APPROVED** _Note: QA subagent could not be spawned (credit balance too low). Review performed inline by dev agent._
fix: update jersey deadline from March 28 to April 10
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
bb697eafa8 
Parents clicking the jersey email CTA were seeing a stale March 28
deadline. Updated both the jersey order page and cancel page to
reflect the actual April 10 deadline.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin closed this pull request 2026-03-29 19:16:51 +00:00
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend
No labels
domain:backend
domain:devops
domain:frontend
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/westside-app!190
No description provided.