fix: add .dockerignore to prevent Kaniko vite-temp snapshot failures #231
No reviewers
Labels
No labels
domain:backend
domain:devops
domain:frontend
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
ldraney/westside-app!231
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "227-fix-vite-temp-dockerignore"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Adds a
.dockerignorefile to exclude Vite's volatilenode_modules/.vite-temp/directory from the Docker build context. These temp files are created duringnpm cibut disappear before Kaniko'sCOPY . .snapshot, causing build failures.Changes
.dockerignore(new): Excludesnode_modules/.vite-temp,.git,.env*,.DS_Store, and*.mdfrom the build contextTest Plan
npm run buildsucceeds locallylstat .../node_modules/.vite-temp/...errorsReview Checklist
Related
Related Notes
N/A — one-liner infrastructure fix, no docs impact.
PR #231 Review
DOMAIN REVIEW
Tech stack: SvelteKit (adapter-static) / Vite / Docker (Kaniko) / Woodpecker CI
This PR adds a new
.dockerignorefile to address Kaniko snapshot failures caused by volatilenode_modules/.vite-tempfiles that are created duringnpm ciand disappear beforeCOPYruns.Analysis of
.dockerignorecontents:Dockerfile interaction: The Dockerfile does
COPY package*.json ./thenRUN npm cithenCOPY . .. The.dockerignorecorrectly prevents the volatile.vite-tempdirectory from being included in the build context sent to Kaniko. Sincenpm ciruns inside the container and creates its ownnode_modules, ignoringnode_modules/.vite-tempfrom the host context is the right fix.BLOCKERS
None.
NITS
Missing
node_modulestop-level ignore. Onlynode_modules/.vite-tempis ignored, but the entirenode_modules/directory could be in.dockerignoresince the Dockerfile runsnpm ciinside the container. This would reduce build context size significantly and is standard Docker practice. Not a blocker -- outside the scope of this fix.*.mdexcludes README.md from build context. Fine since the Dockerfile builds a static SvelteKit app served by nginx.SOP COMPLIANCE
227-fix-vite-temp-dockerignorefix: add .dockerignore to prevent Kaniko vite-temp snapshot failuresVERDICT: APPROVED
Clean, minimal, well-scoped fix. The
.dockerignorecorrectly targets the volatilenode_modules/.vite-temppath that causes Kaniko snapshot failures. No blockers.