feat: add age-based team reassignment clause to Queens contracts #33

Merged

forgejo_admin merged 3 commits from 29-queens-reassignment-clause into main

2026-03-29 20:01:15 +00:00

forgejo_admin commented

2026-03-29 19:03:34 +00:00

Contributor

Summary

Adds an "Age-Based Team Reassignment" clause to Queens contracts, giving the organization discretion to move younger players to a more age-appropriate team. The clause only renders for Queens contracts (inside the existing isGirls conditional block).

Changes

src/routes/contract/[token]/+page.svelte -- Added a new "Age-Based Team Reassignment" section after "Roster Flexibility" and before "Payment Schedule" in the Girls Travel Contract block. The clause references graduating classes 2027-2031, states the organization's right to reassign, and commits to communicating any changes before they take effect.

Test Plan

npm run build passes
npm test passes (14/14 tests)
Navigate to a Queens player contract page -- reassignment clause appears after Roster Flexibility
Navigate to a Kings player contract page -- reassignment clause does NOT appear
Navigate to a Local player contract page -- reassignment clause does NOT appear

Review Checklist

Only one file changed (+page.svelte)
Clause is inside the isGirls conditional block -- Kings and Local contracts unaffected
Language is professional, firm but fair, not punitive
Build passes, all 14 tests pass
No unrelated changes

None.

Closes #29

## Summary Adds an "Age-Based Team Reassignment" clause to Queens contracts, giving the organization discretion to move younger players to a more age-appropriate team. The clause only renders for Queens contracts (inside the existing `isGirls` conditional block). ## Changes - `src/routes/contract/[token]/+page.svelte` -- Added a new "Age-Based Team Reassignment" section after "Roster Flexibility" and before "Payment Schedule" in the Girls Travel Contract block. The clause references graduating classes 2027-2031, states the organization's right to reassign, and commits to communicating any changes before they take effect. ## Test Plan - `npm run build` passes - `npm test` passes (14/14 tests) - Navigate to a Queens player contract page -- reassignment clause appears after Roster Flexibility - Navigate to a Kings player contract page -- reassignment clause does NOT appear - Navigate to a Local player contract page -- reassignment clause does NOT appear ## Review Checklist - [x] Only one file changed (`+page.svelte`) - [x] Clause is inside the `isGirls` conditional block -- Kings and Local contracts unaffected - [x] Language is professional, firm but fair, not punitive - [x] Build passes, all 14 tests pass - [x] No unrelated changes ## Related Notes None. ## Related Closes #29

forgejo_admin added 3 commits

2026-03-29 19:03:34 +00:00

feat: Queens pink branding + Nike EYBL update 67f63ea3fc

- Add queens-active CSS class that swaps --color-red to #e91e8c (pink)
- Apply queens-active on html element when isGirls is true
- Rename Nike Tournament to Nike EYBL Tournament
- Update Live Periods section: "best tournament in the country"

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: move queens-active CSS outside :root block 187e577e79

Was nested inside :root causing :root :root.queens-active selector
which never matches. Now at top level as :root.queens-active.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: add age-based team reassignment clause to Queens contracts 95f10d3cb0

Queens rosters span graduating classes 2027-2031. This clause gives the
organization discretion to move younger players to a more age-appropriate
team, communicated to the family before taking effect. Only appears on
Queens contracts (inside the isGirls conditional block).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-29 19:04:33 +00:00

Author

Contributor

QA Review -- PR #33

Scope Check

The commit on this branch (95f10d3) adds exactly 4 lines to src/routes/contract/[token]/+page.svelte. The additional changes visible in the Forgejo diff (Queens pink CSS, Nike EYBL rename) are from 2 unpushed commits on local main -- they are not part of this PR's branch work. Once main is pushed to origin, the PR diff will show only the 4-line reassignment clause. No scope creep from this PR.

Domain Review

Clause placement: Correct. The new "Age-Based Team Reassignment" section sits inside the {:else if !isLocal && isGirls} block, after "Roster Flexibility" and before "Payment Schedule". Kings and Local contracts are unaffected.

Language quality: Professional, firm but fair. Covers the key points:

References graduating classes 2027-2031 (context)
States the organization's right to reassign to a younger/lower age-group team
Explains the rationale (meaningful playing time and development)
Commits to communicating reassignment before it takes effect

No issues found:

No new logic or state -- purely additive HTML content
No a11y concerns (standard heading + paragraph structure)
Build passes, all 14 tests pass
Single file changed, no unrelated modifications

Nits

None.

VERDICT: APPROVED

## QA Review -- PR #33 ### Scope Check The commit on this branch (`95f10d3`) adds exactly 4 lines to `src/routes/contract/[token]/+page.svelte`. The additional changes visible in the Forgejo diff (Queens pink CSS, Nike EYBL rename) are from 2 unpushed commits on local `main` -- they are not part of this PR's branch work. Once `main` is pushed to origin, the PR diff will show only the 4-line reassignment clause. No scope creep from this PR. ### Domain Review **Clause placement:** Correct. The new "Age-Based Team Reassignment" section sits inside the `{:else if !isLocal && isGirls}` block, after "Roster Flexibility" and before "Payment Schedule". Kings and Local contracts are unaffected. **Language quality:** Professional, firm but fair. Covers the key points: - References graduating classes 2027-2031 (context) - States the organization's right to reassign to a younger/lower age-group team - Explains the rationale (meaningful playing time and development) - Commits to communicating reassignment before it takes effect **No issues found:** - No new logic or state -- purely additive HTML content - No a11y concerns (standard heading + paragraph structure) - Build passes, all 14 tests pass - Single file changed, no unrelated modifications ### Nits None. --- **VERDICT: APPROVED**