forgejo_admin/basketball-api
1
0
Fork 1
Code Issues 88 Pull requests 9 Projects Releases Packages Wiki Activity Actions

fix: format tests/test_players.py to pass ruff check #476

Merged
forgejo_admin merged 1 commit from 475-fix-ruff-format into main 2026-04-13 21:58:01 +00:00
Conversation 1 Commits 1 Files changed 1 +4 -1
forgejo_admin commented 2026-04-13 21:57:09 +00:00
Owner
Copy link

Summary

tests/test_players.py fails ruff format --check, causing every push-to-main pipeline to show red. One file, formatting only.

Changes

  • tests/test_players.py — applied ruff format (4 insertions, 1 deletion)

Review Checklist

  • ruff format --check . passes locally
  • No functional changes — formatting only
  • No unrelated changes

Test Plan

  • Push pipeline goes green after merge

Related Notes

None.

Related

Closes #475
Unblocks deploy of #473 (first-payment 409 fix)

## Summary `tests/test_players.py` fails `ruff format --check`, causing every push-to-main pipeline to show red. One file, formatting only. ## Changes - `tests/test_players.py` — applied `ruff format` (4 insertions, 1 deletion) ## Review Checklist - [x] `ruff format --check .` passes locally - [x] No functional changes — formatting only - [x] No unrelated changes ## Test Plan - [ ] Push pipeline goes green after merge ## Related Notes None. ## Related Closes #475 Unblocks deploy of #473 (first-payment 409 fix)
fix: format tests/test_players.py to pass ruff check
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details
a8da8d2900 
Closes #475

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
forgejo_admin commented 2026-04-13 21:57:45 +00:00
Author
Owner
Copy link

PR #476 Review

DOMAIN REVIEW

Python formatting change only. The diff reformats a single dictionary literal in tests/test_players.py from a one-liner to a multi-line format with trailing comma -- standard ruff format output. No imports changed, no logic changed, no test behavior changed.

BLOCKERS

None.

NITS

None.

SOP COMPLIANCE

  • Branch named after issue (475-fix-ruff-format)
  • PR body follows template (Summary, Changes, Test Plan, Related)
  • Related references parent issue (Closes #475)
  • No secrets committed
  • No scope creep -- single file, formatting only
  • Related does not reference a plan slug (N/A -- no plan for this work)

PROCESS OBSERVATIONS

This is a high-value low-risk fix. A formatting failure blocking all push-to-main pipelines means zero deployments can show green. Merging this directly improves deployment frequency (DORA DF) by unblocking the pipeline for all subsequent PRs, including #473 (first-payment 409 fix).

VERDICT: APPROVED

## PR #476 Review ### DOMAIN REVIEW Python formatting change only. The diff reformats a single dictionary literal in `tests/test_players.py` from a one-liner to a multi-line format with trailing comma -- standard `ruff format` output. No imports changed, no logic changed, no test behavior changed. ### BLOCKERS None. ### NITS None. ### SOP COMPLIANCE - [x] Branch named after issue (`475-fix-ruff-format`) - [x] PR body follows template (Summary, Changes, Test Plan, Related) - [x] Related references parent issue (`Closes #475`) - [x] No secrets committed - [x] No scope creep -- single file, formatting only - [ ] Related does not reference a plan slug (N/A -- no plan for this work) ### PROCESS OBSERVATIONS This is a high-value low-risk fix. A formatting failure blocking all push-to-main pipelines means zero deployments can show green. Merging this directly improves deployment frequency (DORA DF) by unblocking the pipeline for all subsequent PRs, including #473 (first-payment 409 fix). ### VERDICT: APPROVED
forgejo_admin deleted branch 475-fix-ruff-format 2026-04-13 21:58:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/basketball-api!476
No description provided.