fix: add auth header to wget for private repo download #204
No reviewers
Labels
No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo_admin/basketball-api!204
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "226-fix-wget-auth"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
update-kustomize-tagCI step downloads a script from pal-e-platform via wget, but gets a 404 because pal-e-platform is a private repoFORGEJO_TOKENsecret so wget can authenticateChanges
.woodpecker.yaml: added--header="Authorization: token ${FORGEJO_TOKEN}"to the wget command in theupdate-kustomize-tagstepTest Plan
update-kustomize-tagstep succeeds in the next Woodpecker pipeline run (wget returns 200 instead of 404)Review Checklist
Related Notes
pal-e-platform— the project this work belongs toQA Review
Scope: 1 file changed, 1 line added, 0 deleted.
Findings
Correctness -- The
--header="Authorization: token ${FORGEJO_TOKEN}"flag is correctly placed as a continuation of the multi-line wget command. TheFORGEJO_TOKENenv var is already defined in the same step (sourced fromforgejo_tokensecret), so it will resolve at runtime. This will authenticate the wget request against the private pal-e-platform repo.Security -- No secrets hardcoded. Token is referenced via environment variable from a Woodpecker secret. No credentials in the diff.
Minimality -- Exactly 1 line added. No unnecessary changes. Focused fix matching the issue description.
YAML formatting -- Indentation is consistent with surrounding lines (10 spaces, matching the URL line below it).
Nits
None.
VERDICT: APPROVE