forgejo_admin/pal-e-mcp
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

Add status parameter to search_notes tool #21

Merged
forgejo_admin merged 1 commit from 20-add-status-param-search-notes into main 2026-03-07 12:55:00 +00:00
Conversation 1 Commits 1 Files changed 1 +6
forgejo_admin commented 2026-03-07 12:50:33 +00:00
Owner
Copy link

Summary

Adds the missing status parameter to the search_notes MCP tool, matching the existing pattern in list_notes. This allows callers to filter full-text search results by note status (e.g. 'active', 'in-progress').

Changes

  • src/pal_e_docs_mcp/tools/notes.py: Added status parameter to search_notes() function signature and query param forwarding, identical to the pattern used in list_notes()

Test Plan

  • ruff check passes
  • ruff format --check passes
  • Deploy and call search_notes(query="...", status="active") to confirm the parameter is forwarded to the API
  • No regressions in other note tools

Review Checklist

  • Passed automated review-fix loop
  • No secrets committed
  • No unnecessary file changes
  • Commit messages are descriptive

Related Notes

  • plan-2026-02-26-tf-modularize-postgres — Phase 5 follow-up
  • Forgejo issue: #20
## Summary Adds the missing `status` parameter to the `search_notes` MCP tool, matching the existing pattern in `list_notes`. This allows callers to filter full-text search results by note status (e.g. 'active', 'in-progress'). ## Changes - `src/pal_e_docs_mcp/tools/notes.py`: Added `status` parameter to `search_notes()` function signature and query param forwarding, identical to the pattern used in `list_notes()` ## Test Plan - [x] `ruff check` passes - [x] `ruff format --check` passes - [ ] Deploy and call `search_notes(query="...", status="active")` to confirm the parameter is forwarded to the API - [ ] No regressions in other note tools ## Review Checklist - [x] Passed automated review-fix loop - [x] No secrets committed - [x] No unnecessary file changes - [x] Commit messages are descriptive ## Related Notes - `plan-2026-02-26-tf-modularize-postgres` — Phase 5 follow-up - Forgejo issue: #20
Add status parameter to search_notes tool
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
17a0ea337e 
Mirrors the existing status filter from list_notes so search results
can be narrowed by note status (e.g. 'active', 'in-progress').

Closes #20

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
forgejo_admin commented 2026-03-07 12:53:46 +00:00
Author
Owner
Copy link

PR #21 Review

BLOCKERS

None.

NITS

  1. search_notes is still missing parent_slug compared to list_notes. Not in scope for this issue, but worth a follow-up issue if callers need to search within a parent's children.

CODE REVIEW

  • The status parameter definition at lines 68-71 (post-merge) uses the identical Annotated[str | None, Field(...)] pattern and the exact same description string as list_notes line 23-25. Pattern match confirmed.
  • The forwarding block if status: params["status"] = status at lines 87-88 follows the same guard pattern as note_type, project, and tags. Correct.
  • Single file changed (src/pal_e_docs_mcp/tools/notes.py), +6/-0. No unrelated changes. No scope creep.
  • No secrets, no .env files, no credentials in diff.

SOP COMPLIANCE

  • Branch named after issue: 20-add-status-param-search-notes references issue #20
  • PR body has Summary, Changes, Test Plan, Related sections
  • Related references plan slug (plan-2026-02-26-tf-modularize-postgres)
  • No secrets committed
  • No unnecessary file changes (1 file, 6 lines)
  • Commit messages are descriptive

VERDICT: APPROVED

## PR #21 Review ### BLOCKERS None. ### NITS 1. `search_notes` is still missing `parent_slug` compared to `list_notes`. Not in scope for this issue, but worth a follow-up issue if callers need to search within a parent's children. ### CODE REVIEW - The `status` parameter definition at lines 68-71 (post-merge) uses the identical `Annotated[str | None, Field(...)]` pattern and the exact same description string as `list_notes` line 23-25. Pattern match confirmed. - The forwarding block `if status: params["status"] = status` at lines 87-88 follows the same guard pattern as `note_type`, `project`, and `tags`. Correct. - Single file changed (`src/pal_e_docs_mcp/tools/notes.py`), +6/-0. No unrelated changes. No scope creep. - No secrets, no `.env` files, no credentials in diff. ### SOP COMPLIANCE - [x] Branch named after issue: `20-add-status-param-search-notes` references issue #20 - [x] PR body has Summary, Changes, Test Plan, Related sections - [x] Related references plan slug (`plan-2026-02-26-tf-modularize-postgres`) - [x] No secrets committed - [x] No unnecessary file changes (1 file, 6 lines) - [x] Commit messages are descriptive ### VERDICT: APPROVED
forgejo_admin deleted branch 20-add-status-param-search-notes 2026-03-07 12:55:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
domain:backend

   
domain:devops

   
domain:frontend

   
status:approved

QA passed, awaiting merge approval

  
status:in-progress

Dev agent is actively working

  
status:needs-fix

QA found issues, back to dev

  
status:qa

PR submitted, awaiting QA review

  
type:bug

Bug fix

  
type:devops

Infrastructure/CI/config work

  
type:feature

New functionality

No labels
domain:backend
domain:devops
domain:frontend
status:approved
status:in-progress
status:needs-fix
status:qa
type:bug
type:devops
type:feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo_admin/pal-e-mcp!21
No description provided.